Title: [290910] branches/safari-613-branch/Source/WebKit
- Revision
- 290910
- Author
- [email protected]
- Date
- 2022-03-07 14:08:37 -0800 (Mon, 07 Mar 2022)
Log Message
Cherry-pick r288237. rdar://problem/87275093
WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234991
<rdar://problem/87275093>
Reviewed by Darin Adler.
Drop unnecessary default: case in the switch statement since it handles all enum values already.
* UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
(WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (290909 => 290910)
--- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-03-07 22:08:34 UTC (rev 290909)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-03-07 22:08:37 UTC (rev 290910)
@@ -1,5 +1,36 @@
2022-03-07 Russell Epstein <[email protected]>
+ Cherry-pick r288237. rdar://problem/87275093
+
+ WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
+ https://bugs.webkit.org/show_bug.cgi?id=234991
+ <rdar://problem/87275093>
+
+ Reviewed by Darin Adler.
+
+ Drop unnecessary default: case in the switch statement since it handles all enum values already.
+
+ * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
+ (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-01-19 Chris Dumez <[email protected]>
+
+ WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
+ https://bugs.webkit.org/show_bug.cgi?id=234991
+ <rdar://problem/87275093>
+
+ Reviewed by Darin Adler.
+
+ Drop unnecessary default: case in the switch statement since it handles all enum values already.
+
+ * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
+ (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
+
+2022-03-07 Russell Epstein <[email protected]>
+
Cherry-pick r287986. rdar://problem/87489048
Fix a few Objective-C object leaks due to early returns in `init`
Modified: branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm (290909 => 290910)
--- branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm 2022-03-07 22:08:34 UTC (rev 290909)
+++ branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm 2022-03-07 22:08:37 UTC (rev 290910)
@@ -60,8 +60,6 @@
if ((transports.contains(AuthenticatorTransport::Usb) || transports.contains(AuthenticatorTransport::Nfc)) && !transports.contains(AuthenticatorTransport::Internal))
[m_context addLoginChoice:adoptNS([allocASCSecurityKeyPublicKeyCredentialLoginChoiceInstance() initAssertionPlaceholderChoice]).get()];
break;
- default:
- ASSERT_NOT_REACHED();
}
m_presenterDelegate = adoptNS([[WKASCAuthorizationPresenterDelegate alloc] initWithCoordinator:*this]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
