Title: [291031] trunk/Source/WebKit
Revision
291031
Author
simon.fra...@apple.com
Date
2022-03-08 22:19:52 -0800 (Tue, 08 Mar 2022)

Log Message

Fix assertion when DOM Rendering in GPU Process is enabled with accelerated drawing disabled
https://bugs.webkit.org/show_bug.cgi?id=237626

Reviewed by Tim Horton.

Override releaseGraphicsContext() in the base class (which asserts). This subclass
doesn't need to do anything; releaseGraphicsContext() is only relevant for IOSurface-
based backends.

* WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (291030 => 291031)


--- trunk/Source/WebKit/ChangeLog	2022-03-09 06:13:25 UTC (rev 291030)
+++ trunk/Source/WebKit/ChangeLog	2022-03-09 06:19:52 UTC (rev 291031)
@@ -1,3 +1,16 @@
+2022-03-08  Simon Fraser  <simon.fra...@apple.com>
+
+        Fix assertion when DOM Rendering in GPU Process is enabled with accelerated drawing disabled
+        https://bugs.webkit.org/show_bug.cgi?id=237626
+
+        Reviewed by Tim Horton.
+
+        Override releaseGraphicsContext() in the base class (which asserts). This subclass
+        doesn't need to do anything; releaseGraphicsContext() is only relevant for IOSurface-
+        based backends.
+
+        * WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
+
 2022-03-08  Jean-Yves Avenard  <j...@apple.com>
 
         Split SourceBufferParserWebM and have platform agnostic WebMParser

Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h (291030 => 291031)


--- trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h	2022-03-09 06:13:25 UTC (rev 291030)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h	2022-03-09 06:19:52 UTC (rev 291031)
@@ -69,6 +69,7 @@
     unsigned bytesPerRow() const final;
 
     ImageBufferBackendSharing* toBackendSharing() final { return this; }
+    void releaseGraphicsContext() final { /* Do nothing. This is only relevant for IOSurface backends */ }
 
     RefPtr<ShareableBitmap> m_bitmap;
     std::unique_ptr<WebCore::GraphicsContext> m_context;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to