Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291067 => 291068)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-09 22:10:35 UTC (rev 291068)
@@ -1,5 +1,16 @@
2022-03-09 Antoine Quint <grao...@webkit.org>
+ [web-animations] dominant-baseline should support discrete animation
+ https://bugs.webkit.org/show_bug.cgi?id=237645
+
+ Reviewed by Antti Koivisto.
+
+ * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
+2022-03-09 Antoine Quint <grao...@webkit.org>
+
[css-lists] css/css-lists/inherit-overwrites.html and css/css-lists/li-counter-increment-computed-style.html are unique failures
https://bugs.webkit.org/show_bug.cgi?id=237642
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (291067 => 291068)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt 2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt 2022-03-09 22:10:35 UTC (rev 291068)
@@ -178,6 +178,9 @@
PASS cursor (type: discrete) has testAccumulation function
PASS cursor: "wait" onto "pointer"
PASS cursor: "pointer" onto "wait"
+PASS dominant-baseline (type: discrete) has testAccumulation function
+PASS dominant-baseline: "alphabetic" onto "ideographic"
+PASS dominant-baseline: "ideographic" onto "alphabetic"
PASS empty-cells (type: discrete) has testAccumulation function
PASS empty-cells: "hide" onto "show"
PASS empty-cells: "show" onto "hide"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (291067 => 291068)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt 2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt 2022-03-09 22:10:35 UTC (rev 291068)
@@ -178,6 +178,9 @@
PASS cursor (type: discrete) has testAddition function
PASS cursor: "wait" onto "pointer"
PASS cursor: "pointer" onto "wait"
+PASS dominant-baseline (type: discrete) has testAddition function
+PASS dominant-baseline: "alphabetic" onto "ideographic"
+PASS dominant-baseline: "ideographic" onto "alphabetic"
PASS empty-cells (type: discrete) has testAddition function
PASS empty-cells: "hide" onto "show"
PASS empty-cells: "show" onto "hide"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt (291067 => 291068)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt 2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt 2022-03-09 22:10:35 UTC (rev 291068)
@@ -215,6 +215,10 @@
PASS cursor uses discrete animation when animating between "pointer" and "wait" with linear easing
PASS cursor uses discrete animation when animating between "pointer" and "wait" with effect easing
PASS cursor uses discrete animation when animating between "pointer" and "wait" with keyframe easing
+PASS dominant-baseline (type: discrete) has testInterpolation function
+PASS dominant-baseline uses discrete animation when animating between "ideographic" and "alphabetic" with linear easing
+PASS dominant-baseline uses discrete animation when animating between "ideographic" and "alphabetic" with effect easing
+PASS dominant-baseline uses discrete animation when animating between "ideographic" and "alphabetic" with keyframe easing
PASS empty-cells (type: discrete) has testInterpolation function
PASS empty-cells uses discrete animation when animating between "show" and "hide" with linear easing
PASS empty-cells uses discrete animation when animating between "show" and "hide" with effect easing
Modified: trunk/Source/WebCore/ChangeLog (291067 => 291068)
--- trunk/Source/WebCore/ChangeLog 2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/Source/WebCore/ChangeLog 2022-03-09 22:10:35 UTC (rev 291068)
@@ -1,5 +1,18 @@
2022-03-09 Antoine Quint <grao...@webkit.org>
+ [web-animations] dominant-baseline should support discrete animation
+ https://bugs.webkit.org/show_bug.cgi?id=237645
+
+ Reviewed by Antti Koivisto.
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::dominantBaseline const):
+ (WebCore::RenderStyle::setDominantBaseline):
+
+2022-03-09 Antoine Quint <grao...@webkit.org>
+
[css-lists] css/css-lists/inherit-overwrites.html and css/css-lists/li-counter-increment-computed-style.html are unique failures
https://bugs.webkit.org/show_bug.cgi?id=237642
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (291067 => 291068)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-09 22:10:35 UTC (rev 291068)
@@ -2843,7 +2843,8 @@
new DiscretePropertyWrapper<FontFeatureSettings>(CSSPropertyFontFeatureSettings, &RenderStyle::fontFeatureSettings, &RenderStyle::setFontFeatureSettings),
new FontFamilyWrapper,
new DiscretePropertyWrapper<WindRule>(CSSPropertyClipRule, &RenderStyle::clipRule, &RenderStyle::setClipRule),
- new DiscretePropertyWrapper<ColorInterpolation>(CSSPropertyColorInterpolationFilters, &RenderStyle::colorInterpolationFilters, &RenderStyle::setColorInterpolationFilters)
+ new DiscretePropertyWrapper<ColorInterpolation>(CSSPropertyColorInterpolationFilters, &RenderStyle::colorInterpolationFilters, &RenderStyle::setColorInterpolationFilters),
+ new DiscretePropertyWrapper<DominantBaseline>(CSSPropertyDominantBaseline, &RenderStyle::dominantBaseline, &RenderStyle::setDominantBaseline)
};
const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (291067 => 291068)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2022-03-09 22:10:35 UTC (rev 291068)
@@ -1437,6 +1437,9 @@
ColorInterpolation colorInterpolationFilters() const { return svgStyle().colorInterpolationFilters(); }
void setColorInterpolationFilters(ColorInterpolation colorInterpolationFilters) { accessSVGStyle().setColorInterpolationFilters(colorInterpolationFilters); }
+ DominantBaseline dominantBaseline() const { return svgStyle().dominantBaseline(); }
+ void setDominantBaseline(DominantBaseline dominantBaseline) { return accessSVGStyle().setDominantBaseline(dominantBaseline); }
+
SVGPaintType fillPaintType() const { return svgStyle().fillPaintType(); }
Color fillPaintColor() const { return svgStyle().fillPaintColor(); }
void setFillPaintColor(const Color& color) { accessSVGStyle().setFillPaint(SVGPaintType::RGBColor, color, emptyString()); }
