Title: [291102] trunk/Source/WebInspectorUI
Revision
291102
Author
[email protected]
Date
2022-03-10 04:04:51 -0800 (Thu, 10 Mar 2022)

Log Message

Web Inspector: Styles Panel: CSS variable completions should be provided even without a query
https://bugs.webkit.org/show_bug.cgi?id=237679
<rdar://problem/90059628>

Reviewed by Patrick Angle.

Return the list of all available completion suggestions if `WI.CSSCompletions` is configured to allow empty
prefix search. This was already the case for classic autocompletion with prefix matching, but was missing
for fuzzy matching.

* UserInterface/Models/CSSCompletions.js:
(WI.CSSCompletions.prototype.executeQuery):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (291101 => 291102)


--- trunk/Source/WebInspectorUI/ChangeLog	2022-03-10 12:03:07 UTC (rev 291101)
+++ trunk/Source/WebInspectorUI/ChangeLog	2022-03-10 12:04:51 UTC (rev 291102)
@@ -1,3 +1,18 @@
+2022-03-10  Razvan Caliman  <[email protected]>
+
+        Web Inspector: Styles Panel: CSS variable completions should be provided even without a query
+        https://bugs.webkit.org/show_bug.cgi?id=237679
+        <rdar://problem/90059628>
+
+        Reviewed by Patrick Angle.
+
+        Return the list of all available completion suggestions if `WI.CSSCompletions` is configured to allow empty
+        prefix search. This was already the case for classic autocompletion with prefix matching, but was missing
+        for fuzzy matching.
+
+        * UserInterface/Models/CSSCompletions.js:
+        (WI.CSSCompletions.prototype.executeQuery):
+
 2022-03-08  Adrian Perez de Castro  <[email protected]> and Carlos Garcia Campos  <[email protected]>
 
         [GTK][WPE] Web Inspector: make it possible to use the remote inspector from other browsers

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js (291101 => 291102)


--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js	2022-03-10 12:03:07 UTC (rev 291101)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js	2022-03-10 12:04:51 UTC (rev 291102)
@@ -152,6 +152,9 @@
 
     executeQuery(query)
     {
+        if (!query)
+            return this._acceptEmptyPrefix ? this._values.slice() : [];
+
         this._queryController ||= new WI.CSSQueryController(this._values);
 
         return this._queryController.executeQuery(query);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to