Title: [291226] trunk
- Revision
- 291226
- Author
- grao...@webkit.org
- Date
- 2022-03-14 06:49:51 -0700 (Mon, 14 Mar 2022)
Log Message
[web-animations] marker-end should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237824
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Test failures are due to SVGURIReference::fragmentIdentifierFromIRIString() rejecting the values used in the
test which do not contain a "#". While this is not the greatest test values for this property, this is indeed
a bug that we reject the value during parsing instead of storing it.
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291225 => 291226)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-14 13:21:44 UTC (rev 291225)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-14 13:49:51 UTC (rev 291226)
@@ -1,3 +1,18 @@
+2022-03-14 Antoine Quint <grao...@webkit.org>
+
+ [web-animations] marker-end should support discrete animation
+ https://bugs.webkit.org/show_bug.cgi?id=237824
+
+ Reviewed by Antti Koivisto.
+
+ Test failures are due to SVGURIReference::fragmentIdentifierFromIRIString() rejecting the values used in the
+ test which do not contain a "#". While this is not the greatest test values for this property, this is indeed
+ a bug that we reject the value during parsing instead of storing it.
+
+ * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
+
2022-03-11 Antoine Quint <grao...@webkit.org>
[web-animations] shape-rendering should support discrete animation
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt (291225 => 291226)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt 2022-03-14 13:21:44 UTC (rev 291225)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt 2022-03-14 13:49:51 UTC (rev 291226)
@@ -31,6 +31,9 @@
PASS list-style-type (type: discrete) has testAccumulation function
PASS list-style-type: "square" onto "circle"
PASS list-style-type: "circle" onto "square"
+PASS marker-end (type: discrete) has testAccumulation function
+FAIL marker-end: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "none"
+FAIL marker-end: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")" assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
PASS mask (type: discrete) has testAccumulation function
FAIL mask: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "url(\"http://localhost/test-2\") 0% 0% / auto repeat border-box border-box add match-source"
FAIL mask: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")" assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-1\") 0% 0% / auto repeat border-box border-box add match-source"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt (291225 => 291226)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt 2022-03-14 13:21:44 UTC (rev 291225)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt 2022-03-14 13:49:51 UTC (rev 291226)
@@ -31,6 +31,9 @@
PASS list-style-type (type: discrete) has testAddition function
PASS list-style-type: "square" onto "circle"
PASS list-style-type: "circle" onto "square"
+PASS marker-end (type: discrete) has testAddition function
+FAIL marker-end: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "none"
+FAIL marker-end: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")" assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
PASS mask (type: discrete) has testAddition function
FAIL mask: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "url(\"http://localhost/test-2\") 0% 0% / auto repeat border-box border-box add match-source"
FAIL mask: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")" assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-1\") 0% 0% / auto repeat border-box border-box add match-source"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt (291225 => 291226)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt 2022-03-14 13:21:44 UTC (rev 291225)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt 2022-03-14 13:49:51 UTC (rev 291226)
@@ -38,6 +38,10 @@
PASS list-style-type uses discrete animation when animating between "circle" and "square" with linear easing
PASS list-style-type uses discrete animation when animating between "circle" and "square" with effect easing
PASS list-style-type uses discrete animation when animating between "circle" and "square" with keyframe easing
+PASS marker-end (type: discrete) has testInterpolation function
+FAIL marker-end uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with linear easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
+FAIL marker-end uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
+FAIL marker-end uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with keyframe easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
PASS mask (type: discrete) has testInterpolation function
FAIL mask uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with linear easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-1\") 0% 0% / auto repeat border-box border-box add match-source"
FAIL mask uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-1\") 0% 0% / auto repeat border-box border-box add match-source"
Modified: trunk/Source/WebCore/ChangeLog (291225 => 291226)
--- trunk/Source/WebCore/ChangeLog 2022-03-14 13:21:44 UTC (rev 291225)
+++ trunk/Source/WebCore/ChangeLog 2022-03-14 13:49:51 UTC (rev 291226)
@@ -1,3 +1,13 @@
+2022-03-14 Antoine Quint <grao...@webkit.org>
+
+ [web-animations] marker-end should support discrete animation
+ https://bugs.webkit.org/show_bug.cgi?id=237824
+
+ Reviewed by Antti Koivisto.
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
2022-03-14 Enrique Ocaña González <eoca...@igalia.com>
[MSE][SourceBuffer] Fix removal of paddings from buffered range
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (291225 => 291226)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-14 13:21:44 UTC (rev 291225)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-14 13:49:51 UTC (rev 291226)
@@ -3266,7 +3266,8 @@
new DiscretePropertyWrapper<LineJoin>(CSSPropertyStrokeLinejoin, &RenderStyle::joinStyle, &RenderStyle::setJoinStyle),
new DiscreteSVGPropertyWrapper<TextAnchor>(CSSPropertyTextAnchor, &SVGRenderStyle::textAnchor, &SVGRenderStyle::setTextAnchor),
new DiscreteSVGPropertyWrapper<VectorEffect>(CSSPropertyVectorEffect, &SVGRenderStyle::vectorEffect, &SVGRenderStyle::setVectorEffect),
- new DiscreteSVGPropertyWrapper<ShapeRendering>(CSSPropertyShapeRendering, &SVGRenderStyle::shapeRendering, &SVGRenderStyle::setShapeRendering)
+ new DiscreteSVGPropertyWrapper<ShapeRendering>(CSSPropertyShapeRendering, &SVGRenderStyle::shapeRendering, &SVGRenderStyle::setShapeRendering),
+ new DiscreteSVGPropertyWrapper<const String&>(CSSPropertyMarkerEnd, &SVGRenderStyle::markerEndResource, &SVGRenderStyle::setMarkerEndResource)
};
const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
