Title: [291273] releases/WebKitGTK/webkit-2.36/LayoutTests
- Revision
- 291273
- Author
- carlo...@webkit.org
- Date
- 2022-03-15 02:04:54 -0700 (Tue, 15 Mar 2022)
Log Message
Merge r290723 - [ATSPI] Test accessibility/select-element-at-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=237315
Reviewed by Adrian Perez de Castro.
This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
should behave like all other ports now.
* accessibility/select-element-at-index.html:
* platform/glib/TestExpectations:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291272 => 291273)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:54 UTC (rev 291273)
@@ -1,3 +1,16 @@
+2022-03-02 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [ATSPI] Test accessibility/select-element-at-index.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=237315
+
+ Reviewed by Adrian Perez de Castro.
+
+ This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
+ should behave like all other ports now.
+
+ * accessibility/select-element-at-index.html:
+ * platform/glib/TestExpectations:
+
2022-03-01 Carlos Garcia Campos <cgar...@igalia.com>
[ATSPI] Remove layout tests checking children added/removed notifications
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html (291272 => 291273)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html 2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html 2022-03-15 09:04:54 UTC (rev 291273)
@@ -51,13 +51,7 @@
// "Option 4" is the third of three selected items, thus the index should be 2.
shouldBeTrue("selectElement.selectedChildAtIndex(2).isEqual(option4)");
- // In ATSPI removeSelectionAtIndex() the index is with respect to the array of
- // selected children; not the array of all children. Thus to remove the selection
- // from "Option 4" in ATSPI, we again need to specify an index of 2.
- if (accessibilityController.platformName == "atspi")
- selectElement.removeSelectionAtIndex(2);
- else
- selectElement.removeSelectionAtIndex(3);
+ selectElement.removeSelectionAtIndex(3);
shouldBeFalse("option4.isSelected");
shouldBe("selectElement.selectedChildrenCount", "2");
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations (291272 => 291273)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations 2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations 2022-03-15 09:04:54 UTC (rev 291273)
@@ -413,9 +413,6 @@
webkit.org/b/232256 accessibility/auto-fill-crash.html [ Timeout ]
-# Tests failing with ATSPI implementation.
-webkit.org/b/235941 accessibility/select-element-at-index.html [ Failure ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of Accessibility-related bugs
#////////////////////////////////////////////////////////////////////////////////////////
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
