Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291285 => 291286)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 14:16:27 UTC (rev 291286)
@@ -1,3 +1,12 @@
+2022-03-15 Antti Koivisto <[email protected]>
+
+ CSSConditionRule.conditionText should be readonly
+ https://bugs.webkit.org/show_bug.cgi?id=237880
+
+ Reviewed by Antoine Quint.
+
+ * web-platform-tests/interfaces/css-conditional.idl:
+
2022-03-15 Antoine Quint <[email protected]>
Dialog element only animates once
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-conditional.idl (291285 => 291286)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-conditional.idl 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-conditional.idl 2022-03-15 14:16:27 UTC (rev 291286)
@@ -9,7 +9,7 @@
[Exposed=Window]
interface CSSConditionRule : CSSGroupingRule {
- attribute CSSOMString conditionText;
+ readonly attribute CSSOMString conditionText;
};
[Exposed=Window]
Modified: trunk/Source/WebCore/ChangeLog (291285 => 291286)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 14:16:27 UTC (rev 291286)
@@ -1,3 +1,23 @@
+2022-03-15 Antti Koivisto <[email protected]>
+
+ CSSConditionRule.conditionText should be readonly
+ https://bugs.webkit.org/show_bug.cgi?id=237880
+
+ Reviewed by Antoine Quint.
+
+ Per CSSWG resolution https://github.com/w3c/csswg-drafts/issues/6819#issuecomment-1016695585
+
+ This also matches Blink.
+
+ * css/CSSConditionRule.h:
+ * css/CSSConditionRule.idl:
+ * css/CSSMediaRule.cpp:
+ (WebCore::CSSMediaRule::setConditionText): Deleted.
+ * css/CSSMediaRule.h:
+ * css/CSSSupportsRule.cpp:
+ (WebCore::CSSSupportsRule::setConditionText): Deleted.
+ * css/CSSSupportsRule.h:
+
2022-03-15 Enrique Ocaña González <[email protected]>
[GStreamer][MSE] add ac-3,ec-3 and flac codecs gst caps
Modified: trunk/Source/WebCore/css/CSSConditionRule.h (291285 => 291286)
--- trunk/Source/WebCore/css/CSSConditionRule.h 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSConditionRule.h 2022-03-15 14:16:27 UTC (rev 291286)
@@ -36,7 +36,6 @@
class CSSConditionRule : public CSSGroupingRule {
public:
virtual String conditionText() const = 0;
- virtual void setConditionText(const String&) = 0;
protected:
CSSConditionRule(StyleRuleGroup&, CSSStyleSheet* parent);
Modified: trunk/Source/WebCore/css/CSSConditionRule.idl (291285 => 291286)
--- trunk/Source/WebCore/css/CSSConditionRule.idl 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSConditionRule.idl 2022-03-15 14:16:27 UTC (rev 291286)
@@ -32,5 +32,5 @@
[
Exposed=Window
] interface CSSConditionRule : CSSGroupingRule {
- attribute CSSOMString conditionText;
+ readonly attribute CSSOMString conditionText;
};
Modified: trunk/Source/WebCore/css/CSSMediaRule.cpp (291285 => 291286)
--- trunk/Source/WebCore/css/CSSMediaRule.cpp 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSMediaRule.cpp 2022-03-15 14:16:27 UTC (rev 291286)
@@ -60,11 +60,6 @@
return mediaQueries().mediaText();
}
-void CSSMediaRule::setConditionText(const String& text)
-{
- mediaQueries().set(text);
-}
-
MediaList* CSSMediaRule::media() const
{
if (!m_mediaCSSOMWrapper)
Modified: trunk/Source/WebCore/css/CSSMediaRule.h (291285 => 291286)
--- trunk/Source/WebCore/css/CSSMediaRule.h 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSMediaRule.h 2022-03-15 14:16:27 UTC (rev 291286)
@@ -44,7 +44,6 @@
void reattach(StyleRuleBase&) final;
String cssText() const final;
String conditionText() const final;
- void setConditionText(const String&) final;
MediaQuerySet& mediaQueries() const;
Modified: trunk/Source/WebCore/css/CSSSupportsRule.cpp (291285 => 291286)
--- trunk/Source/WebCore/css/CSSSupportsRule.cpp 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSSupportsRule.cpp 2022-03-15 14:16:27 UTC (rev 291286)
@@ -61,9 +61,4 @@
return downcast<StyleRuleSupports>(groupRule()).conditionText();
}
-void CSSSupportsRule::setConditionText(const String&)
-{
- // FIXME: Not implemented yet.
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/css/CSSSupportsRule.h (291285 => 291286)
--- trunk/Source/WebCore/css/CSSSupportsRule.h 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSSupportsRule.h 2022-03-15 14:16:27 UTC (rev 291286)
@@ -43,7 +43,6 @@
String cssText() const final;
String conditionText() const final;
- void setConditionText(const String&) final;
private:
CSSSupportsRule(StyleRuleSupports&, CSSStyleSheet*);
