Title: [291311] trunk/Source/WebKit
Revision
291311
Author
cdu...@apple.com
Date
2022-03-15 13:45:47 -0700 (Tue, 15 Mar 2022)

Log Message

Fix logging in GPUProcessProxy::didCreateContextForVisibilityPropagation()
https://bugs.webkit.org/show_bug.cgi?id=237907

Reviewed by Simon Fraser.

LayerHostingContextID is a uint32_t. The current printing ends up logging negative values:
`GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: 7, pagePID: 79, contextID: -2041854761`

* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::didCreateContextForVisibilityPropagation):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (291310 => 291311)


--- trunk/Source/WebKit/ChangeLog	2022-03-15 20:30:16 UTC (rev 291310)
+++ trunk/Source/WebKit/ChangeLog	2022-03-15 20:45:47 UTC (rev 291311)
@@ -1,3 +1,16 @@
+2022-03-15  Chris Dumez  <cdu...@apple.com>
+
+        Fix logging in GPUProcessProxy::didCreateContextForVisibilityPropagation()
+        https://bugs.webkit.org/show_bug.cgi?id=237907
+
+        Reviewed by Simon Fraser.
+
+        LayerHostingContextID is a uint32_t. The current printing ends up logging negative values:
+        `GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: 7, pagePID: 79, contextID: -2041854761`
+
+        * UIProcess/GPU/GPUProcessProxy.cpp:
+        (WebKit::GPUProcessProxy::didCreateContextForVisibilityPropagation):
+
 2022-03-15  Aditya Keerthi  <akeer...@apple.com>
 
         [iOS] Indefinite hang when printing using a UIPrintPageRenderer

Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp (291310 => 291311)


--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp	2022-03-15 20:30:16 UTC (rev 291310)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp	2022-03-15 20:45:47 UTC (rev 291311)
@@ -590,7 +590,7 @@
 #if HAVE(VISIBILITY_PROPAGATION_VIEW)
 void GPUProcessProxy::didCreateContextForVisibilityPropagation(WebPageProxyIdentifier webPageProxyID, WebCore::PageIdentifier pageID, LayerHostingContextID contextID)
 {
-    RELEASE_LOG(Process, "GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: %" PRIu64 ", pagePID: %" PRIu64 ", contextID: %d", webPageProxyID.toUInt64(), pageID.toUInt64(), contextID);
+    RELEASE_LOG(Process, "GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: %" PRIu64 ", pagePID: %" PRIu64 ", contextID: %u", webPageProxyID.toUInt64(), pageID.toUInt64(), contextID);
     auto* page = WebProcessProxy::webPage(webPageProxyID);
     if (!page) {
         RELEASE_LOG(Process, "GPUProcessProxy::didCreateContextForVisibilityPropagation() No WebPageProxy with this identifier");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to