Title: [291382] trunk/Source/WebGPU
- Revision
- 291382
- Author
- mmaxfi...@apple.com
- Date
- 2022-03-16 19:30:20 -0700 (Wed, 16 Mar 2022)
Log Message
[WebGPU] Implement queue submission methods according to the spec
https://bugs.webkit.org/show_bug.cgi?id=237869
Reviewed by Kimmo Kinnunen.
Addressing post-review comments.
* WebGPU/Queue.mm:
(WebGPU::Queue::submit):
Modified Paths
Diff
Modified: trunk/Source/WebGPU/ChangeLog (291381 => 291382)
--- trunk/Source/WebGPU/ChangeLog 2022-03-17 00:55:31 UTC (rev 291381)
+++ trunk/Source/WebGPU/ChangeLog 2022-03-17 02:30:20 UTC (rev 291382)
@@ -1,5 +1,17 @@
2022-03-16 Myles C. Maxfield <mmaxfi...@apple.com>
+ [WebGPU] Implement queue submission methods according to the spec
+ https://bugs.webkit.org/show_bug.cgi?id=237869
+
+ Reviewed by Kimmo Kinnunen.
+
+ Addressing post-review comments.
+
+ * WebGPU/Queue.mm:
+ (WebGPU::Queue::submit):
+
+2022-03-16 Myles C. Maxfield <mmaxfi...@apple.com>
+
[WebGPU] Put nontrivial code in WebGPU's command line playground
https://bugs.webkit.org/show_bug.cgi?id=237876
Modified: trunk/Source/WebGPU/WebGPU/Queue.mm (291381 => 291382)
--- trunk/Source/WebGPU/WebGPU/Queue.mm 2022-03-17 00:55:31 UTC (rev 291381)
+++ trunk/Source/WebGPU/WebGPU/Queue.mm 2022-03-17 02:30:20 UTC (rev 291382)
@@ -86,11 +86,11 @@
for (auto commandBuffer : commands) {
ASSERT(commandBuffer.get().commandBuffer().commandQueue == m_commandQueue); //
[commandBuffer.get().commandBuffer() addCompletedHandler:[protectedThis = Ref { *this }] (id<MTLCommandBuffer>) {
- protectedThis->scheduleWork([protectedThis = protectedThis.copyRef()]() {
+ protectedThis->scheduleWork(CompletionHandler<void(void)>([protectedThis = protectedThis.copyRef()]() {
++(protectedThis->m_completedCommandBufferCount);
for (auto& callback : protectedThis->m_onSubmittedWorkDoneCallbacks.take(protectedThis->m_completedCommandBufferCount))
callback(WGPUQueueWorkDoneStatus_Success);
- });
+ }, CompletionHandlerCallThread::MainThread));
}];
// "Execute each command in commandBuffer.[[command_list]]."
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
