Title: [291732] trunk/Source/WebKit
Revision
291732
Author
[email protected]
Date
2022-03-22 18:39:19 -0700 (Tue, 22 Mar 2022)

Log Message

REGRESSION (248499@main): [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::NetworkProcess::prepareToSuspend()
https://bugs.webkit.org/show_bug.cgi?id=238234
<rdar://problem/90665237>

Reviewed by Chris Dumez.

Invoke completion handler on early return.

* NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::suspend):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (291731 => 291732)


--- trunk/Source/WebKit/ChangeLog	2022-03-23 01:27:54 UTC (rev 291731)
+++ trunk/Source/WebKit/ChangeLog	2022-03-23 01:39:19 UTC (rev 291732)
@@ -1,3 +1,16 @@
+2022-03-22  Sihui Liu  <[email protected]>
+
+        REGRESSION (248499@main): [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::NetworkProcess::prepareToSuspend()
+        https://bugs.webkit.org/show_bug.cgi?id=238234
+        <rdar://problem/90665237>
+
+        Reviewed by Chris Dumez.
+
+        Invoke completion handler on early return.
+
+        * NetworkProcess/storage/NetworkStorageManager.cpp:
+        (WebKit::NetworkStorageManager::suspend):
+
 2022-03-22  Megan Gardner  <[email protected]>
 
         Expand autocorrect context for more accurate results. 

Modified: trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp (291731 => 291732)


--- trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp	2022-03-23 01:27:54 UTC (rev 291731)
+++ trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp	2022-03-23 01:39:19 UTC (rev 291732)
@@ -646,7 +646,7 @@
     ASSERT(RunLoop::isMain());
 
     if (m_sessionID.isEphemeral())
-        return;
+        return completionHandler();
 
     m_queue->suspend([this, protectedThis = Ref { *this }] {
         for (auto& manager : m_localOriginStorageManagers.values()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to