Diff
Modified: trunk/Source/WebCore/ChangeLog (291733 => 291734)
--- trunk/Source/WebCore/ChangeLog 2022-03-23 02:06:04 UTC (rev 291733)
+++ trunk/Source/WebCore/ChangeLog 2022-03-23 04:25:54 UTC (rev 291734)
@@ -1,3 +1,18 @@
+2022-03-22 Alex Christensen <[email protected]>
+
+ Add a few more WEBCORE_EXPORT macros
+ https://bugs.webkit.org/show_bug.cgi?id=238214
+
+ Reviewed by Eric Carlson.
+
+ These are needed to successfully link when building with -fsanitize=fuzzer,address
+
+ * dom/Document.h:
+ * html/HTMLCollection.h:
+ * html/HTMLOptionsCollection.h:
+ * platform/Pasteboard.h:
+ * platform/mediastream/mac/CoreAudioCaptureSource.h:
+
2022-03-22 Chris Dumez <[email protected]>
Use ASCIILiteral in a few more places where it is useful
Modified: trunk/Source/WebCore/dom/Document.h (291733 => 291734)
--- trunk/Source/WebCore/dom/Document.h 2022-03-23 02:06:04 UTC (rev 291733)
+++ trunk/Source/WebCore/dom/Document.h 2022-03-23 04:25:54 UTC (rev 291734)
@@ -835,7 +835,7 @@
void registerNodeListForInvalidation(LiveNodeList&);
void unregisterNodeListForInvalidation(LiveNodeList&);
WEBCORE_EXPORT void registerCollection(HTMLCollection&);
- void unregisterCollection(HTMLCollection&);
+ WEBCORE_EXPORT void unregisterCollection(HTMLCollection&);
void collectionCachedIdNameMap(const HTMLCollection&);
void collectionWillClearIdNameMap(const HTMLCollection&);
bool shouldInvalidateNodeListAndCollectionCaches() const;
Modified: trunk/Source/WebCore/html/HTMLCollection.h (291733 => 291734)
--- trunk/Source/WebCore/html/HTMLCollection.h 2022-03-23 02:06:04 UTC (rev 291733)
+++ trunk/Source/WebCore/html/HTMLCollection.h 2022-03-23 04:25:54 UTC (rev 291734)
@@ -61,9 +61,9 @@
// HTMLCollection subclasses NodeList to maintain legacy ObjC API compatibility.
class HTMLCollection : public NodeList {
- WTF_MAKE_ISO_ALLOCATED(HTMLCollection);
+ WTF_MAKE_ISO_ALLOCATED_EXPORT(HTMLCollection, WEBCORE_EXPORT);
public:
- virtual ~HTMLCollection();
+ WEBCORE_EXPORT virtual ~HTMLCollection();
// DOM API
Element* item(unsigned index) const override = 0; // Tighten return type from NodeList::item().
@@ -81,7 +81,7 @@
ContainerNode& ownerNode() const;
ContainerNode& rootNode() const;
void invalidateCacheForAttribute(const QualifiedName& attributeName);
- virtual void invalidateCacheForDocument(Document&);
+ WEBCORE_EXPORT virtual void invalidateCacheForDocument(Document&);
void invalidateCache() { invalidateCacheForDocument(document()); }
bool hasNamedElementCache() const;
@@ -89,7 +89,7 @@
protected:
HTMLCollection(ContainerNode& base, CollectionType);
- virtual void updateNamedElementCache() const;
+ WEBCORE_EXPORT virtual void updateNamedElementCache() const;
WEBCORE_EXPORT Element* namedItemSlow(const AtomString& name) const;
void setNamedItemCache(std::unique_ptr<CollectionNamedElementCache>) const;
Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.h (291733 => 291734)
--- trunk/Source/WebCore/html/HTMLOptionsCollection.h 2022-03-23 02:06:04 UTC (rev 291733)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.h 2022-03-23 04:25:54 UTC (rev 291734)
@@ -30,7 +30,7 @@
namespace WebCore {
class HTMLOptionsCollection final : public CachedHTMLCollection<HTMLOptionsCollection, CollectionTypeTraits<SelectOptions>::traversalType> {
- WTF_MAKE_ISO_ALLOCATED(HTMLOptionsCollection);
+ WTF_MAKE_ISO_ALLOCATED_EXPORT(HTMLOptionsCollection, WEBCORE_EXPORT);
public:
using Base = CachedHTMLCollection<HTMLOptionsCollection, CollectionTypeTraits<SelectOptions>::traversalType>;
Modified: trunk/Source/WebCore/platform/Pasteboard.h (291733 => 291734)
--- trunk/Source/WebCore/platform/Pasteboard.h 2022-03-23 02:06:04 UTC (rev 291733)
+++ trunk/Source/WebCore/platform/Pasteboard.h 2022-03-23 04:25:54 UTC (rev 291734)
@@ -252,7 +252,7 @@
WEBCORE_EXPORT static std::unique_ptr<Pasteboard> createForDragAndDrop(std::unique_ptr<PasteboardContext>&&);
WEBCORE_EXPORT static std::unique_ptr<Pasteboard> create(const DragData&);
- virtual void setDragImage(DragImage, const IntPoint& hotSpot);
+ WEBCORE_EXPORT virtual void setDragImage(DragImage, const IntPoint& hotSpot);
#endif
#if PLATFORM(WIN)
Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h (291733 => 291734)
--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h 2022-03-23 02:06:04 UTC (rev 291733)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h 2022-03-23 04:25:54 UTC (rev 291734)
@@ -51,7 +51,7 @@
class CoreAudioCaptureSource : public RealtimeMediaSource {
public:
- static CaptureSourceOrError create(String&& deviceID, String&& hashSalt, const MediaConstraints*, PageIdentifier);
+ WEBCORE_EXPORT static CaptureSourceOrError create(String&& deviceID, String&& hashSalt, const MediaConstraints*, PageIdentifier);
static CaptureSourceOrError createForTesting(String&& deviceID, String&& label, String&& hashSalt, const MediaConstraints*, BaseAudioSharedUnit& overrideUnit, PageIdentifier);
WEBCORE_EXPORT static AudioCaptureFactory& factory();
