Title: [291785] trunk
- Revision
- 291785
- Author
- commit-qu...@webkit.org
- Date
- 2022-03-23 22:33:58 -0700 (Wed, 23 Mar 2022)
Log Message
[JSC] Fix remoteFunctionCallGenerator on MIPS
https://bugs.webkit.org/show_bug.cgi?id=238274
Patch by Geza Lore <gl...@igalia.com> on 2022-03-23
Reviewed by Yusuke Suzuki.
JSTests:
* stress/shadow-realm-evaluate.js:
Source/_javascript_Core:
Eliminate register conflict (nonArgGPR0 == regT4, which is used in
valueRegs)
* jit/ThunkGenerators.cpp:
(JSC::remoteFunctionCallGenerator):
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (291784 => 291785)
--- trunk/JSTests/ChangeLog 2022-03-24 04:35:12 UTC (rev 291784)
+++ trunk/JSTests/ChangeLog 2022-03-24 05:33:58 UTC (rev 291785)
@@ -1,3 +1,12 @@
+2022-03-23 Geza Lore <gl...@igalia.com>
+
+ [JSC] Fix remoteFunctionCallGenerator on MIPS
+ https://bugs.webkit.org/show_bug.cgi?id=238274
+
+ Reviewed by Yusuke Suzuki.
+
+ * stress/shadow-realm-evaluate.js:
+
2022-03-23 Patrick Angle <pan...@apple.com>
No breakpoints hit on github.com, and some are invalid
Modified: trunk/JSTests/stress/shadow-realm-evaluate.js (291784 => 291785)
--- trunk/JSTests/stress/shadow-realm-evaluate.js 2022-03-24 04:35:12 UTC (rev 291784)
+++ trunk/JSTests/stress/shadow-realm-evaluate.js 2022-03-24 05:33:58 UTC (rev 291785)
@@ -1,4 +1,3 @@
-//@ skip if "mips" == $architecture
//@ requireOptions("--useShadowRealm=1")
function shouldBe(actual, expected) {
Modified: trunk/Source/_javascript_Core/ChangeLog (291784 => 291785)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-24 04:35:12 UTC (rev 291784)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-24 05:33:58 UTC (rev 291785)
@@ -1,3 +1,16 @@
+2022-03-23 Geza Lore <gl...@igalia.com>
+
+ [JSC] Fix remoteFunctionCallGenerator on MIPS
+ https://bugs.webkit.org/show_bug.cgi?id=238274
+
+ Reviewed by Yusuke Suzuki.
+
+ Eliminate register conflict (nonArgGPR0 == regT4, which is used in
+ valueRegs)
+
+ * jit/ThunkGenerators.cpp:
+ (JSC::remoteFunctionCallGenerator):
+
2022-03-23 Chris Dumez <cdu...@apple.com>
Prepare JSC for making the String(const char*) constructor explicit
Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (291784 => 291785)
--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2022-03-24 04:35:12 UTC (rev 291784)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2022-03-24 05:33:58 UTC (rev 291785)
@@ -1502,11 +1502,10 @@
jit.storePtr(GPRInfo::regT1, jit.addressFor(loopIndex));
+ jit.prepareCallOperation(vm);
+ jit.setupArguments<decltype(operationGetWrappedValueForTarget)>(GPRInfo::regT0, valueRegs);
jit.move(CCallHelpers::TrustedImmPtr(tagCFunction<OperationPtrTag>(operationGetWrappedValueForTarget)), GPRInfo::nonArgGPR0);
emitPointerValidation(jit, GPRInfo::nonArgGPR0, OperationPtrTag);
-
- jit.setupArguments<decltype(operationGetWrappedValueForTarget)>(GPRInfo::regT0, valueRegs);
- jit.prepareCallOperation(vm);
jit.call(GPRInfo::nonArgGPR0, OperationPtrTag);
exceptionChecks.append(jit.emitJumpIfException(vm));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
