Title: [107542] trunk/Source/WebCore
Revision
107542
Author
[email protected]
Date
2012-02-13 00:53:26 -0800 (Mon, 13 Feb 2012)

Log Message

Web Inspector: get rid of cycles in containment view of an object.
https://bugs.webkit.org/show_bug.cgi?id=78462

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (107541 => 107542)


--- trunk/Source/WebCore/ChangeLog	2012-02-13 08:18:38 UTC (rev 107541)
+++ trunk/Source/WebCore/ChangeLog	2012-02-13 08:53:26 UTC (rev 107542)
@@ -1,3 +1,14 @@
+2012-02-13  Ilya Tikhonovsky  <[email protected]>
+
+        Web Inspector: get rid of cycles in containment view of an object.
+        https://bugs.webkit.org/show_bug.cgi?id=78462
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/DetailedHeapshotGridNodes.js:
+        (WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
+        (WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
+
 2012-02-12  Adam Barth  <[email protected]>
 
         Remove ENABLE(MEDIA_STREAM) from Navigator.h

Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js (107541 => 107542)


--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js	2012-02-13 08:18:38 UTC (rev 107541)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js	2012-02-13 08:53:26 UTC (rev 107542)
@@ -379,16 +379,14 @@
 WebInspector.HeapSnapshotObjectNode.prototype = {
     updateHasChildren: function(parentGridNode)
     {
-        if (this.showRetainingEdges) {
-            this._parentGridNode = parentGridNode;
-            var ancestor = parentGridNode;
-            while (ancestor) {
-                if (ancestor.snapshotNodeId === this.snapshotNodeId) {
-                    this._cycledWithAncestorGridNode = ancestor;
-                    return;
-                }
-                ancestor = ancestor._parentGridNode;
+        this._parentGridNode = parentGridNode;
+        var ancestor = parentGridNode;
+        while (ancestor) {
+            if (ancestor.snapshotNodeId === this.snapshotNodeId) {
+                this._cycledWithAncestorGridNode = ancestor;
+                return;
             }
+            ancestor = ancestor._parentGridNode;
         }
         WebInspector.HeapSnapshotGenericObjectNode.prototype.updateHasChildren.call(this);
     },
@@ -468,7 +466,7 @@
 
     _prefixObjectCell: function(div, data)
     {
-        if (this.showRetainingEdges && this._cycledWithAncestorGridNode)
+        if (this._cycledWithAncestorGridNode)
             div.className += " cycled-ancessor-node";
 
         var nameSpan = document.createElement("span");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to