Title: [292107] trunk/LayoutTests
- Revision
- 292107
- Author
- [email protected]
- Date
- 2022-03-30 10:01:11 -0700 (Wed, 30 Mar 2022)
Log Message
Unreviewed, fix test after r285521 and r271735
* http/tests/paymentrequest/updateWith-shippingOptions.https.html:
Remove a duplicate `assert_equals` added in r271735 (which should've been removed in r285521).
Drive-by: Also check that the `selected` of each provided shipping method/option matches.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (292106 => 292107)
--- trunk/LayoutTests/ChangeLog 2022-03-30 14:56:39 UTC (rev 292106)
+++ trunk/LayoutTests/ChangeLog 2022-03-30 17:01:11 UTC (rev 292107)
@@ -1,3 +1,11 @@
+2022-03-30 Devin Rousso <[email protected]>
+
+ Unreviewed, fix test after r285521 and r271735
+
+ * http/tests/paymentrequest/updateWith-shippingOptions.https.html:
+ Remove a duplicate `assert_equals` added in r271735 (which should've been removed in r285521).
+ Drive-by: Also check that the `selected` of each provided shipping method/option matches.
+
2022-03-30 Youenn Fablet <[email protected]>
Implement ServiceWorker WindowClient.ancestorOrigins
Modified: trunk/LayoutTests/http/tests/paymentrequest/updateWith-shippingOptions.https.html (292106 => 292107)
--- trunk/LayoutTests/http/tests/paymentrequest/updateWith-shippingOptions.https.html 2022-03-30 14:56:39 UTC (rev 292106)
+++ trunk/LayoutTests/http/tests/paymentrequest/updateWith-shippingOptions.https.html 2022-03-30 17:01:11 UTC (rev 292107)
@@ -92,9 +92,9 @@
assert_equals(internals.mockPaymentCoordinator.shippingMethods[i].identifier, detailsUpdate.shippingOptions[i].id, `shipping option ${i} id should change`);
assert_equals(internals.mockPaymentCoordinator.shippingMethods[i].label, detailsUpdate.shippingOptions[i].label, `shipping option ${i} label should change`);
assert_equals(internals.mockPaymentCoordinator.shippingMethods[i].amount, detailsUpdate.shippingOptions[i].amount.value, `shipping option ${i} amount should change`);
+ assert_equals(internals.mockPaymentCoordinator.shippingMethods[i].selected, detailsUpdate.shippingOptions[i].selected, `shipping option ${i} selected should change`);
}
assert_equals(request.shippingOption, detailsUpdate.shippingOptions.findLast((shippingOption) => shippingOption.selected).id, "selected shipping option should change");
- assert_equals(request.shippingOption, detailsUpdate.shippingOptions[0].id, "selected shipping option should change");
assert_equals(response.shippingOption, request.shippingOption, "selected shipping option should also be exposed on the response");
await response.complete("success");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes