Title: [292214] trunk/Source/WebCore
Revision
292214
Author
[email protected]
Date
2022-04-01 03:49:10 -0700 (Fri, 01 Apr 2022)

Log Message

Unreviewed, fix obsolete FIXME comments in CSSParserFastPaths.cpp

- overflow-anchor is still not implemented, and the visible value has been removed from the spec.
- text-combine-upright was implemented in r287487

* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (292213 => 292214)


--- trunk/Source/WebCore/ChangeLog	2022-04-01 09:17:30 UTC (rev 292213)
+++ trunk/Source/WebCore/ChangeLog	2022-04-01 10:49:10 UTC (rev 292214)
@@ -1,3 +1,13 @@
+2022-04-01  Tim Nguyen  <[email protected]>
+
+        Unreviewed, fix obsolete FIXME comments in CSSParserFastPaths.cpp
+
+        - overflow-anchor is still not implemented, and the visible value has been removed from the spec.
+        - text-combine-upright was implemented in r287487
+
+        * css/parser/CSSParserFastPaths.cpp:
+        (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+
 2022-04-01  Carlos Garcia Campos  <[email protected]>
 
         REGRESSION(r290360): [GLX] Crash on process exit

Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (292213 => 292214)


--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2022-04-01 09:17:30 UTC (rev 292213)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2022-04-01 10:49:10 UTC (rev 292214)
@@ -671,7 +671,7 @@
         return valueID == CSSValueAuto || valueID == CSSValueNone || (valueID >= CSSValueInset && valueID <= CSSValueDouble);
     // FIXME-NEWPARSER: Support?
     // case CSSPropertyOverflowAnchor:
-    //    return valueID == CSSValueVisible || valueID == CSSValueNone || valueID == CSSValueAuto;
+    //    return valueID == CSSValueNone || valueID == CSSValueAuto;
     case CSSPropertyOverflowWrap: // normal | break-word | anywhere
     case CSSPropertyWordWrap:
         return valueID == CSSValueNormal || valueID == CSSValueBreakWord || valueID == CSSValueAnywhere;
@@ -724,9 +724,6 @@
 #endif
     case CSSPropertyTextAnchor:
         return valueID == CSSValueStart || valueID == CSSValueMiddle || valueID == CSSValueEnd;
-// FIXME-NEWPARSER: Support
-//    case CSSPropertyTextCombineUpright:
-//        return valueID == CSSValueNone || valueID == CSSValueAll;
     case CSSPropertyTextDecorationStyle:
         // solid | double | dotted | dashed | wavy
         return valueID == CSSValueSolid || valueID == CSSValueDouble || valueID == CSSValueDotted || valueID == CSSValueDashed || valueID == CSSValueWavy;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to