Title: [107588] trunk
- Revision
- 107588
- Author
- [email protected]
- Date
- 2012-02-13 11:23:52 -0800 (Mon, 13 Feb 2012)
Log Message
AX: the web area should report that focus can be set to itself
https://bugs.webkit.org/show_bug.cgi?id=78272
Reviewed by Beth Dakin.
Source/WebCore:
Test: platform/mac/accessibility/webarea-can-set-focus.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
Fixed erroneous comment.
LayoutTests:
* platform/mac/accessibility/webarea-can-set-focus-expected.txt: Added.
* platform/mac/accessibility/webarea-can-set-focus.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (107587 => 107588)
--- trunk/LayoutTests/ChangeLog 2012-02-13 19:05:27 UTC (rev 107587)
+++ trunk/LayoutTests/ChangeLog 2012-02-13 19:23:52 UTC (rev 107588)
@@ -1,3 +1,13 @@
+2012-02-13 Chris Fleizach <[email protected]>
+
+ AX: the web area should report that focus can be set to itself
+ https://bugs.webkit.org/show_bug.cgi?id=78272
+
+ Reviewed by Beth Dakin.
+
+ * platform/mac/accessibility/webarea-can-set-focus-expected.txt: Added.
+ * platform/mac/accessibility/webarea-can-set-focus.html: Added.
+
2012-02-13 Tony Chang <[email protected]>
[chromium] Unreviewed, update mac-snowleopard result. This matches
Added: trunk/LayoutTests/platform/mac/accessibility/webarea-can-set-focus-expected.txt (0 => 107588)
--- trunk/LayoutTests/platform/mac/accessibility/webarea-can-set-focus-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/webarea-can-set-focus-expected.txt 2012-02-13 19:23:52 UTC (rev 107588)
@@ -0,0 +1,10 @@
+This tests that the web area's focus can be settable.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS body.isFocusable is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/webarea-can-set-focus.html (0 => 107588)
--- trunk/LayoutTests/platform/mac/accessibility/webarea-can-set-focus.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/webarea-can-set-focus.html 2012-02-13 19:23:52 UTC (rev 107588)
@@ -0,0 +1,29 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that the web area's focus can be settable.");
+
+ if (window.accessibilityController) {
+
+ var tree = document.getElementById("body");
+ body.focus();
+
+ // Test tree attributes.
+ body = accessibilityController.focusedElement;
+ shouldBe("body.isFocusable", "true");
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (107587 => 107588)
--- trunk/Source/WebCore/ChangeLog 2012-02-13 19:05:27 UTC (rev 107587)
+++ trunk/Source/WebCore/ChangeLog 2012-02-13 19:23:52 UTC (rev 107588)
@@ -1,3 +1,18 @@
+2012-02-13 Chris Fleizach <[email protected]>
+
+ AX: the web area should report that focus can be set to itself
+ https://bugs.webkit.org/show_bug.cgi?id=78272
+
+ Reviewed by Beth Dakin.
+
+ Test: platform/mac/accessibility/webarea-can-set-focus.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
+ * accessibility/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::isDataTable):
+ Fixed erroneous comment.
+
2012-02-13 Patrick Gansterer <[email protected]>
Port RunLoop to WinCE
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (107587 => 107588)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-02-13 19:05:27 UTC (rev 107587)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-02-13 19:23:52 UTC (rev 107588)
@@ -3348,6 +3348,9 @@
{
Node* node = this->node();
+ if (isWebArea())
+ return true;
+
// NOTE: It would be more accurate to ask the document whether setFocusedNode() would
// do anything. For example, setFocusedNode() will do nothing if the current focused
// node will not relinquish the focus.
Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (107587 => 107588)
--- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2012-02-13 19:05:27 UTC (rev 107587)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2012-02-13 19:23:52 UTC (rev 107588)
@@ -170,7 +170,7 @@
if (!row && isTHCell)
headersInFirstRowCount++;
- // If the first column is comprised of all <tg> tags, assume it is a data table.
+ // If the first column is comprised of all <th> tags, assume it is a data table.
if (!col && isTHCell)
headersInFirstColumnCount++;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
