Title: [292284] trunk
Revision
292284
Author
[email protected]
Date
2022-04-04 01:37:53 -0700 (Mon, 04 Apr 2022)

Log Message

REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
https://bugs.webkit.org/show_bug.cgi?id=238584

Reviewed by Simon Fraser.

Source/WTF:

Enable ResizeObserver for legacy WebKit.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

Enable ResizeObserver for wk1 test.

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

LayoutTests:

* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/resize-observer/change-layout-in-error-expected.txt: Removed.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (292283 => 292284)


--- trunk/LayoutTests/ChangeLog	2022-04-04 08:03:30 UTC (rev 292283)
+++ trunk/LayoutTests/ChangeLog	2022-04-04 08:37:53 UTC (rev 292284)
@@ -1,3 +1,14 @@
+2022-04-04  Cathie Chen  <[email protected]>
+
+        REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
+        https://bugs.webkit.org/show_bug.cgi?id=238584
+
+        Reviewed by Simon Fraser.
+
+        * platform/mac-wk1/TestExpectations:
+        * platform/mac-wk1/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt: Removed.
+        * platform/mac-wk1/imported/w3c/web-platform-tests/resize-observer/change-layout-in-error-expected.txt: Removed.
+
 2022-04-04  Myles C. Maxfield  <[email protected]>
 
         [WebGPU] Unskip the first few passing WebGPU tests

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (292283 => 292284)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-04-04 08:03:30 UTC (rev 292283)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-04-04 08:37:53 UTC (rev 292284)
@@ -1695,13 +1695,6 @@
 
 webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]
 
-# webkit.org/b/238584 These 5 tests are constantly failing on wk1
-imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-001.html [ Failure ]
-imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-002.html [ Failure ]
-imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-003.html [ Failure ]
-imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-004.html [ Failure ]
-imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-005.html [ Failure ]
-
 webkit.org/b/209878 [ Debug ] webrtc/datachannel/multiple-connections.html [ Pass Failure Slow ]
 
 webkit.org/b/230055 [ BigSur ] webrtc/datachannel/datachannel-page-cache-send.html [ Pass Timeout ]

Deleted: trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt (292283 => 292284)


--- trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt	2022-04-04 08:03:30 UTC (rev 292283)
+++ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-031-expected.txt	2022-04-04 08:37:53 UTC (rev 292284)
@@ -1,10 +0,0 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: ReferenceError: Can't find variable: ResizeObserver
-
-Harness Error (FAIL), message = Unhandled rejection: Can't find variable: ResizeObserver
-
-TIMEOUT ResizeObserver skipped while hidden Test timed out
-
-Harness Error (FAIL), message = Unhandled rejection: Can't find variable: ResizeObserver
-
-TIMEOUT ResizeObserver skipped while hidden Test timed out
-

Modified: trunk/Source/WTF/ChangeLog (292283 => 292284)


--- trunk/Source/WTF/ChangeLog	2022-04-04 08:03:30 UTC (rev 292283)
+++ trunk/Source/WTF/ChangeLog	2022-04-04 08:37:53 UTC (rev 292284)
@@ -1,3 +1,14 @@
+2022-04-04  Cathie Chen  <[email protected]>
+
+        REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
+        https://bugs.webkit.org/show_bug.cgi?id=238584
+
+        Reviewed by Simon Fraser.
+
+        Enable ResizeObserver for legacy WebKit.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2022-04-03  Tim Horton  <[email protected]>
 
         _WKDataTask doesn't work in macCatalyst

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (292283 => 292284)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-04-04 08:03:30 UTC (rev 292283)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-04-04 08:37:53 UTC (rev 292284)
@@ -1219,7 +1219,6 @@
       "USE(GSTREAMER)": true
       default: false
 
-# FIXME: This is on by default in WebKit2. Perhaps we should consider turning it on for WebKitLegacy as well.
 ResizeObserverEnabled:
   type: bool
   humanReadableName: "Resize Observer"
@@ -1226,11 +1225,11 @@
   humanReadableDescription: "Enable Resize Observer support"
   defaultValue:
     WebKitLegacy:
-      default: false
+      default: true
     WebKit:
       default: true
     WebCore:
-      default: false
+      default: true
 
 ResolutionMediaFeatureEnabled:
   type: bool

Modified: trunk/Tools/ChangeLog (292283 => 292284)


--- trunk/Tools/ChangeLog	2022-04-04 08:03:30 UTC (rev 292283)
+++ trunk/Tools/ChangeLog	2022-04-04 08:37:53 UTC (rev 292284)
@@ -1,3 +1,15 @@
+2022-04-04  Cathie Chen  <[email protected]>
+
+        REGRESSION(r291797): [wk1] 5 contain-intrinsic-size* tests are constant text failures
+        https://bugs.webkit.org/show_bug.cgi?id=238584
+
+        Reviewed by Simon Fraser.
+
+        Enable ResizeObserver for wk1 test.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (WTR::TestOptions::defaults):
+
 2022-04-02  Myles C. Maxfield  <[email protected]>
 
         [Cocoa] Automatically relayout the page when new fonts are installed

Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (292283 => 292284)


--- trunk/Tools/DumpRenderTree/TestOptions.cpp	2022-04-04 08:03:30 UTC (rev 292283)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp	2022-04-04 08:37:53 UTC (rev 292284)
@@ -119,7 +119,6 @@
             { "LazyIframeLoadingEnabled", false },
             { "LazyImageLoadingEnabled", false },
             { "RequestIdleCallbackEnabled", false },
-            { "ResizeObserverEnabled", false },
             { "WebAuthenticationEnabled", false },
             { "WebGPUEnabled", false },
 #elif PLATFORM(WIN)
@@ -168,7 +167,6 @@
             { "PluginsEnabled", true },
             { "PrivateClickMeasurementEnabled", false },
             { "RequestIdleCallbackEnabled", false },
-            { "ResizeObserverEnabled", false },
             { "SelectionAcrossShadowBoundariesEnabled", true },
             { "ShrinksStandaloneImagesToFit", true },
             { "SpatialNavigationEnabled", false },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to