Log Message
[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac. https://bugs.webkit.org/show_bug.cgi?id=78246
This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/), and helps with the component build on mac (InitWebCoreSystemInterface is not an exported function, and it shouldn't be). Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's called twice, so it's safe to land this change, and remove the calls in client code in a later CL. Reviewed by Darin Fisher. * src/WebKit.cpp: (WebKit::initializeWithoutV8):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (107617 => 107618)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-13 23:07:22 UTC (rev 107617)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-13 23:10:37 UTC (rev 107618)
@@ -1,3 +1,21 @@
+2012-02-13 Nico Weber <[email protected]>
+
+ [chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
+ https://bugs.webkit.org/show_bug.cgi?id=78246
+
+ This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/),
+ and helps with the component build on mac (InitWebCoreSystemInterface is not an
+ exported function, and it shouldn't be).
+
+ Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
+ called twice, so it's safe to land this change, and remove the calls in client
+ code in a later CL.
+
+ Reviewed by Darin Fisher.
+
+ * src/WebKit.cpp:
+ (WebKit::initializeWithoutV8):
+
2012-02-13 Yosifumi Inoue <[email protected]>
[Forms] Use enum instead of bool for HTMLInputElement::setValue
Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (107617 => 107618)
--- trunk/Source/WebKit/chromium/src/WebKit.cpp 2012-02-13 23:07:22 UTC (rev 107617)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp 2012-02-13 23:10:37 UTC (rev 107618)
@@ -45,6 +45,10 @@
#include "WorkerContextExecutionProxy.h"
#include "v8.h"
+#if OS(DARWIN)
+#include "WebSystemInterface.h"
+#endif
+
#include <wtf/Assertions.h>
#include <wtf/MainThread.h>
#include <wtf/Threading.h>
@@ -107,6 +111,10 @@
ASSERT(!s_webKitInitialized);
s_webKitInitialized = true;
+#if OS(DARWIN)
+ InitWebCoreSystemInterface();
+#endif
+
ASSERT(webKitPlatformSupport);
ASSERT(!s_webKitPlatformSupport);
s_webKitPlatformSupport = webKitPlatformSupport;
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
