Diff
Modified: trunk/Tools/ChangeLog (107619 => 107620)
--- trunk/Tools/ChangeLog 2012-02-13 23:13:14 UTC (rev 107619)
+++ trunk/Tools/ChangeLog 2012-02-13 23:17:29 UTC (rev 107620)
@@ -1,5 +1,26 @@
2012-02-13 Adam Barth <[email protected]>
+ Add a skeleton ChromiumAndroid port to webkitpy
+ https://bugs.webkit.org/show_bug.cgi?id=78543
+
+ Reviewed by Eric Seidel.
+
+ This patch just adds an empty ChromiumAndroid port object to webkitpy
+ and wires it up to the factory objects. An actual implementation will
+ follow.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+ (ChromiumPort):
+ * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
+ (ChromiumAndroidPort):
+ (ChromiumAndroidPort.__init__):
+ * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+ (ChromiumPortTest.test_all_test_configurations):
+ * Scripts/webkitpy/layout_tests/port/factory.py:
+ (PortFactory):
+
+2012-02-13 Adam Barth <[email protected]>
+
NRWT's HTTP servers should support additional directories for resources
https://bugs.webkit.org/show_bug.cgi?id=78528
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (107619 => 107620)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-02-13 23:13:14 UTC (rev 107619)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-02-13 23:17:29 UTC (rev 107620)
@@ -66,7 +66,8 @@
('vista', 'x86'),
('win7', 'x86'),
('lucid', 'x86'),
- ('lucid', 'x86_64'))
+ ('lucid', 'x86_64'),
+ ('icecreamsandwich', 'arm'))
ALL_GRAPHICS_TYPES = ('cpu', 'gpu')
@@ -81,6 +82,7 @@
'mac': ['leopard', 'snowleopard', 'lion'],
'win': ['xp', 'vista', 'win7'],
'linux': ['lucid'],
+ 'android': ['icecreamsandwich'],
}
@classmethod
Added: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (0 => 107620)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-02-13 23:17:29 UTC (rev 107620)
@@ -0,0 +1,36 @@
+# Copyright (C) 2012 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+from webkitpy.layout_tests.port import chromium
+
+
+class ChromiumAndroidPort(chromium.ChromiumPort):
+ port_name = 'chromium-android'
+
+ def __init__(self, host, port_name, **kwargs):
+ pass
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py (107619 => 107620)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py 2012-02-13 23:13:14 UTC (rev 107619)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py 2012-02-13 23:17:29 UTC (rev 107620)
@@ -161,6 +161,10 @@
"""Validate the complete set of configurations this port knows about."""
port = self.make_port()
self.assertEquals(set(port.all_test_configurations()), set([
+ TestConfiguration('icecreamsandwich', 'arm', 'debug', 'cpu'),
+ TestConfiguration('icecreamsandwich', 'arm', 'release', 'cpu'),
+ TestConfiguration('icecreamsandwich', 'arm', 'debug', 'gpu'),
+ TestConfiguration('icecreamsandwich', 'arm', 'release', 'gpu'),
TestConfiguration('leopard', 'x86', 'debug', 'cpu'),
TestConfiguration('leopard', 'x86', 'debug', 'gpu'),
TestConfiguration('leopard', 'x86', 'release', 'cpu'),
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py (107619 => 107620)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py 2012-02-13 23:13:14 UTC (rev 107619)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py 2012-02-13 23:17:29 UTC (rev 107620)
@@ -42,6 +42,7 @@
class PortFactory(object):
PORT_CLASSES = (
+ 'chromium_android.ChromiumAndroidPort',
'chromium_gpu.ChromiumGpuLinuxPort',
'chromium_gpu.ChromiumGpuMacPort',
'chromium_gpu.ChromiumGpuWinPort',
@@ -59,7 +60,7 @@
'qt.QtPort',
'test.TestPort',
'win.WinPort',
- )
+ )
def __init__(self, host):
self._host = host
