Title: [292562] trunk/LayoutTests
- Revision
- 292562
- Author
- za...@apple.com
- Date
- 2022-04-07 13:36:29 -0700 (Thu, 07 Apr 2022)
Log Message
Unreviewed test gardening.
* imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html:
.html is rendered using the legacy codepath while -expected.html is renderer using the modern codepath.
In case of fractional pixel values, they sometimes produce different final baselines due to (unintentional) implicit flooring in legacy line layout.
While most of these intentional/unintentional floors/ceils are matched (with FIXMEs) in the modern line layout, some would make the line layout
codebase a lot more complicated. These type of bugs are mostly not visible to the user anyway ever since we have stopped swapping between modern
and legacy line layout dynamically (e.g. on selection).
* imported/blink/fast/multicol/vertical-lr/float-content-break.html:
* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (292561 => 292562)
--- trunk/LayoutTests/ChangeLog 2022-04-07 20:32:29 UTC (rev 292561)
+++ trunk/LayoutTests/ChangeLog 2022-04-07 20:36:29 UTC (rev 292562)
@@ -1,3 +1,17 @@
+2022-04-07 Alan Bujtas <za...@apple.com>
+
+ Unreviewed test gardening.
+
+ * imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html:
+ .html is rendered using the legacy codepath while -expected.html is renderer using the modern codepath.
+ In case of fractional pixel values, they sometimes produce different final baselines due to (unintentional) implicit flooring in legacy line layout.
+ While most of these intentional/unintentional floors/ceils are matched (with FIXMEs) in the modern line layout, some would make the line layout
+ codebase a lot more complicated. These type of bugs are mostly not visible to the user anyway ever since we have stopped swapping between modern
+ and legacy line layout dynamically (e.g. on selection).
+ * imported/blink/fast/multicol/vertical-lr/float-content-break.html:
+ * platform/ios-wk2/TestExpectations:
+ * platform/ios/TestExpectations:
+
2022-04-07 Tim Nguyen <n...@apple.com>
[CSS resize property] Correct minimum size computation to allow resizing below initial size
Modified: trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html (292561 => 292562)
--- trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html 2022-04-07 20:32:29 UTC (rev 292561)
+++ trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html 2022-04-07 20:36:29 UTC (rev 292562)
@@ -2,6 +2,7 @@
<style>
body {
-webkit-writing-mode: vertical-lr;
+ font-size: 15px;
}
.multicol {
height: 330px;
Modified: trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break.html (292561 => 292562)
--- trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break.html 2022-04-07 20:32:29 UTC (rev 292561)
+++ trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break.html 2022-04-07 20:36:29 UTC (rev 292562)
@@ -2,6 +2,7 @@
<style>
body {
-webkit-writing-mode: vertical-lr;
+ font-size: 15px;
}
.multicol {
height: 330px;
Modified: trunk/LayoutTests/platform/ios/TestExpectations (292561 => 292562)
--- trunk/LayoutTests/platform/ios/TestExpectations 2022-04-07 20:32:29 UTC (rev 292561)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2022-04-07 20:36:29 UTC (rev 292562)
@@ -2181,7 +2181,6 @@
#1px inline geometry floor/ceil differences
imported/blink/fast/multicol/vertical-lr/float-big-line.html [ ImageOnlyFailure ]
imported/blink/fast/multicol/vertical-lr/float-break.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/vertical-lr/float-content-break.html [ ImageOnlyFailure ]
imported/blink/fast/multicol/vertical-lr/float-edge.html [ ImageOnlyFailure ]
imported/blink/fast/pagination/div-x-vertical-lr-ltr.html [ ImageOnlyFailure ]
imported/blink/fast/pagination/div-x-vertical-lr-rtl.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (292561 => 292562)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 20:32:29 UTC (rev 292561)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 20:36:29 UTC (rev 292562)
@@ -2208,9 +2208,6 @@
# Test failures from turning GPU Process on by default
webkit.org/b/234536 webxr/high-performance.html [ Failure ]
-# Wrong text color
-webkit.org/b/236913 imported/blink/fast/multicol/vertical-lr/float-content-break.html [ ImageOnlyFailure ]
-
# Media failures
webkit.org/b/237295 fast/mediastream/video-rotation-gpu-process-crash.html [ Timeout Crash Pass ]
webkit.org/b/236926 webrtc/vp8-then-h264-gpu-process-crash.html [ Timeout Pass ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
