Title: [292609] trunk/Source
- Revision
- 292609
- Author
- [email protected]
- Date
- 2022-04-08 09:41:05 -0700 (Fri, 08 Apr 2022)
Log Message
Broaden TypedArray API fix to all apps not just Bleacher Report
https://bugs.webkit.org/show_bug.cgi?id=238955
Reviewed by Saam Barati.
Source/_javascript_Core:
* API/JSTypedArray.cpp:
(isLinkedBeforeTypedArrayLengthQuirk):
(JSObjectGetArrayBufferByteLength):
(isBleecherReport): Deleted.
Source/WTF:
* wtf/cocoa/RuntimeApplicationChecksCocoa.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSTypedArray.cpp (292608 => 292609)
--- trunk/Source/_javascript_Core/API/JSTypedArray.cpp 2022-04-08 15:16:59 UTC (rev 292608)
+++ trunk/Source/_javascript_Core/API/JSTypedArray.cpp 2022-04-08 16:41:05 UTC (rev 292609)
@@ -366,15 +366,12 @@
}
#if PLATFORM(IOS)
-inline static bool isBleecherReport()
+inline static bool isLinkedBeforeTypedArrayLengthQuirk()
{
- auto bundleID = CFBundleGetIdentifier(CFBundleGetMainBundle());
- return bundleID
- && CFEqual(bundleID, CFSTR("com.bleacherreport.TeamStream"))
- && !linkedOnOrAfter(SDKVersion::FirstWithoutBleecherReportQuirk);
+ return !linkedOnOrAfter(SDKVersion::FirstWithoutTypedArrayAPIQuirk);
}
#else
-inline static bool isBleecherReport() { return false; }
+inline static bool isLinkedBeforeTypedArrayLengthQuirk() { return false; }
#endif
size_t JSObjectGetArrayBufferByteLength(JSContextRef ctx, JSObjectRef objectRef, JSValueRef*)
@@ -386,7 +383,7 @@
if (!object) {
// For some reason prior to https://bugs.webkit.org/show_bug.cgi?id=235720 Clang would emit code
// to early return if objectRef is 0 but not after. Passing 0 should be invalid API use.
- static bool shouldntCrash = isBleecherReport();
+ static bool shouldntCrash = isLinkedBeforeTypedArrayLengthQuirk();
RELEASE_ASSERT(shouldntCrash);
return 0;
}
Modified: trunk/Source/_javascript_Core/ChangeLog (292608 => 292609)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-08 15:16:59 UTC (rev 292608)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-08 16:41:05 UTC (rev 292609)
@@ -1,3 +1,15 @@
+2022-04-08 Keith Miller <[email protected]>
+
+ Broaden TypedArray API fix to all apps not just Bleacher Report
+ https://bugs.webkit.org/show_bug.cgi?id=238955
+
+ Reviewed by Saam Barati.
+
+ * API/JSTypedArray.cpp:
+ (isLinkedBeforeTypedArrayLengthQuirk):
+ (JSObjectGetArrayBufferByteLength):
+ (isBleecherReport): Deleted.
+
2022-04-07 Yusuke Suzuki <[email protected]>
[JSC] Fire structure transition watchpoint in Structure::finishCreation instead of Structure constructor
Modified: trunk/Source/WTF/ChangeLog (292608 => 292609)
--- trunk/Source/WTF/ChangeLog 2022-04-08 15:16:59 UTC (rev 292608)
+++ trunk/Source/WTF/ChangeLog 2022-04-08 16:41:05 UTC (rev 292609)
@@ -1,3 +1,12 @@
+2022-04-08 Keith Miller <[email protected]>
+
+ Broaden TypedArray API fix to all apps not just Bleacher Report
+ https://bugs.webkit.org/show_bug.cgi?id=238955
+
+ Reviewed by Saam Barati.
+
+ * wtf/cocoa/RuntimeApplicationChecksCocoa.h:
+
2022-04-07 Elliott Williams <[email protected]>
[XCBuild] Enable dependency validation by default
Modified: trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h (292608 => 292609)
--- trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h 2022-04-08 15:16:59 UTC (rev 292608)
+++ trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h 2022-04-08 16:41:05 UTC (rev 292609)
@@ -86,7 +86,7 @@
FirstWithoutExpandoIndexedPropertiesOnWindow = DYLD_IOS_VERSION_15_0,
FirstThatDoesNotDrainTheMicrotaskQueueWhenCallingObjC = DYLD_IOS_VERSION_15_0,
FirstWithAuthorizationHeaderOnSameOriginRedirects = DYLD_IOS_VERSION_15_4,
- FirstWithoutBleecherReportQuirk = DYLD_IOS_VERSION_16_0,
+ FirstWithoutTypedArrayAPIQuirk = DYLD_IOS_VERSION_16_0,
FirstForbiddingDotPrefixedFonts = DYLD_IOS_VERSION_16_0,
#elif PLATFORM(MAC)
FirstVersionThatSupportsInitConstructors = 0xA0A00, // OS X 10.10
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
