Diff
Modified: trunk/Source/WebKit/ChangeLog (292623 => 292624)
--- trunk/Source/WebKit/ChangeLog 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/ChangeLog 2022-04-08 17:58:58 UTC (rev 292624)
@@ -1,3 +1,36 @@
+2022-04-08 Gavin Phillips <[email protected]>
+
+ Remove misc unused CoreIPC messages/handlers that have no instances of messages being dispatched to them
+ https://bugs.webkit.org/show_bug.cgi?id=238996
+
+ Reviewed by Chris Dumez.
+
+ Remove misc unused CoreIPC messages/handlers that have no instances of messages being dispatched to them. This includes:
+ WebPage::FrameBecameRemote, WebInspectorUIProxy::BringInspectedPageToFront, WebProcess::refreshPlugins, NetworkProcess::SetQOS
+ WebPage::GetPositionInformation, WebPage::InvalidateMediaSessionCoordinator, RemoteCDMInstanceSessionProxy::DisplayIDChanged.
+
+ * GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
+ (WebKit::RemoteCDMInstanceSessionProxy::displayIDChanged): Deleted.
+ * GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
+ * GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:
+ * NetworkProcess/NetworkProcess.messages.in:
+ * UIProcess/Inspector/WebInspectorUIProxy.cpp:
+ (WebKit::WebInspectorUIProxy::bringInspectedPageToFront): Deleted.
+ * UIProcess/Inspector/WebInspectorUIProxy.messages.in:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::createMediaSessionCoordinator):
+ (WebKit::WebPage::frameBecameRemote): Deleted.
+ (WebKit::WebPage::invalidateMediaSessionCoordinator): Deleted.
+ * WebProcess/WebPage/WebPage.h:
+ * WebProcess/WebPage/WebPage.messages.in:
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::isObscuredElement):
+ (WebKit::WebPage::getPositionInformation): Deleted.
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::refreshPlugins): Deleted.
+ * WebProcess/WebProcess.h:
+ * WebProcess/WebProcess.messages.in:
+
2022-04-08 Simon Fraser <[email protected]>
Have GPU Process call lowMemoryHandler() on each RemoteRenderingBackend
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp (292623 => 292624)
--- trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp 2022-04-08 17:58:58 UTC (rev 292624)
@@ -137,11 +137,6 @@
m_session->storeRecordOfKeyUsage(sessionId);
}
-void RemoteCDMInstanceSessionProxy::displayIDChanged(PlatformDisplayID displayID)
-{
- m_session->displayChanged(displayID);
-}
-
void RemoteCDMInstanceSessionProxy::updateKeyStatuses(KeyStatusVector&& keyStatuses)
{
if (!m_cdm)
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.h (292623 => 292624)
--- trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.h 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.h 2022-04-08 17:58:58 UTC (rev 292624)
@@ -74,7 +74,6 @@
void closeSession(const String& sessionId, CloseSessionCallback&&);
void removeSessionData(const String& sessionId, LicenseType, RemoveSessionDataCallback&&);
void storeRecordOfKeyUsage(const String& sessionId);
- void displayIDChanged(PlatformDisplayID);
// CDMInstanceSessionClient
void updateKeyStatuses(KeyStatusVector&&) final;
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in (292623 => 292624)
--- trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in 2022-04-08 17:58:58 UTC (rev 292624)
@@ -33,7 +33,6 @@
CloseSession(String sessionId) -> ()
RemoveSessionData(String sessionId, WebCore::CDMInstanceSession::LicenseType type) -> (WebCore::CDMInstanceSession::KeyStatusVector changedKeys, std::optional<IPC::SharedBufferCopy> message, bool succeeded)
StoreRecordOfKeyUsage(String sessionId)
- DisplayIDChanged(uint32_t displayID)
}
#endif
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in (292623 => 292624)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2022-04-08 17:58:58 UTC (rev 292624)
@@ -61,9 +61,6 @@
ContinueWillSendRequest(WebKit::DownloadID downloadID, WebCore::ResourceRequest request)
-#if PLATFORM(COCOA)
- SetQOS(int latencyQOS, int throughputQOS)
-#endif
SetAllowsAnySSLCertificateForWebSocket(bool enabled) -> () Synchronous
FlushCookies(PAL::SessionID sessionID) -> ()
Modified: trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp (292623 => 292624)
--- trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp 2022-04-08 17:58:58 UTC (rev 292624)
@@ -609,11 +609,6 @@
open();
}
-void WebInspectorUIProxy::bringInspectedPageToFront()
-{
- platformBringInspectedPageToFront();
-}
-
void WebInspectorUIProxy::attachAvailabilityChanged(bool available)
{
bool previousCanAttach = m_canAttach;
Modified: trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in (292623 => 292624)
--- trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in 2022-04-08 17:58:58 UTC (rev 292624)
@@ -29,7 +29,6 @@
FrontendLoaded()
DidClose()
BringToFront()
- BringInspectedPageToFront()
Reopen()
ResetState()
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (292623 => 292624)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-04-08 17:58:58 UTC (rev 292624)
@@ -7307,37 +7307,6 @@
suspendForProcessSwap();
}
-void WebPage::frameBecameRemote(FrameIdentifier frameID, GlobalFrameIdentifier&& remoteFrameIdentifier, GlobalWindowIdentifier&& remoteWindowIdentifier)
-{
- RefPtr<WebFrame> frame = WebProcess::singleton().webFrame(frameID);
- if (!frame)
- return;
-
- if (frame->page() != this)
- return;
-
- auto* coreFrame = frame->coreFrame();
- auto* previousWindow = coreFrame->window();
- if (!previousWindow)
- return;
-
- auto remoteFrame = RemoteFrame::create(WTFMove(remoteFrameIdentifier));
- auto remoteWindow = RemoteDOMWindow::create(remoteFrame.copyRef(), WTFMove(remoteWindowIdentifier));
-
- remoteFrame->setOpener(frame->coreFrame()->loader().opener());
-
- auto jsWindowProxies = frame->coreFrame()->windowProxy().releaseJSWindowProxies();
- remoteFrame->windowProxy().setJSWindowProxies(WTFMove(jsWindowProxies));
- remoteFrame->windowProxy().setDOMWindow(remoteWindow.ptr());
-
- coreFrame->setView(nullptr);
- coreFrame->willDetachPage();
- coreFrame->detachFromPage();
-
- if (frame->isMainFrame())
- close();
-}
-
#if ENABLE(INTELLIGENT_TRACKING_PREVENTION)
void WebPage::hasStorageAccess(RegistrableDomain&& subFrameDomain, RegistrableDomain&& topFrameDomain, WebFrame& frame, CompletionHandler<void(bool)>&& completionHandler)
{
@@ -8097,11 +8066,6 @@
m_page->setMediaSessionCoordinator(RemoteMediaSessionCoordinator::create(*this, identifier));
completionHandler(true);
}
-
-void WebPage::invalidateMediaSessionCoordinator()
-{
- m_page->invalidateMediaSessionCoordinator();
-}
#endif
#if !PLATFORM(COCOA)
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (292623 => 292624)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2022-04-08 17:58:58 UTC (rev 292624)
@@ -816,7 +816,6 @@
void syncApplyAutocorrection(const String& correction, const String& originalText, CompletionHandler<void(bool)>&&);
void handleAutocorrectionContextRequest();
void preemptivelySendAutocorrectionContext();
- void getPositionInformation(const InteractionInformationRequest&, CompletionHandler<void(InteractionInformationAtPosition&&)>&&);
void requestPositionInformation(const InteractionInformationRequest&);
void startInteractionWithElementContextOrPosition(std::optional<WebCore::ElementContext>&&, WebCore::IntPoint&&);
void stopInteraction();
@@ -1506,7 +1505,6 @@
#if ENABLE(MEDIA_SESSION_COORDINATOR)
void createMediaSessionCoordinator(const String&, CompletionHandler<void(bool)>&&);
- void invalidateMediaSessionCoordinator();
#endif
void setLastNavigationWasAppInitiated(bool wasAppBound) { m_lastNavigationWasAppInitiated = wasAppBound; }
@@ -1943,8 +1941,6 @@
void voicesDidChange();
#endif
- void frameBecameRemote(WebCore::FrameIdentifier, WebCore::GlobalFrameIdentifier&& remoteFrameIdentifier, WebCore::GlobalWindowIdentifier&& remoteWindowIdentifier);
-
void registerURLSchemeHandler(WebURLSchemeHandlerIdentifier, const String& scheme);
void urlSchemeTaskWillPerformRedirection(WebURLSchemeHandlerIdentifier, WebCore::ResourceLoaderIdentifier taskIdentifier, WebCore::ResourceResponse&&, WebCore::ResourceRequest&&, CompletionHandler<void(WebCore::ResourceRequest&&)>&&);
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in (292623 => 292624)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2022-04-08 17:58:58 UTC (rev 292624)
@@ -90,7 +90,6 @@
SyncApplyAutocorrection(String correction, String originalText) -> (bool autocorrectionApplied) Synchronous
HandleAutocorrectionContextRequest()
RequestEvasionRectsAboveSelection() -> (Vector<WebCore::FloatRect> rects)
- GetPositionInformation(struct WebKit::InteractionInformationRequest request) -> (struct WebKit::InteractionInformationAtPosition information) Synchronous
RequestPositionInformation(struct WebKit::InteractionInformationRequest request)
StartInteractionWithElementContextOrPosition(std::optional<WebCore::ElementContext> elementContext, WebCore::IntPoint point)
StopInteraction()
@@ -588,8 +587,6 @@
GamepadActivity(Vector<WebKit::GamepadData> gamepadDatas, enum:bool WebCore::EventMakesGamepadsVisible eventVisibility)
#endif
- FrameBecameRemote(WebCore::FrameIdentifier frameID, struct WebCore::GlobalFrameIdentifier remoteFrameIdentifier, struct WebCore::GlobalWindowIdentifier remoteWindowIdentifier)
-
RegisterURLSchemeHandler(WebKit::WebURLSchemeHandlerIdentifier handlerIdentifier, String scheme)
URLSchemeTaskWillPerformRedirection(WebKit::WebURLSchemeHandlerIdentifier handlerIdentifier, WebCore::ResourceLoaderIdentifier taskIdentifier, WebCore::ResourceResponse response, WebCore::ResourceRequest proposedRequest) -> (WebCore::ResourceRequest actualRequest)
@@ -672,7 +669,6 @@
#if ENABLE(MEDIA_SESSION_COORDINATOR)
CreateMediaSessionCoordinator(String identifier) -> (bool success)
- InvalidateMediaSessionCoordinator()
#endif
#if ENABLE(IMAGE_ANALYSIS)
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (292623 => 292624)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-04-08 17:58:58 UTC (rev 292624)
@@ -2695,24 +2695,6 @@
return true;
}
-
-void WebPage::getPositionInformation(const InteractionInformationRequest& request, CompletionHandler<void(InteractionInformationAtPosition&&)>&& reply)
-{
- // Avoid UIProcess hangs when the WebContent process is stuck on a sync IPC.
- if (IPC::UnboundedSynchronousIPCScope::hasOngoingUnboundedSyncIPC()) {
- WEBPAGE_RELEASE_LOG_ERROR(Process, "getPositionInformation - Not processing because the process is stuck on unbounded sync IPC");
- return reply({ });
- }
-
- sendEditorStateUpdate();
-
- m_pendingSynchronousPositionInformationReply = WTFMove(reply);
-
- auto information = positionInformation(request);
-
- if (auto reply = WTFMove(m_pendingSynchronousPositionInformationReply))
- reply(WTFMove(information));
-}
static void focusedElementPositionInformation(WebPage& page, Element& focusedElement, const InteractionInformationRequest& request, InteractionInformationAtPosition& info)
{
Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (292623 => 292624)
--- trunk/Source/WebKit/WebProcess/WebProcess.cpp 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp 2022-04-08 17:58:58 UTC (rev 292624)
@@ -1029,10 +1029,6 @@
completionHandler(JSC::Options::useJIT());
}
-void WebProcess::refreshPlugins()
-{
-}
-
void WebProcess::garbageCollectJavaScriptObjects()
{
GCController::singleton().garbageCollectNow();
Modified: trunk/Source/WebKit/WebProcess/WebProcess.h (292623 => 292624)
--- trunk/Source/WebKit/WebProcess/WebProcess.h 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/WebProcess/WebProcess.h 2022-04-08 17:58:58 UTC (rev 292624)
@@ -209,8 +209,6 @@
const WTF::MachSendRight& compositingRenderServerPort() const { return m_compositingRenderServerPort; }
#endif
- void refreshPlugins();
-
bool fullKeyboardAccessEnabled() const { return m_fullKeyboardAccessEnabled; }
#if HAVE(MOUSE_DEVICE_OBSERVATION)
Modified: trunk/Source/WebKit/WebProcess/WebProcess.messages.in (292623 => 292624)
--- trunk/Source/WebKit/WebProcess/WebProcess.messages.in 2022-04-08 17:58:32 UTC (rev 292623)
+++ trunk/Source/WebKit/WebProcess/WebProcess.messages.in 2022-04-08 17:58:58 UTC (rev 292624)
@@ -58,8 +58,6 @@
SetHasStylusDevice(bool hasStylusDevice)
#endif
- RefreshPlugins()
-
void StartMemorySampler(WebKit::SandboxExtension::Handle sampleLogFileHandle, String sampleLogFilePath, double interval);
void StopMemorySampler();
