Title: [292681] trunk
- Revision
- 292681
- Author
- mmaxfi...@apple.com
- Date
- 2022-04-09 13:26:16 -0700 (Sat, 09 Apr 2022)
Log Message
[WKTR] Reset minimum font size WKPreference between tests
https://bugs.webkit.org/show_bug.cgi?id=239027
<rdar://problem/88938768>
Reviewed by Chris Dumez.
Tools:
Some tests use uiController to set the minimum font size WKPreference. We need to reset it between tests.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
LayoutTests:
Remove unnecessary ephemeral session.
* fast/forms/visual-hebrew-text-field.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (292680 => 292681)
--- trunk/LayoutTests/ChangeLog 2022-04-09 19:05:27 UTC (rev 292680)
+++ trunk/LayoutTests/ChangeLog 2022-04-09 20:26:16 UTC (rev 292681)
@@ -1,3 +1,15 @@
+2022-04-09 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ [WKTR] Reset minimum font size WKPreference between tests
+ https://bugs.webkit.org/show_bug.cgi?id=239027
+ <rdar://problem/88938768>
+
+ Reviewed by Chris Dumez.
+
+ Remove unnecessary ephemeral session.
+
+ * fast/forms/visual-hebrew-text-field.html:
+
2022-04-09 Alan Bujtas <za...@apple.com>
REGRESSION (Safari 15.4): Focused element doesn't render outline when it has an underline
Modified: trunk/LayoutTests/fast/forms/visual-hebrew-text-field.html (292680 => 292681)
--- trunk/LayoutTests/fast/forms/visual-hebrew-text-field.html 2022-04-09 19:05:27 UTC (rev 292680)
+++ trunk/LayoutTests/fast/forms/visual-hebrew-text-field.html 2022-04-09 20:26:16 UTC (rev 292681)
@@ -1,5 +1,4 @@
-<html><!-- webkit-test-runner [ useEphemeralSession=true ] -->
-<!-- FIXME: We shouldn't have to use ephemeral session but the test fails without it for now. See webkit.org/b/236325 -->
+<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-8">
<title>-khtml-rtl-ordering</title>
Modified: trunk/Tools/ChangeLog (292680 => 292681)
--- trunk/Tools/ChangeLog 2022-04-09 19:05:27 UTC (rev 292680)
+++ trunk/Tools/ChangeLog 2022-04-09 20:26:16 UTC (rev 292681)
@@ -1,3 +1,16 @@
+2022-04-09 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ [WKTR] Reset minimum font size WKPreference between tests
+ https://bugs.webkit.org/show_bug.cgi?id=239027
+ <rdar://problem/88938768>
+
+ Reviewed by Chris Dumez.
+
+ Some tests use uiController to set the minimum font size WKPreference. We need to reset it between tests.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+
2022-04-09 Chris Dumez <cdu...@apple.com>
The Youtube plugin replacement should only work for actual Youtube URLs
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (292680 => 292681)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2022-04-09 19:05:27 UTC (rev 292680)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2022-04-09 20:26:16 UTC (rev 292681)
@@ -977,6 +977,7 @@
WKPreferencesSetProcessSwapOnNavigationEnabled(preferences, options.shouldEnableProcessSwapOnNavigation());
WKPreferencesSetStorageBlockingPolicy(preferences, kWKAllowAllStorage); // FIXME: We should be testing the default.
+ WKPreferencesSetMinimumFontSize(preferences, 0);
for (const auto& [key, value] : options.boolWebPreferenceFeatures())
WKPreferencesSetBoolValueForKeyForTesting(preferences, value, toWK(key).get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
