Title: [292731] trunk/Tools
- Revision
- 292731
- Author
- [email protected]
- Date
- 2022-04-11 15:56:48 -0700 (Mon, 11 Apr 2022)
Log Message
webkitpy.w3c.test_exporter assumes all exceptions are HTTPError
https://bugs.webkit.org/show_bug.cgi?id=238737
Reviewed by Jonathan Bedard.
This currently isn't at all easy to test, as our existing mocks for much
of this don't make it easy to throw arbitrary exceptions from given
functions.
* Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter.create_wpt_pull_request):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (292730 => 292731)
--- trunk/Tools/ChangeLog 2022-04-11 22:48:26 UTC (rev 292730)
+++ trunk/Tools/ChangeLog 2022-04-11 22:56:48 UTC (rev 292731)
@@ -1,3 +1,17 @@
+2022-04-11 Sam Sneddon <[email protected]>
+
+ webkitpy.w3c.test_exporter assumes all exceptions are HTTPError
+ https://bugs.webkit.org/show_bug.cgi?id=238737
+
+ Reviewed by Jonathan Bedard.
+
+ This currently isn't at all easy to test, as our existing mocks for much
+ of this don't make it easy to throw arbitrary exceptions from given
+ functions.
+
+ * Scripts/webkitpy/w3c/test_exporter.py:
+ (WebPlatformTestExporter.create_wpt_pull_request):
+
2022-04-11 Sihui Liu <[email protected]>
Fix size computation in WebCore::StorageMap
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py (292730 => 292731)
--- trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py 2022-04-11 22:48:26 UTC (rev 292730)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py 2022-04-11 22:56:48 UTC (rev 292731)
@@ -348,12 +348,15 @@
pr_number = None
try:
pr_number = self._github.create_pr(remote_branch_name, title, body)
- except Exception as e:
+ except HTTPError as e:
if e.code == 422:
_log.info('Unable to create a new pull request for branch "%s" because a pull request already exists. The branch has been updated and there is no further action needed.' % (remote_branch_name))
else:
_log.warning(e)
_log.info('Error creating a pull request on github. Please ensure that the provided github token has the "public_repo" scope.')
+ except Exception as e:
+ _log.warning(e)
+ _log.info('Error creating a pull request on github. Please ensure that the provided github token has the "public_repo" scope.')
return pr_number
def delete_local_branch(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
