Title: [292771] trunk/Source/WebKit
- Revision
- 292771
- Author
- [email protected]
- Date
- 2022-04-12 08:28:56 -0700 (Tue, 12 Apr 2022)
Log Message
Add logging in case WebsiteDataStore is not found for persistent notification events
https://bugs.webkit.org/show_bug.cgi?id=239111
Reviewed by Chris Dumez.
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::dispatchDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (292770 => 292771)
--- trunk/Source/WebKit/ChangeLog 2022-04-12 14:48:54 UTC (rev 292770)
+++ trunk/Source/WebKit/ChangeLog 2022-04-12 15:28:56 UTC (rev 292771)
@@ -1,3 +1,14 @@
+2022-04-12 Youenn Fablet <[email protected]>
+
+ Add logging in case WebsiteDataStore is not found for persistent notification events
+ https://bugs.webkit.org/show_bug.cgi?id=239111
+
+ Reviewed by Chris Dumez.
+
+ * UIProcess/Notifications/WebNotificationManagerProxy.cpp:
+ (WebKit::dispatchDidClickNotification):
+ (WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
+
2022-04-12 Kimmo Kinnunen <[email protected]>
FunctionDispatcher should not be RefCounted
Modified: trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp (292770 => 292771)
--- trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp 2022-04-12 14:48:54 UTC (rev 292770)
+++ trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp 2022-04-12 15:28:56 UTC (rev 292771)
@@ -29,6 +29,7 @@
#include "APIArray.h"
#include "APINotificationProvider.h"
#include "APISecurityOrigin.h"
+#include "Logging.h"
#include "WebNotification.h"
#include "WebNotificationManagerMessages.h"
#include "WebPageProxy.h"
@@ -194,6 +195,8 @@
if (notification->isPersistentNotification()) {
if (auto* dataStore = WebsiteDataStore::existingDataStoreForSessionID(notification->sessionID()))
dataStore->networkProcess().processNotificationEvent(notification->data(), NotificationEventType::Click);
+ else
+ RELEASE_LOG_ERROR(Notifications, "WebsiteDataStore not found from sessionID %" PRIu64 ", dropping notification click", notification->sessionID().toUInt64());
return;
}
#endif
@@ -255,6 +258,8 @@
if (notification->isPersistentNotification()) {
if (auto* dataStore = WebsiteDataStore::existingDataStoreForSessionID(notification->sessionID()))
dataStore->networkProcess().processNotificationEvent(notification->data(), NotificationEventType::Close);
+ else
+ RELEASE_LOG_ERROR(Notifications, "WebsiteDataStore not found from sessionID %" PRIu64 ", dropping notification close", notification->sessionID().toUInt64());
return;
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
