Title: [292809] trunk/Tools
Revision
292809
Author
[email protected]
Date
2022-04-13 06:52:16 -0700 (Wed, 13 Apr 2022)

Log Message

[run-jsc-stress-tests] Minor robustness fix
https://bugs.webkit.org/show_bug.cgi?id=239280

Reviewed by Adrian Perez de Castro.

Occasionally (e.g. https://build.webkit.org/#/builders/31/builds/3282),
run-jsc-stress-tests will receive a partial line when recovering the
results because the remote has died. The original code was being too
defensive; we should simply ignore those lines and allow for a retry.

* Scripts/run-jsc-stress-tests:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (292808 => 292809)


--- trunk/Tools/ChangeLog	2022-04-13 13:39:38 UTC (rev 292808)
+++ trunk/Tools/ChangeLog	2022-04-13 13:52:16 UTC (rev 292809)
@@ -1,5 +1,19 @@
 2022-04-13  Angelos Oikonomopoulos  <[email protected]>
 
+        [run-jsc-stress-tests] Minor robustness fix
+        https://bugs.webkit.org/show_bug.cgi?id=239280
+
+        Reviewed by Adrian Perez de Castro.
+
+        Occasionally (e.g. https://build.webkit.org/#/builders/31/builds/3282),
+        run-jsc-stress-tests will receive a partial line when recovering the
+        results because the remote has died. The original code was being too
+        defensive; we should simply ignore those lines and allow for a retry.
+
+        * Scripts/run-jsc-stress-tests:
+
+2022-04-13  Angelos Oikonomopoulos  <[email protected]>
+
         [run-jsc-stress-tests] Use ServerAliveInterval in GNU parallel
         https://bugs.webkit.org/show_bug.cgi?id=239283
 

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (292808 => 292809)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2022-04-13 13:39:38 UTC (rev 292808)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2022-04-13 13:52:16 UTC (rev 292809)
@@ -2750,8 +2750,11 @@
 def processStatusLine(map, line)
     md = STATUS_RE.match(line)
     if md.nil?
-        $stderr.puts("Could not parse line `#{line}`")
-        exit(1)
+        # Malfromed lines can legitimately occur when the remote fails at an
+        # inopportune moment. Ignore those lines but print them out, so that we
+        # can easily diagnose actual issues with the remote output.
+        $stderr.puts("Ignoring malformed status line `#{line}`")
+        return
     end
     index = md[:index].to_i
     runId = md[:runId]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to