Title: [292865] trunk
- Revision
- 292865
- Author
- [email protected]
- Date
- 2022-04-14 07:35:08 -0700 (Thu, 14 Apr 2022)
Log Message
[GTK][WPE] Make the ENABLE_GPU_PROCESS CMake option depend on USE_ANGLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=239330
Reviewed by Adrian Perez de Castro.
For the GTK and WPE ports, the ENABLE_GPU_PROCESS CMake option should
depend on the USE_ANGLE_WEBGL option being enabled. There's no plans
to support 'direct' GL execution in that process, and the ANGLE usage
also implies (for these two ports) usage of generic buffer solutions
that are shareable across process boundaries, as is necessary for a
functioning GPUProcess implementation.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (292864 => 292865)
--- trunk/ChangeLog 2022-04-14 14:13:38 UTC (rev 292864)
+++ trunk/ChangeLog 2022-04-14 14:35:08 UTC (rev 292865)
@@ -1,3 +1,20 @@
+2022-04-14 Zan Dobersek <[email protected]>
+
+ [GTK][WPE] Make the ENABLE_GPU_PROCESS CMake option depend on USE_ANGLE_WEBGL
+ https://bugs.webkit.org/show_bug.cgi?id=239330
+
+ Reviewed by Adrian Perez de Castro.
+
+ For the GTK and WPE ports, the ENABLE_GPU_PROCESS CMake option should
+ depend on the USE_ANGLE_WEBGL option being enabled. There's no plans
+ to support 'direct' GL execution in that process, and the ANGLE usage
+ also implies (for these two ports) usage of generic buffer solutions
+ that are shareable across process boundaries, as is necessary for a
+ functioning GPUProcess implementation.
+
+ * Source/cmake/OptionsGTK.cmake:
+ * Source/cmake/OptionsWPE.cmake:
+
2022-04-13 Elliott Williams <[email protected]>
[Xcode] Fix public watchOS workspace build by updating scheme and build settings
Modified: trunk/Source/cmake/OptionsGTK.cmake (292864 => 292865)
--- trunk/Source/cmake/OptionsGTK.cmake 2022-04-14 14:13:38 UTC (rev 292864)
+++ trunk/Source/cmake/OptionsGTK.cmake 2022-04-14 14:35:08 UTC (rev 292865)
@@ -83,6 +83,7 @@
WEBKIT_OPTION_DEPEND(ENABLE_WEBGL USE_OPENGL_OR_ES)
WEBKIT_OPTION_DEPEND(USE_ANGLE_WEBGL ENABLE_WEBGL)
WEBKIT_OPTION_DEPEND(ENABLE_WEBGL2 USE_ANGLE_WEBGL)
+WEBKIT_OPTION_DEPEND(ENABLE_GPU_PROCESS USE_ANGLE_WEBGL)
WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL USE_OPENGL_OR_ES)
WEBKIT_OPTION_DEPEND(USE_WPE_RENDERER USE_OPENGL_OR_ES)
WEBKIT_OPTION_DEPEND(USE_WPE_RENDERER ENABLE_WAYLAND_TARGET)
Modified: trunk/Source/cmake/OptionsWPE.cmake (292864 => 292865)
--- trunk/Source/cmake/OptionsWPE.cmake 2022-04-14 14:13:38 UTC (rev 292864)
+++ trunk/Source/cmake/OptionsWPE.cmake 2022-04-14 14:35:08 UTC (rev 292865)
@@ -94,6 +94,7 @@
WEBKIT_OPTION_DEFINE(USE_EXTERNAL_HOLEPUNCH "Whether to enable external holepunch" PRIVATE OFF)
WEBKIT_OPTION_DEPEND(USE_ANGLE_WEBGL ENABLE_WEBGL)
WEBKIT_OPTION_DEPEND(ENABLE_WEBGL2 USE_ANGLE_WEBGL)
+WEBKIT_OPTION_DEPEND(ENABLE_GPU_PROCESS USE_ANGLE_WEBGL)
if (CMAKE_SYSTEM_NAME MATCHES "Linux")
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BUBBLEWRAP_SANDBOX PUBLIC ON)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
