Title: [292872] trunk/Source/WebCore
- Revision
- 292872
- Author
- [email protected]
- Date
- 2022-04-14 09:23:56 -0700 (Thu, 14 Apr 2022)
Log Message
Add logging for persistent notification event handler failure
https://bugs.webkit.org/show_bug.cgi?id=239131
Reviewed by Chris Dumez.
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::processNotificationEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (292871 => 292872)
--- trunk/Source/WebCore/ChangeLog 2022-04-14 16:05:12 UTC (rev 292871)
+++ trunk/Source/WebCore/ChangeLog 2022-04-14 16:23:56 UTC (rev 292872)
@@ -1,3 +1,13 @@
+2022-04-14 Youenn Fablet <[email protected]>
+
+ Add logging for persistent notification event handler failure
+ https://bugs.webkit.org/show_bug.cgi?id=239131
+
+ Reviewed by Chris Dumez.
+
+ * workers/service/server/SWServer.cpp:
+ (WebCore::SWServer::processNotificationEvent):
+
2022-04-14 Justin Michaud <[email protected]>
[PGO] We should be able to build WebKit to collect PGO profiles easily
Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (292871 => 292872)
--- trunk/Source/WebCore/workers/service/server/SWServer.cpp 2022-04-14 16:05:12 UTC (rev 292871)
+++ trunk/Source/WebCore/workers/service/server/SWServer.cpp 2022-04-14 16:23:56 UTC (rev 292872)
@@ -1393,7 +1393,8 @@
worker->decrementFunctionalEventCounter();
});
terminateWorkerTimer->startOneShot(weakThis && weakThis->m_isProcessTerminationDelayEnabled ? defaultTerminationDelay : defaultFunctionalEventDuration);
- connectionOrStatus.value()->fireNotificationEvent(serviceWorkerIdentifier, data, type, [terminateWorkerTimer = WTFMove(terminateWorkerTimer), worker = WTFMove(worker)](bool /* succeeded */) mutable {
+ connectionOrStatus.value()->fireNotificationEvent(serviceWorkerIdentifier, data, type, [terminateWorkerTimer = WTFMove(terminateWorkerTimer), worker = WTFMove(worker)](bool succeeded) mutable {
+ RELEASE_LOG_ERROR_IF(!succeeded, ServiceWorker, "Service Worker notification event handler did not succeed");
// FIXME: if succeeded is false, should we implement a default action like opening a new page?
if (terminateWorkerTimer->isActive()) {
worker->decrementFunctionalEventCounter();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
