- Revision
- 107662
- Author
- [email protected]
- Date
- 2012-02-13 20:03:49 -0800 (Mon, 13 Feb 2012)
Log Message
[GTK] Mutation Observers build is broken
https://bugs.webkit.org/show_bug.cgi?id=78433
Patch by ChangSeok Oh <[email protected]> on 2012-02-13
Reviewed by Martin Robinson.
Source/WebCore:
Added some files missed.
No new tests since no new feature.
* GNUmakefile.list.am:
Tools:
Enabled mutation observers as a default feature for GTK port, too.
* Scripts/build-webkit:
LayoutTests:
Removed fast/mutation, but added following 3 tests which are needed more time to pass.
GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
I opened a new bug to deal with it. http://webkit.org/b/78481
And also see http://webkit.org/b/78290
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html
Needed to enable FileSystem API at the same time.
fast/mutation/filesystem-callback-delivery.html
* platform/gtk/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (107661 => 107662)
--- trunk/LayoutTests/ChangeLog 2012-02-14 03:15:16 UTC (rev 107661)
+++ trunk/LayoutTests/ChangeLog 2012-02-14 04:03:49 UTC (rev 107662)
@@ -1,3 +1,23 @@
+2012-02-13 ChangSeok Oh <[email protected]>
+
+ [GTK] Mutation Observers build is broken
+ https://bugs.webkit.org/show_bug.cgi?id=78433
+
+ Reviewed by Martin Robinson.
+
+ Removed fast/mutation, but added following 3 tests which are needed more time to pass.
+
+ GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
+ I opened a new bug to deal with it. http://webkit.org/b/78481
+ And also see http://webkit.org/b/78290
+ fast/mutation/end-of-task-delivery.html
+ fast/mutation/inline-event-listener.html
+
+ Needed to enable FileSystem API at the same time.
+ fast/mutation/filesystem-callback-delivery.html
+
+ * platform/gtk/Skipped:
+
2012-02-13 Hayato Ito <[email protected]>
Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
Modified: trunk/LayoutTests/platform/gtk/Skipped (107661 => 107662)
--- trunk/LayoutTests/platform/gtk/Skipped 2012-02-14 03:15:16 UTC (rev 107661)
+++ trunk/LayoutTests/platform/gtk/Skipped 2012-02-14 04:03:49 UTC (rev 107662)
@@ -280,6 +280,7 @@
http/tests/websocket/tests/hybi/send-file-blob.html
http/tests/websocket/tests/hybi/send-file-blob-fail.html
http/tests/workers/terminate-during-sync-operation.html
+fast/mutation/filesystem-callback-delivery.html
# Requires WebP support.
fast/canvas/canvas-toDataURL-webp.html
@@ -1607,9 +1608,11 @@
# https://bugs.webkit.org/show_bug.cgi?id=78345
security/block-test.html
-# MutationObservers are not enabled. http://webkit.org/b/78433
-fast/mutation
-
# https://bugs.webkit.org/show_bug.cgi?id=78434
fast/dom/Window/window-custom-prototype.html
http/tests/security/cross-frame-access-object-getPrototypeOf.html
+
+# GTK port DRT doesn't support some API like scheduleAsynchronousKeyDown.
+# http://webkit.org/b/78481, http://webkit.org/b/78290
+fast/mutation/end-of-task-delivery.html
+fast/mutation/inline-event-listener.html
Modified: trunk/Source/WebCore/ChangeLog (107661 => 107662)
--- trunk/Source/WebCore/ChangeLog 2012-02-14 03:15:16 UTC (rev 107661)
+++ trunk/Source/WebCore/ChangeLog 2012-02-14 04:03:49 UTC (rev 107662)
@@ -1,3 +1,16 @@
+2012-02-13 ChangSeok Oh <[email protected]>
+
+ [GTK] Mutation Observers build is broken
+ https://bugs.webkit.org/show_bug.cgi?id=78433
+
+ Reviewed by Martin Robinson.
+
+ Added some files missed.
+
+ No new tests since no new feature.
+
+ * GNUmakefile.list.am:
+
2012-02-13 Hayato Ito <[email protected]>
Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
Modified: trunk/Source/WebCore/GNUmakefile.list.am (107661 => 107662)
--- trunk/Source/WebCore/GNUmakefile.list.am 2012-02-14 03:15:16 UTC (rev 107661)
+++ trunk/Source/WebCore/GNUmakefile.list.am 2012-02-14 04:03:49 UTC (rev 107662)
@@ -388,6 +388,8 @@
DerivedSources/WebCore/JSMessagePort.h \
DerivedSources/WebCore/JSMouseEvent.cpp \
DerivedSources/WebCore/JSMouseEvent.h \
+ DerivedSources/WebCore/JSMutationCallback.cpp \
+ DerivedSources/WebCore/JSMutationCallback.h \
DerivedSources/WebCore/JSMutationEvent.cpp \
DerivedSources/WebCore/JSMutationEvent.h \
DerivedSources/WebCore/JSMutationRecord.cpp \
@@ -587,6 +589,8 @@
DerivedSources/WebCore/JSWebKitCSSRegionRule.h \
DerivedSources/WebCore/JSWebKitCSSTransformValue.cpp \
DerivedSources/WebCore/JSWebKitCSSTransformValue.h \
+ DerivedSources/WebCore/JSWebKitMutationObserver.cpp \
+ DerivedSources/WebCore/JSWebKitMutationObserver.h \
DerivedSources/WebCore/JSWebKitNamedFlow.cpp \
DerivedSources/WebCore/JSWebKitNamedFlow.h \
DerivedSources/WebCore/JSWebKitPoint.cpp \
@@ -705,6 +709,7 @@
$(WebCore)/dom/MessageEvent.idl \
$(WebCore)/dom/MessagePort.idl \
$(WebCore)/dom/MouseEvent.idl \
+ $(WebCore)/dom/MutationCallback.idl \
$(WebCore)/dom/MutationEvent.idl \
$(WebCore)/dom/MutationRecord.idl \
$(WebCore)/dom/NamedNodeMap.idl \
@@ -729,6 +734,7 @@
$(WebCore)/dom/TreeWalker.idl \
$(WebCore)/dom/UIEvent.idl \
$(WebCore)/dom/WebKitAnimationEvent.idl \
+ $(WebCore)/dom/WebKitMutationObserver.idl \
$(WebCore)/dom/WebKitNamedFlow.idl \
$(WebCore)/dom/WebKitTransitionEvent.idl \
$(WebCore)/dom/WheelEvent.idl \
Modified: trunk/Tools/ChangeLog (107661 => 107662)
--- trunk/Tools/ChangeLog 2012-02-14 03:15:16 UTC (rev 107661)
+++ trunk/Tools/ChangeLog 2012-02-14 04:03:49 UTC (rev 107662)
@@ -1,3 +1,14 @@
+2012-02-13 ChangSeok Oh <[email protected]>
+
+ [GTK] Mutation Observers build is broken
+ https://bugs.webkit.org/show_bug.cgi?id=78433
+
+ Reviewed by Martin Robinson.
+
+ Enabled mutation observers as a default feature for GTK port, too.
+
+ * Scripts/build-webkit:
+
2012-02-13 Loïc Yhuel <[email protected]>
Allow to configure ENABLE_FTPDIR in build-webkit
Modified: trunk/Tools/Scripts/build-webkit (107661 => 107662)
--- trunk/Tools/Scripts/build-webkit 2012-02-14 03:15:16 UTC (rev 107661)
+++ trunk/Tools/Scripts/build-webkit 2012-02-14 04:03:49 UTC (rev 107662)
@@ -276,7 +276,7 @@
define => "ENABLE_MICRODATA", default => 0, value => \$microdataSupport },
{ option => "mutation-observers", desc => "Toggle DOM mutation observer support",
- define => "ENABLE_MUTATION_OBSERVERS", default => !isGtk(), value => \$mutationObserversSupport },
+ define => "ENABLE_MUTATION_OBSERVERS", default => 1, value => \$mutationObserversSupport },
{ option => "netscape-plugin", desc => "Netscape Plugin support",
define => "ENABLE_NETSCAPE_PLUGIN_API", default => !isEfl(), value => \$netscapePluginSupport },
