Title: [292956] trunk/Source/WebKit
- Revision
- 292956
- Author
- [email protected]
- Date
- 2022-04-18 09:30:48 -0700 (Mon, 18 Apr 2022)
Log Message
Unreviewed, fix the internal watchOS engineering build
In the case where `HAVE(UIKIT_WITH_MOUSE_SUPPORT)` is off, internal watchOS engineering builds fail due to
`shouldEnableAlternativeMouseGestureRecognizers` being unused. Fix this, and do some minor cleanup in this code
while we're here:
- Remove extra space before `_alternateMouseGestureRecognizer.get()`.
- Move * to the correct side for Objective-C instances.
- Fix a typo: "alternativeMouseRecgnizer" => "alternativeMouseRecognizer".
* UIProcess/ios/WKContentViewInteraction.mm:
(shouldEnableAlternativeMouseGestureRecognizers):
(-[WKContentView _configureMouseGestureRecognizer]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (292955 => 292956)
--- trunk/Source/WebKit/ChangeLog 2022-04-18 16:09:17 UTC (rev 292955)
+++ trunk/Source/WebKit/ChangeLog 2022-04-18 16:30:48 UTC (rev 292956)
@@ -1,5 +1,21 @@
2022-04-18 Wenson Hsieh <[email protected]>
+ Unreviewed, fix the internal watchOS engineering build
+
+ In the case where `HAVE(UIKIT_WITH_MOUSE_SUPPORT)` is off, internal watchOS engineering builds fail due to
+ `shouldEnableAlternativeMouseGestureRecognizers` being unused. Fix this, and do some minor cleanup in this code
+ while we're here:
+
+ - Remove extra space before `_alternateMouseGestureRecognizer.get()`.
+ - Move * to the correct side for Objective-C instances.
+ - Fix a typo: "alternativeMouseRecgnizer" => "alternativeMouseRecognizer".
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (shouldEnableAlternativeMouseGestureRecognizers):
+ (-[WKContentView _configureMouseGestureRecognizer]):
+
+2022-04-18 Wenson Hsieh <[email protected]>
+
Make the main video heuristic robust when video elements are added after entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=239438
rdar://91867187
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (292955 => 292956)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2022-04-18 16:09:17 UTC (rev 292955)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2022-04-18 16:30:48 UTC (rev 292956)
@@ -251,10 +251,10 @@
#if HAVE(UIKIT_WITH_MOUSE_SUPPORT)
-static bool shouldEnableAlternativeMouseGestureRecognizers(WKMouseGestureRecognizer* mouseRecognizer, WKMouseGestureRecognizer* alternativeMouseRecgnizer)
+static bool shouldEnableAlternativeMouseGestureRecognizers(WKMouseGestureRecognizer *mouseRecognizer, WKMouseGestureRecognizer *alternativeMouseRecognizer)
{
UNUSED_PARAM(mouseRecognizer);
- UNUSED_PARAM(alternativeMouseRecgnizer);
+ UNUSED_PARAM(alternativeMouseRecognizer);
return false;
}
@@ -10006,7 +10006,7 @@
- (void)_configureMouseGestureRecognizer
{
[_mouseGestureRecognizer setEnabled:[self shouldUseMouseGestureRecognizer]];
- if (shouldEnableAlternativeMouseGestureRecognizers(_mouseGestureRecognizer.get(), _alternateMouseGestureRecognizer.get()))
+ if (shouldEnableAlternativeMouseGestureRecognizers(_mouseGestureRecognizer.get(), _alternateMouseGestureRecognizer.get()))
[_alternateMouseGestureRecognizer setEnabled:[self shouldUseMouseGestureRecognizer]];
else
[_alternateMouseGestureRecognizer setEnabled:false];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
