Title: [292962] trunk
- Revision
- 292962
- Author
- commit-qu...@webkit.org
- Date
- 2022-04-18 11:46:45 -0700 (Mon, 18 Apr 2022)
Log Message
[PGO] Fix build on intel machines
https://bugs.webkit.org/show_bug.cgi?id=239396
Reviewed by Jonathan Bedard.
We should use the correct comparison operator for Perl strings when checking
if we are building with PGO profile generation enabled.
Canonical link: https://commits.webkit.org/249727@main
Modified Paths
Diff
Modified: trunk/ChangeLog (292961 => 292962)
--- trunk/ChangeLog 2022-04-18 18:30:14 UTC (rev 292961)
+++ trunk/ChangeLog 2022-04-18 18:46:45 UTC (rev 292962)
@@ -1,3 +1,13 @@
+2022-04-15 Justin Michaud <justin_mich...@apple.com>
+
+ [PGO] Fix build on intel machines
+ https://bugs.webkit.org/show_bug.cgi?id=239396
+
+ Reviewed by Jonathan Bedard.
+
+ We should use the correct comparison operator for Perl strings when checking
+ if we are building with PGO profile generation enabled.
+
2022-04-12 Jonathan Bedard <jbed...@apple.com>
[git-webkit] Allow projects to declare alternate remotes
Modified: trunk/Tools/ChangeLog (292961 => 292962)
--- trunk/Tools/ChangeLog 2022-04-18 18:30:14 UTC (rev 292961)
+++ trunk/Tools/ChangeLog 2022-04-18 18:46:45 UTC (rev 292962)
@@ -1,3 +1,15 @@
+2022-04-15 Justin Michaud <justin_mich...@apple.com>
+
+ [PGO] Fix build on intel machines
+ https://bugs.webkit.org/show_bug.cgi?id=239396
+
+ Reviewed by Jonathan Bedard.
+
+ We should use the correct comparison operator for Perl strings when checking
+ if we are building with PGO profile generation enabled.
+
+ * Scripts/check-for-weak-vtables-and-externals:
+
2022-04-18 Elliott Williams <e...@apple.com>
[XCBuild] Use XCBuild for all command-line and project builds
Modified: trunk/Tools/Scripts/check-for-weak-vtables-and-externals (292961 => 292962)
--- trunk/Tools/Scripts/check-for-weak-vtables-and-externals 2022-04-18 18:30:14 UTC (rev 292961)
+++ trunk/Tools/Scripts/check-for-weak-vtables-and-externals 2022-04-18 18:46:45 UTC (rev 292962)
@@ -60,7 +60,7 @@
}
my @weakVTableClasses = ();
my @weakExternalSymbols = ();
- my $skipProfileSymbols = coverageIsEnabled() || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} == "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} == "ENABLE_LLVM_PROFILE_GENERATION";
+ my $skipProfileSymbols = coverageIsEnabled() || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ENABLE_LLVM_PROFILE_GENERATION";
while (<NM>) {
if (/^STDOUT:/) {
# Ignore undefined, RTTI and typeinfo symbols.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes