Title: [292984] branches/safari-613-branch/Source/_javascript_Core
Revision
292984
Author
alanc...@apple.com
Date
2022-04-18 17:49:20 -0700 (Mon, 18 Apr 2022)

Log Message

Cherry-pick r292269. rdar://problem/91204413

    AI should do int32 optimization in ValueRep
    https://bugs.webkit.org/show_bug.cgi?id=238699

    Reviewed by Saam Barati.

    When constant folding an int52 into a ValueRep AI doesn't
    do our normal int32 boxing optimization. I'm not sure if
    it matters since I couldn't find a test but it probably
    doesn't hurt.

    * dfg/DFGAbstractInterpreterInlines.h:
    (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-613-branch/Source/_javascript_Core/ChangeLog (292983 => 292984)


--- branches/safari-613-branch/Source/_javascript_Core/ChangeLog	2022-04-19 00:49:17 UTC (rev 292983)
+++ branches/safari-613-branch/Source/_javascript_Core/ChangeLog	2022-04-19 00:49:20 UTC (rev 292984)
@@ -1,3 +1,38 @@
+2022-04-18  Kocsen Chung  <kocsen_ch...@apple.com>
+
+        Cherry-pick r292269. rdar://problem/91204413
+
+    AI should do int32 optimization in ValueRep
+    https://bugs.webkit.org/show_bug.cgi?id=238699
+    
+    Reviewed by Saam Barati.
+    
+    When constant folding an int52 into a ValueRep AI doesn't
+    do our normal int32 boxing optimization. I'm not sure if
+    it matters since I couldn't find a test but it probably
+    doesn't hurt.
+    
+    * dfg/DFGAbstractInterpreterInlines.h:
+    (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-04-02  Keith Miller  <keith_mil...@apple.com>
+
+            AI should do int32 optimization in ValueRep
+            https://bugs.webkit.org/show_bug.cgi?id=238699
+
+            Reviewed by Saam Barati.
+
+            When constant folding an int52 into a ValueRep AI doesn't
+            do our normal int32 boxing optimization. I'm not sure if
+            it matters since I couldn't find a test but it probably
+            doesn't hurt.
+
+            * dfg/DFGAbstractInterpreterInlines.h:
+            (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+
 2022-04-07  Alan Coon  <alanc...@apple.com>
 
         Cherry-pick r292075. rdar://problem/88323776

Modified: branches/safari-613-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (292983 => 292984)


--- branches/safari-613-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2022-04-19 00:49:17 UTC (rev 292983)
+++ branches/safari-613-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2022-04-19 00:49:20 UTC (rev 292984)
@@ -750,6 +750,10 @@
     case ValueRep: {
         JSValue value = forNode(node->child1()).value();
         if (value) {
+            if (node->child1().useKind() == Int52RepUse) {
+                if (auto int32 = value.tryGetAsInt32())
+                    value = jsNumber(*int32);
+            }
             setConstant(node, value);
             break;
         }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to