Title: [293008] trunk/Source/WebCore
- Revision
- 293008
- Author
- [email protected]
- Date
- 2022-04-18 23:38:28 -0700 (Mon, 18 Apr 2022)
Log Message
Remove the PlatformMediaEngineClassName macro
https://bugs.webkit.org/show_bug.cgi?id=239384
Reviewed by Philippe Normand.
Remove the PlatformMediaEngineClassName macro used in the MediaPlayer
implementation file. It's only used for two media engines.
For GStreamer, the code can be simplified and grouped under a single
if-block. For USE_MEDIA_FOUNDATION, the relevant call can similarly be
guarded by the corresponding build guards.
* platform/graphics/MediaPlayer.cpp:
(WebCore::WTF_REQUIRES_LOCK):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (293007 => 293008)
--- trunk/Source/WebCore/ChangeLog 2022-04-19 05:26:53 UTC (rev 293007)
+++ trunk/Source/WebCore/ChangeLog 2022-04-19 06:38:28 UTC (rev 293008)
@@ -1,3 +1,20 @@
+2022-04-18 Zan Dobersek <[email protected]>
+
+ Remove the PlatformMediaEngineClassName macro
+ https://bugs.webkit.org/show_bug.cgi?id=239384
+
+ Reviewed by Philippe Normand.
+
+ Remove the PlatformMediaEngineClassName macro used in the MediaPlayer
+ implementation file. It's only used for two media engines.
+
+ For GStreamer, the code can be simplified and grouped under a single
+ if-block. For USE_MEDIA_FOUNDATION, the relevant call can similarly be
+ guarded by the corresponding build guards.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::WTF_REQUIRES_LOCK):
+
2022-04-18 Tyler Wilcock <[email protected]>
AX: Update the isolated tree in response to AXElementBusyChanged and AXTextChanged notifications
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (293007 => 293008)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2022-04-19 05:26:53 UTC (rev 293007)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2022-04-19 06:38:28 UTC (rev 293008)
@@ -58,7 +58,6 @@
#if USE(GSTREAMER)
#include "MediaPlayerPrivateGStreamer.h"
-#define PlatformMediaEngineClassName MediaPlayerPrivateGStreamer
#if ENABLE(MEDIA_SOURCE)
#include "MediaPlayerPrivateGStreamerMSE.h"
#endif
@@ -66,7 +65,6 @@
#if USE(MEDIA_FOUNDATION)
#include "MediaPlayerPrivateMediaFoundation.h"
-#define PlatformMediaEngineClassName MediaPlayerPrivateMediaFoundation
#endif
#if PLATFORM(COCOA)
@@ -291,16 +289,17 @@
}
#endif // USE(AVFOUNDATION)
-#if defined(PlatformMediaEngineClassName)
#if USE(GSTREAMER)
- if (DeprecatedGlobalSettings::isGStreamerEnabled())
+ if (DeprecatedGlobalSettings::isGStreamerEnabled()) {
+ MediaPlayerPrivateGStreamer::registerMediaEngine(addMediaEngine);
+#if ENABLE(MEDIA_SOURCE)
+ MediaPlayerPrivateGStreamerMSE::registerMediaEngine(addMediaEngine);
#endif
- PlatformMediaEngineClassName::registerMediaEngine(addMediaEngine);
+ }
#endif
-#if USE(GSTREAMER) && ENABLE(MEDIA_SOURCE)
- if (DeprecatedGlobalSettings::isGStreamerEnabled())
- MediaPlayerPrivateGStreamerMSE::registerMediaEngine(addMediaEngine);
+#if USE(MEDIA_FOUNDATION)
+ MediaPlayerPrivateMediaFoundation::registerMediaEngine(addMediaEngine);
#endif
#if USE(EXTERNAL_HOLEPUNCH)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
