Title: [293013] trunk/Source/WebCore
- Revision
- 293013
- Author
- [email protected]
- Date
- 2022-04-19 03:56:29 -0700 (Tue, 19 Apr 2022)
Log Message
[GStreamer] Runtime warning when the player configures the avdec AV1 decoder
https://bugs.webkit.org/show_bug.cgi?id=238991
Patch by Philippe Normand <[email protected]> on 2022-04-19
Reviewed by Xabier Rodriguez-Calvar.
Not all libav GStreamer decoders have a max-threads property, the AV1 decoder for instance
does not. So we need to check the property is present before attempting to set it, in order
to avoid runtime warnings.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::configureVideoDecoder):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (293012 => 293013)
--- trunk/Source/WebCore/ChangeLog 2022-04-19 10:36:23 UTC (rev 293012)
+++ trunk/Source/WebCore/ChangeLog 2022-04-19 10:56:29 UTC (rev 293013)
@@ -1,3 +1,17 @@
+2022-04-19 Philippe Normand <[email protected]>
+
+ [GStreamer] Runtime warning when the player configures the avdec AV1 decoder
+ https://bugs.webkit.org/show_bug.cgi?id=238991
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Not all libav GStreamer decoders have a max-threads property, the AV1 decoder for instance
+ does not. So we need to check the property is present before attempting to set it, in order
+ to avoid runtime warnings.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::configureVideoDecoder):
+
2022-04-19 Tim Nguyen <[email protected]>
Clean up Element::isFocusableWithoutResolvingFullStyle()
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (293012 => 293013)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2022-04-19 10:36:23 UTC (rev 293012)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2022-04-19 10:56:29 UTC (rev 293013)
@@ -2824,7 +2824,8 @@
// Set the decoder maximum number of threads to a low, fixed value, not depending on the
// platform. This also helps with processing metrics gathering. When using the default value
// the decoder introduces artificial processing latency reflecting the maximum number of threads.
- g_object_set(decoder, "max-threads", 2, nullptr);
+ if (g_object_class_find_property(G_OBJECT_GET_CLASS(decoder), "max-threads"))
+ g_object_set(decoder, "max-threads", 2, nullptr);
}
#if USE(TEXTURE_MAPPER_GL)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
