Title: [107676] trunk
Revision
107676
Author
[email protected]
Date
2012-02-13 23:48:45 -0800 (Mon, 13 Feb 2012)

Log Message

[Qt] inspector/styles/undo-add-new-rule.html crashes
https://bugs.webkit.org/show_bug.cgi?id=78502

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::deleteRule):

LayoutTests:

* platform/chromium/test_expectations.txt:
* platform/qt/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (107675 => 107676)


--- trunk/LayoutTests/ChangeLog	2012-02-14 07:38:50 UTC (rev 107675)
+++ trunk/LayoutTests/ChangeLog	2012-02-14 07:48:45 UTC (rev 107676)
@@ -1,3 +1,13 @@
+2012-02-13  Pavel Feldman  <[email protected]>
+
+        [Qt] inspector/styles/undo-add-new-rule.html crashes
+        https://bugs.webkit.org/show_bug.cgi?id=78502
+
+        Reviewed by Yury Semikhatsky.
+
+        * platform/chromium/test_expectations.txt:
+        * platform/qt/Skipped:
+
 2012-02-13  Noel Gordon  <[email protected]>
 
         [chromium] Rebaseline JPEG image results after r107389

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107675 => 107676)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-14 07:38:50 UTC (rev 107675)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-14 07:48:45 UTC (rev 107676)
@@ -3975,7 +3975,6 @@
 
 BUGV8_1948 : fast/js/dfg-put-by-id-prototype-check.html = TEXT
 
-BUGWK78522 DEBUG : inspector/styles/undo-add-new-rule.html = CRASH
 BUGWK78529 LINUX DEBUG GPU : fast/canvas/canvas-text-alignment.html = IMAGE
 
 BUGWK78561 WIN : css3/filters/crash-hw-sw-switch.html = MISSING

Modified: trunk/LayoutTests/platform/qt/Skipped (107675 => 107676)


--- trunk/LayoutTests/platform/qt/Skipped	2012-02-14 07:38:50 UTC (rev 107675)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-14 07:48:45 UTC (rev 107676)
@@ -2611,6 +2611,3 @@
 fast/events/pageshow-pagehide-on-back-cached.html
 fast/events/pageshow-pagehide-on-back-cached-with-frames.html
 
-# [Qt] inspector/styles/undo-add-new-rule.html crashes
-# https://bugs.webkit.org/show_bug.cgi?id=78502
-inspector/styles/undo-add-new-rule.html

Modified: trunk/Source/WebCore/ChangeLog (107675 => 107676)


--- trunk/Source/WebCore/ChangeLog	2012-02-14 07:38:50 UTC (rev 107675)
+++ trunk/Source/WebCore/ChangeLog	2012-02-14 07:48:45 UTC (rev 107676)
@@ -1,3 +1,13 @@
+2012-02-13  Pavel Feldman  <[email protected]>
+
+        [Qt] inspector/styles/undo-add-new-rule.html crashes
+        https://bugs.webkit.org/show_bug.cgi?id=78502
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/InspectorStyleSheet.cpp:
+        (WebCore::InspectorStyleSheet::deleteRule):
+
 2012-02-13  Nate Chapin  <[email protected]>
 
         Reuse CachedRawResources (e.g., XHRs) that are stored

Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (107675 => 107676)


--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp	2012-02-14 07:38:50 UTC (rev 107675)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp	2012-02-14 07:48:45 UTC (rev 107676)
@@ -773,7 +773,7 @@
 
 bool InspectorStyleSheet::deleteRule(const InspectorCSSId& id, ExceptionCode& ec)
 {
-    CSSStyleRule* rule = ruleForId(id);
+    RefPtr<CSSStyleRule> rule = ruleForId(id);
     if (!rule) {
         ec = NOT_FOUND_ERR;
         return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to