Title: [293054] trunk/Source/WebCore
- Revision
- 293054
- Author
- [email protected]
- Date
- 2022-04-19 19:05:07 -0700 (Tue, 19 Apr 2022)
Log Message
EventHandler should use a WeakPtr for m_resizeLayer
https://bugs.webkit.org/show_bug.cgi?id=239515
Reviewed by Wenson Hsieh.
Use a WeakPtr for m_resizeLayer.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
* page/EventHandler.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (293053 => 293054)
--- trunk/Source/WebCore/ChangeLog 2022-04-20 01:29:42 UTC (rev 293053)
+++ trunk/Source/WebCore/ChangeLog 2022-04-20 02:05:07 UTC (rev 293054)
@@ -1,3 +1,16 @@
+2022-04-19 Simon Fraser <[email protected]>
+
+ EventHandler should use a WeakPtr for m_resizeLayer
+ https://bugs.webkit.org/show_bug.cgi?id=239515
+
+ Reviewed by Wenson Hsieh.
+
+ Use a WeakPtr for m_resizeLayer.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEvent):
+ * page/EventHandler.h:
+
2022-04-19 Alex Christensen <[email protected]>
Implement most of CSS typed OM object stringifiers
Modified: trunk/Source/WebCore/page/EventHandler.cpp (293053 => 293054)
--- trunk/Source/WebCore/page/EventHandler.cpp 2022-04-20 01:29:42 UTC (rev 293053)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2022-04-20 02:05:07 UTC (rev 293054)
@@ -1784,7 +1784,7 @@
auto localPoint = roundedIntPoint(mouseEvent.hitTestResult().localPoint());
if (layer && layer->isPointInResizeControl(localPoint)) {
layer->setInResizeMode(true);
- m_resizeLayer = layer;
+ m_resizeLayer = WeakPtr { layer };
m_offsetFromResizeCorner = layer->offsetFromResizeCorner(localPoint);
invalidateClick();
return true;
Modified: trunk/Source/WebCore/page/EventHandler.h (293053 => 293054)
--- trunk/Source/WebCore/page/EventHandler.h 2022-04-20 01:29:42 UTC (rev 293053)
+++ trunk/Source/WebCore/page/EventHandler.h 2022-04-20 02:05:07 UTC (rev 293054)
@@ -542,7 +542,7 @@
DeferrableOneShotTimer m_textRecognitionHoverTimer;
#endif
std::unique_ptr<AutoscrollController> m_autoscrollController;
- RenderLayer* m_resizeLayer { nullptr };
+ WeakPtr<RenderLayer> m_resizeLayer;
double m_maxMouseMovedDuration { 0 };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
