Title: [107684] trunk/Source/WebKit/chromium
Revision
107684
Author
[email protected]
Date
2012-02-14 00:55:38 -0800 (Tue, 14 Feb 2012)

Log Message

[chromium] Pepper plugins don't receive mouse movement information in
non-mouse-lock mode.
https://bugs.webkit.org/show_bug.cgi?id=78014

This change makes WebMouseEventBuilder pass along mouse movement
information properly.

There isn't test for this change because:
- the movement information added is only used by pepper, and there
  isn't any test for pepper at the WebKit side. (WebKit doesn't know
  about pepper.)
- this change is trivial. It just copies two newly-added data fields
  from MouseEvent to WebMouseEventBuilder during conversion.

Patch by Yuzhu Shen <[email protected]> on 2012-02-14
Reviewed by Tony Chang.

* src/WebInputEventConversion.cpp:
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (107683 => 107684)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-14 08:50:19 UTC (rev 107683)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-14 08:55:38 UTC (rev 107684)
@@ -1,3 +1,24 @@
+2012-02-14  Yuzhu Shen  <[email protected]>
+
+        [chromium] Pepper plugins don't receive mouse movement information in
+        non-mouse-lock mode.
+        https://bugs.webkit.org/show_bug.cgi?id=78014
+
+        This change makes WebMouseEventBuilder pass along mouse movement
+        information properly.
+
+        There isn't test for this change because:
+        - the movement information added is only used by pepper, and there
+          isn't any test for pepper at the WebKit side. (WebKit doesn't know
+          about pepper.)
+        - this change is trivial. It just copies two newly-added data fields
+          from MouseEvent to WebMouseEventBuilder during conversion.
+
+        Reviewed by Tony Chang.
+
+        * src/WebInputEventConversion.cpp:
+        (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
+
 2012-02-11  Nikolas Zimmermann  <[email protected]>
 
         Convert svg/animations to use SMIL methods for driving the timeline

Modified: trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp (107683 => 107684)


--- trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp	2012-02-14 08:50:19 UTC (rev 107683)
+++ trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp	2012-02-14 08:55:38 UTC (rev 107684)
@@ -389,6 +389,10 @@
     windowY = p.y();
     x = event.absoluteLocation().x() - widget->location().x();
     y = event.absoluteLocation().y() - widget->location().y();
+#if ENABLE(POINTER_LOCK)
+    movementX = event.webkitMovementX();
+    movementY = event.webkitMovementY();
+#endif
     clickCount = event.detail();
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to