Title: [293089] trunk
Revision
293089
Author
[email protected]
Date
2022-04-20 03:43:36 -0700 (Wed, 20 Apr 2022)

Log Message

Unprefix -webkit-user-select CSS property
https://bugs.webkit.org/show_bug.cgi?id=208677

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

WPT progressions.

* web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* web-platform-tests/css/css-ui/inheritance-expected.txt:
* web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt:
* web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt:
* web-platform-tests/inert/inert-computed-style-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* css/CSSProperties.json:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* css/html.css:
(#if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY):
(input::-webkit-inner-spin-button):
(input::-webkit-strong-password-auto-fill-button):
(input::-webkit-credentials-auto-fill-button):
(input::-webkit-contacts-auto-fill-button):
(input::-webkit-credit-card-auto-fill-button):
(input::-webkit-caps-lock-indicator):
(#if defined(ENABLE_DATALIST_ELEMENT) && ENABLE_DATALIST_ELEMENT):
(textarea):
(input:-webkit-autofill-strong-password):
* css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(video::-webkit-media-text-track-container):
* css/plugIns.css:
(embed::-webkit-snapshotted-plugin-content > .snapshot-overlay > .snapshot-label,):
* dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateSubtree):
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):

LayoutTests:

* editing/selection/user-select-js-property-expected.txt:
* editing/selection/user-select-js-property.html:
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:
* platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (293088 => 293089)


--- trunk/LayoutTests/ChangeLog	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/ChangeLog	2022-04-20 10:43:36 UTC (rev 293089)
@@ -1,5 +1,22 @@
 2022-04-20  Tim Nguyen  <[email protected]>
 
+        Unprefix -webkit-user-select CSS property
+        https://bugs.webkit.org/show_bug.cgi?id=208677
+
+        Reviewed by Simon Fraser.
+
+        * editing/selection/user-select-js-property-expected.txt:
+        * editing/selection/user-select-js-property.html:
+        * fast/css/getComputedStyle/computed-style-expected.txt:
+        * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+        * fast/css/getComputedStyle/resources/property-names.js:
+        * platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+        * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+        * platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+        * svg/css/getComputedStyle-basic-expected.txt:
+
+2022-04-20  Tim Nguyen  <[email protected]>
+
         [Debug] Skip editing/inserting/insert-list-user-select-none-crash.html
 
         Unreviewed test gardening.

Modified: trunk/LayoutTests/editing/selection/user-select-js-property-expected.txt (293088 => 293089)


--- trunk/LayoutTests/editing/selection/user-select-js-property-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/editing/selection/user-select-js-property-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -1,10 +1,17 @@
-Test setting CSSStyleDeclaration.webkitUserStyle and userStyle
+Test setting CSSStyleDeclaration.webkitUserSelect and userSelect
 
 editable
 uneditable
 
 PASS user-select-js-property
+PASS 'userSelect' in style
 PASS 'webkitUserSelect' in style
-PASS webkitUserSelect of '#bar { -webkit-user-select: none; }' should be 'none'
+PASS userSelect of '#foo { user-select: none; }' should be 'none'
+PASS webkitUserSelect of '#foo { user-select: none; }' should be 'none'
+PASS userSelect of '#bar { user-select: none; }' should be 'none'
+PASS webkitUserSelect of '#bar { user-select: none; }' should be 'none'
+PASS userSelect of 'user-select:none' should be 'none'
+PASS webkitUserSelect of 'user-select:none' should be 'none'
+PASS userSelect of '-webkit-user-select:none' should be 'none'
 PASS webkitUserSelect of '-webkit-user-select:none' should be 'none'
 

Modified: trunk/LayoutTests/editing/selection/user-select-js-property.html (293088 => 293089)


--- trunk/LayoutTests/editing/selection/user-select-js-property.html	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/editing/selection/user-select-js-property.html	2022-04-20 10:43:36 UTC (rev 293089)
@@ -2,22 +2,24 @@
 <script src=""
 <script src=""
 <style>
-    /* FIXME: Add testcases for unprefixed version (webkit.org/b/208677) */
+    #foo {
+        user-select: none;
+    }
     #bar {
         -webkit-user-select: none;
     }
 </style>
 <div id="container">
-<p id="description">Test setting CSSStyleDeclaration.webkitUserStyle and userStyle</p>
+<p id="description">Test setting CSSStyleDeclaration.webkitUserSelect and userSelect</p>
 <div id="sample1" contenteditable="true">editable</div>
 <div id="sample2" contenteditable="false">uneditable</div>
+<div class="none" style="user-select:none"></div>
 <div class="none" style="-webkit-user-select:none"></div>
 </div>
 <div id="log"></div>
 <script>
 var selection = window.getSelection();
-function setSelection(node)
-{
+function setSelection(node) {
     var range = document.createRange();
     range.selectNodeContents(node);
     selection.empty();
@@ -24,13 +26,13 @@
     selection.addRange(range);
 }
 
-test(function(){
-    // user-select:none in editable element
+test(function() {
+    // user-select: none in editable element
     sample1.style.webkitUserSelect = "none";
     setSelection(sample1);
     assert_equals(selection.type, "Range");
 
-    // user-select:none in uneditable element
+    // user-select: none in uneditable element
     sample2.style.webkitUserSelect = "none";
     setSelection(sample2);
     assert_equals(selection.type, "None");
@@ -37,7 +39,10 @@
 });
 
 var style = document.createElement("baz").style;
-test(function () {
+test(function() {
+  assert_true("userSelect" in style);
+}, "'userSelect' in style");
+test(function() {
     assert_true("webkitUserSelect" in style);
 }, "'webkitUserSelect' in style");
 
@@ -50,8 +55,11 @@
 }
 
 function testUserSelect(style, title) {
-    test(function () {
+    test(function() {
+        assert_equals(style.userSelect, "none");
+    }, `userSelect of '${title}' should be 'none'`);
+    test(function() {
         assert_equals(style.webkitUserSelect, "none");
-    }, "webkitUserSelect of '" + title + "' should be 'none'");
+    }, `webkitUserSelect of '${title}' should be 'none'`);
 }
 </script>
\ No newline at end of file

Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (293088 => 293089)


--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -193,6 +193,7 @@
 transition-property: all;
 transition-timing-function: ease;
 unicode-bidi: normal;
+user-select: text;
 vector-effect: none;
 vertical-align: baseline;
 visibility: visible;
@@ -256,7 +257,6 @@
 -webkit-transform-style: flat;
 -webkit-user-drag: auto;
 -webkit-user-modify: read-only;
--webkit-user-select: text;
 
 Other attributes that the computed style class supports:
 

Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (293088 => 293089)


--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -192,6 +192,7 @@
 transition-property: all
 transition-timing-function: ease
 unicode-bidi: normal
+user-select: text
 vector-effect: none
 vertical-align: baseline
 visibility: visible
@@ -255,7 +256,6 @@
 -webkit-transform-style: flat
 -webkit-user-drag: auto
 -webkit-user-modify: read-only
--webkit-user-select: text
 background-position-x: 0%
 background-position-y: 0%
 border-spacing: 0px 0px

Modified: trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js (293088 => 293089)


--- trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js	2022-04-20 10:43:36 UTC (rev 293089)
@@ -116,7 +116,6 @@
     "transition-timing-function": true,
     "-webkit-user-drag": true,
     "-webkit-user-modify": true,
-    "-webkit-user-select": true,
     "-webkit-writing-mode": true,
     "alignment-baseline": true,
     "background-attachment": true,
@@ -267,6 +266,7 @@
     "text-transform": true,
     "top": true,
     "unicode-bidi": true,
+    "user-select": true,
     "vector-effect": true,
     "vertical-align": true,
     "visibility": true,

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293088 => 293089)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-04-20 10:43:36 UTC (rev 293089)
@@ -1,3 +1,18 @@
+2022-04-20  Tim Nguyen  <[email protected]>
+
+        Unprefix -webkit-user-select CSS property
+        https://bugs.webkit.org/show_bug.cgi?id=208677
+
+        Reviewed by Simon Fraser.
+
+        WPT progressions.
+
+        * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+        * web-platform-tests/css/css-ui/inheritance-expected.txt:
+        * web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt:
+        * web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt:
+        * web-platform-tests/inert/inert-computed-style-expected.txt:
+
 2022-04-19  Alex Christensen  <[email protected]>
 
         Implement most of CSS typed OM object stringifiers

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293088 => 293089)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -318,6 +318,7 @@
 PASS transition-timing-function
 PASS translate
 PASS unicode-bidi
+PASS user-select
 PASS vector-effect
 PASS vertical-align
 PASS visibility
@@ -397,5 +398,4 @@
 PASS -webkit-transform-style
 PASS -webkit-user-drag
 PASS -webkit-user-modify
-PASS -webkit-user-select
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/inheritance-expected.txt (293088 => 293089)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/inheritance-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/inheritance-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -25,6 +25,6 @@
 PASS Property outline-width does not inherit
 PASS Property resize has initial value none
 PASS Property resize does not inherit
-FAIL Property user-select has initial value auto assert_true: user-select doesn't seem to be supported in the computed style expected true got false
-FAIL Property user-select does not inherit assert_true: expected true got false
+FAIL Property user-select has initial value auto assert_equals: expected "auto" but got "text"
+FAIL Property user-select does not inherit assert_not_equals: got disallowed value "none"
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt (293088 => 293089)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -1,7 +1,7 @@
 
-FAIL Property user-select value 'auto' assert_true: user-select doesn't seem to be supported in the computed style expected true got false
-FAIL Property user-select value 'text' assert_true: user-select doesn't seem to be supported in the computed style expected true got false
-FAIL Property user-select value 'none' assert_true: user-select doesn't seem to be supported in the computed style expected true got false
-FAIL Property user-select value 'contain' assert_true: user-select doesn't seem to be supported in the computed style expected true got false
-FAIL Property user-select value 'all' assert_true: user-select doesn't seem to be supported in the computed style expected true got false
+FAIL Property user-select value 'auto' assert_equals: expected "auto" but got "text"
+PASS Property user-select value 'text'
+PASS Property user-select value 'none'
+FAIL Property user-select value 'contain' assert_true: 'contain' is a supported value for user-select. expected true got false
+PASS Property user-select value 'all'
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt (293088 => 293089)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -1,7 +1,7 @@
 
-FAIL e.style['user-select'] = "auto" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['user-select'] = "text" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['user-select'] = "none" should set the property value assert_not_equals: property should be set got disallowed value ""
+PASS e.style['user-select'] = "auto" should set the property value
+PASS e.style['user-select'] = "text" should set the property value
+PASS e.style['user-select'] = "none" should set the property value
 FAIL e.style['user-select'] = "contain" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['user-select'] = "all" should set the property value assert_not_equals: property should be set got disallowed value ""
+PASS e.style['user-select'] = "all" should set the property value
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/inert/inert-computed-style-expected.txt (293088 => 293089)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/inert/inert-computed-style-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/inert/inert-computed-style-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -1,3 +1,3 @@
 
-FAIL inert isn't hit-testable, but that isn't expose in the computed style assert_equals: inert node doesn't change pointer-events computed value expected (string) "auto" but got (undefined) undefined
+FAIL inert isn't hit-testable, but that isn't expose in the computed style assert_equals: inert node doesn't change pointer-events computed value expected "auto" but got "text"
 

Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293088 => 293089)


--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -318,6 +318,7 @@
 PASS transition-timing-function
 PASS translate
 PASS unicode-bidi
+PASS user-select
 PASS vector-effect
 PASS vertical-align
 PASS visibility
@@ -395,5 +396,4 @@
 PASS -webkit-transform-style
 PASS -webkit-user-drag
 PASS -webkit-user-modify
-PASS -webkit-user-select
 

Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293088 => 293089)


--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -286,6 +286,7 @@
 PASS transition-property
 PASS transition-timing-function
 PASS unicode-bidi
+PASS user-select
 PASS vector-effect
 PASS vertical-align
 PASS visibility
@@ -372,5 +373,4 @@
 PASS -webkit-transform-style
 PASS -webkit-user-drag
 PASS -webkit-user-modify
-PASS -webkit-user-select
 

Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293088 => 293089)


--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -318,6 +318,7 @@
 PASS transition-timing-function
 PASS translate
 PASS unicode-bidi
+PASS user-select
 PASS vector-effect
 PASS vertical-align
 PASS visibility
@@ -394,5 +395,4 @@
 PASS -webkit-transform-style
 PASS -webkit-user-drag
 PASS -webkit-user-modify
-PASS -webkit-user-select
 

Modified: trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt (293088 => 293089)


--- trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt	2022-04-20 10:43:36 UTC (rev 293089)
@@ -384,6 +384,8 @@
 rect: style.getPropertyCSSValue(transition-timing-function) : [object CSSValueList]
 rect: style.getPropertyValue(unicode-bidi) : normal
 rect: style.getPropertyCSSValue(unicode-bidi) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(user-select) : text
+rect: style.getPropertyCSSValue(user-select) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(vector-effect) : none
 rect: style.getPropertyCSSValue(vector-effect) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(vertical-align) : baseline
@@ -510,8 +512,6 @@
 rect: style.getPropertyCSSValue(-webkit-user-drag) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(-webkit-user-modify) : read-only
 rect: style.getPropertyCSSValue(-webkit-user-modify) : [object CSSPrimitiveValue]
-rect: style.getPropertyValue(-webkit-user-select) : text
-rect: style.getPropertyCSSValue(-webkit-user-select) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(align-content) : normal
 g: style.getPropertyCSSValue(align-content) : [object CSSValueList]
 g: style.getPropertyValue(align-items) : normal
@@ -898,6 +898,8 @@
 g: style.getPropertyCSSValue(transition-timing-function) : [object CSSValueList]
 g: style.getPropertyValue(unicode-bidi) : normal
 g: style.getPropertyCSSValue(unicode-bidi) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(user-select) : text
+g: style.getPropertyCSSValue(user-select) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(vector-effect) : none
 g: style.getPropertyCSSValue(vector-effect) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(vertical-align) : baseline
@@ -1024,6 +1026,4 @@
 g: style.getPropertyCSSValue(-webkit-user-drag) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(-webkit-user-modify) : read-only
 g: style.getPropertyCSSValue(-webkit-user-modify) : [object CSSPrimitiveValue]
-g: style.getPropertyValue(-webkit-user-select) : text
-g: style.getPropertyCSSValue(-webkit-user-select) : [object CSSPrimitiveValue]
 

Modified: trunk/Source/WebCore/ChangeLog (293088 => 293089)


--- trunk/Source/WebCore/ChangeLog	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/ChangeLog	2022-04-20 10:43:36 UTC (rev 293089)
@@ -1,3 +1,41 @@
+2022-04-20  Tim Nguyen  <[email protected]>
+
+        Unprefix -webkit-user-select CSS property
+        https://bugs.webkit.org/show_bug.cgi?id=208677
+
+        Reviewed by Simon Fraser.
+
+        * animation/CSSPropertyAnimation.cpp:
+        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+        * css/CSSProperties.json:
+        * css/parser/CSSParserFastPaths.cpp:
+        (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+        (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+        * css/html.css:
+        (#if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY):
+        (input::-webkit-inner-spin-button):
+        (input::-webkit-strong-password-auto-fill-button):
+        (input::-webkit-credentials-auto-fill-button):
+        (input::-webkit-contacts-auto-fill-button):
+        (input::-webkit-credit-card-auto-fill-button):
+        (input::-webkit-caps-lock-indicator):
+        (#if defined(ENABLE_DATALIST_ELEMENT) && ENABLE_DATALIST_ELEMENT):
+        (textarea):
+        (input:-webkit-autofill-strong-password):
+        * css/mediaControls.css:
+        (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
+        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
+        (video::-webkit-media-text-track-container):
+        * css/plugIns.css:
+        (embed::-webkit-snapshotted-plugin-content > .snapshot-overlay > .snapshot-label,):
+        * dom/ImageOverlay.cpp:
+        (WebCore::ImageOverlay::updateSubtree):
+        (WebCore::ImageOverlay::updateWithTextRecognitionResult):
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::collectPresentationalHintsForAttribute):
+
 2022-04-20  Diego Pino Garcia  <[email protected]>
 
         Unreviewed, non-unified build fixes after r293052

Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (293088 => 293089)


--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-04-20 10:43:36 UTC (rev 293089)
@@ -3650,7 +3650,7 @@
         case CSSPropertyWebkitTransformStyle:
         case CSSPropertyWebkitUserDrag:
         case CSSPropertyWebkitUserModify:
-        case CSSPropertyWebkitUserSelect:
+        case CSSPropertyUserSelect:
             continue;
         default:
             auto resolvedProperty = CSSProperty::resolveDirectionAwareProperty(property, RenderStyle::initialDirection(), RenderStyle::initialWritingMode());

Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (293088 => 293089)


--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2022-04-20 10:43:36 UTC (rev 293089)
@@ -3839,7 +3839,7 @@
 #endif
         case CSSPropertyWebkitUserDrag:
             return cssValuePool.createValue(style.userDrag());
-        case CSSPropertyWebkitUserSelect:
+        case CSSPropertyUserSelect:
             return cssValuePool.createValue(style.userSelect());
         case CSSPropertyBorderBottomLeftRadius:
             return borderRadiusCornerValue(style.borderBottomLeftRadius(), style);

Modified: trunk/Source/WebCore/css/CSSProperties.json (293088 => 293089)


--- trunk/Source/WebCore/css/CSSProperties.json	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/css/CSSProperties.json	2022-04-20 10:43:36 UTC (rev 293089)
@@ -7264,14 +7264,23 @@
             ],
             "status": "non-standard"
         },
-        "-webkit-user-select": {
+        "user-select": {
+            "codegen-properties": {
+                "aliases": [
+                    "-webkit-user-select"
+                ]
+            },
             "inherited": true,
             "values": [
-                "element"
+                "none",
+                "auto",
+                "text",
+                "all",
+                {
+                    "value": "contain",
+                    "status": "unimplemented"
+                }
             ],
-            "status": {
-                "status": "experimental"
-        },
             "specification": {
                 "category": "css-ui",
                 "url": "https://www.w3.org/TR/css-ui-4/#propdef-user-select"

Modified: trunk/Source/WebCore/css/html.css (293088 => 293089)


--- trunk/Source/WebCore/css/html.css	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/css/html.css	2022-04-20 10:43:36 UTC (rev 293089)
@@ -422,7 +422,7 @@
     padding: 1px;
 #endif
     -webkit-rtl-ordering: logical;
-    -webkit-user-select: text;
+    user-select: text;
     cursor: auto;
 }
 
@@ -597,7 +597,7 @@
      * button in layout(). */
     height: 1.5em;
     flex: none;
-    -webkit-user-select: none;
+    user-select: none;
 }
 
 input::-webkit-strong-password-auto-fill-button {
@@ -604,7 +604,7 @@
     flex-shrink: 1 !important;
     font-family: -apple-system !important;
     -webkit-text-security: none !important;
-    -webkit-user-select: none !important;
+    user-select: none !important;
     pointer-events: none !important;
     text-align: right !important;
     color: rgba(0, 0, 0, 0.8) !important;
@@ -630,7 +630,7 @@
     background-color: black;
 #endif
     flex: none;
-    -webkit-user-select: none;
+    user-select: none;
 }
 
 input::-webkit-credentials-auto-fill-button:hover {
@@ -662,7 +662,7 @@
     margin-right: 2px;
     background-color: black;
     flex: none;
-    -webkit-user-select: none;
+    user-select: none;
 }
 
 input::-webkit-contacts-auto-fill-button:hover {
@@ -682,7 +682,7 @@
     margin-right: 2px;
     background-color: black;
     flex: none;
-    -webkit-user-select: none;
+    user-select: none;
 }
 
 input::-webkit-credit-card-auto-fill-button:hover {
@@ -699,7 +699,7 @@
     max-width: 17px;
     align-self: stretch;
     flex: none;
-    -webkit-user-select: none;
+    user-select: none;
 }
 
 #if defined(ENABLE_DATALIST_ELEMENT) && ENABLE_DATALIST_ELEMENT
@@ -710,7 +710,7 @@
     cursor: default;
     align-self: stretch;
     flex: none;
-    -webkit-user-select: none;
+    user-select: none;
 #if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY
     width: 11px;
     /* Make it easier to hit the button on iOS */
@@ -738,7 +738,7 @@
 #endif
     border: 1px solid;
     -webkit-rtl-ordering: logical;
-    -webkit-user-select: text;
+    user-select: text;
     padding: 2px;
 #else
     -webkit-nbsp-mode: space;
@@ -788,7 +788,7 @@
 }
 
 input:-webkit-autofill-strong-password {
-    -webkit-user-select: none !important;
+    user-select: none !important;
 }
 
 input:-webkit-autofill-strong-password, input:-webkit-autofill-strong-password-viewable {

Modified: trunk/Source/WebCore/css/mediaControls.css (293088 => 293089)


--- trunk/Source/WebCore/css/mediaControls.css	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/css/mediaControls.css	2022-04-20 10:43:36 UTC (rev 293089)
@@ -46,7 +46,7 @@
     direction: ltr;
     flex-direction: row;
     align-items: center;
-    -webkit-user-select: none;
+    user-select: none;
     position: relative;
     bottom: 0;
     width: 100%;
@@ -100,7 +100,7 @@
     align-items: center;
     justify-content: flex-end;
     flex: 1 1;
-    -webkit-user-select: none;
+    user-select: none;
     height: 16px;
     min-width: 0;
 }
@@ -230,7 +230,7 @@
     text-indent: 0;
     text-decoration: none;
     pointer-events: none;
-    -webkit-user-select: none;
+    user-select: none;
     word-break: break-word;
 
     flex: 1 1;

Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (293088 => 293089)


--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2022-04-20 10:43:36 UTC (rev 293089)
@@ -826,7 +826,7 @@
         return valueID == CSSValueAuto || valueID == CSSValueNone || valueID == CSSValueElement;
     case CSSPropertyWebkitUserModify: // read-only | read-write
         return valueID == CSSValueReadOnly || valueID == CSSValueReadWrite || valueID == CSSValueReadWritePlaintextOnly;
-    case CSSPropertyWebkitUserSelect: // auto | none | text | all
+    case CSSPropertyUserSelect: // auto | none | text | all
         return valueID == CSSValueAuto || valueID == CSSValueNone || valueID == CSSValueText || valueID == CSSValueAll;
     case CSSPropertyWritingMode:
         // Note that horizontal-bt is not supported by the unprefixed version of
@@ -990,7 +990,7 @@
     case CSSPropertyWebkitTransformStyle:
     case CSSPropertyWebkitUserDrag:
     case CSSPropertyWebkitUserModify:
-    case CSSPropertyWebkitUserSelect:
+    case CSSPropertyUserSelect:
     case CSSPropertyWhiteSpace:
     case CSSPropertyWordBreak:
     case CSSPropertyWordWrap:

Modified: trunk/Source/WebCore/css/plugIns.css (293088 => 293089)


--- trunk/Source/WebCore/css/plugIns.css	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/css/plugIns.css	2022-04-20 10:43:36 UTC (rev 293089)
@@ -68,7 +68,7 @@
 object::-webkit-snapshotted-plugin-content > .snapshot-overlay > .snapshot-label
 {
     color: black;
-    -webkit-user-select: none;
+    user-select: none;
 }
 
 embed::-webkit-snapshotted-plugin-content > .snapshot-overlay > .snapshot-label > div,

Modified: trunk/Source/WebCore/dom/ImageOverlay.cpp (293088 => 293089)


--- trunk/Source/WebCore/dom/ImageOverlay.cpp	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/dom/ImageOverlay.cpp	2022-04-20 10:43:36 UTC (rev 293089)
@@ -378,7 +378,7 @@
             rootContainer->setIdAttribute(imageOverlayElementIdentifier());
             rootContainer->setTranslate(false);
             if (document->isImageDocument())
-                rootContainer->setInlineStyleProperty(CSSPropertyWebkitUserSelect, CSSValueText);
+                rootContainer->setInlineStyleProperty(CSSPropertyUserSelect, CSSValueText);
 
             if (mediaControlsContainer)
                 mediaControlsContainer->appendChild(rootContainer);
@@ -440,7 +440,7 @@
         }
 
         if (document->quirks().needsToForceUserSelectAndUserDragWhenInstallingImageOverlay()) {
-            element.setInlineStyleProperty(CSSPropertyWebkitUserSelect, CSSValueText);
+            element.setInlineStyleProperty(CSSPropertyUserSelect, CSSValueText);
             element.setInlineStyleProperty(CSSPropertyWebkitUserDrag, CSSValueAuto);
         }
     }
@@ -565,7 +565,7 @@
                 "scale("_s, targetSize.width() / sizeBeforeTransform.width(), ", "_s, targetSize.height() / sizeBeforeTransform.height(), ") "_s
             ));
 
-            textContainer->setInlineStyleProperty(CSSPropertyWebkitUserSelect, applyUserSelectAll ? CSSValueAll : CSSValueNone);
+            textContainer->setInlineStyleProperty(CSSPropertyUserSelect, applyUserSelectAll ? CSSValueAll : CSSValueNone);
         }
 
         if (document->isImageDocument())

Modified: trunk/Source/WebCore/html/HTMLElement.cpp (293088 => 293089)


--- trunk/Source/WebCore/html/HTMLElement.cpp	2022-04-20 09:09:05 UTC (rev 293088)
+++ trunk/Source/WebCore/html/HTMLElement.cpp	2022-04-20 10:43:36 UTC (rev 293089)
@@ -214,7 +214,7 @@
         if (equalLettersIgnoringASCIICase(value, "true")) {
             addPropertyToPresentationalHintStyle(style, CSSPropertyWebkitUserDrag, CSSValueElement);
             if (!isDraggableIgnoringAttributes())
-                addPropertyToPresentationalHintStyle(style, CSSPropertyWebkitUserSelect, CSSValueNone);
+                addPropertyToPresentationalHintStyle(style, CSSPropertyUserSelect, CSSValueNone);
         } else if (equalLettersIgnoringASCIICase(value, "false"))
             addPropertyToPresentationalHintStyle(style, CSSPropertyWebkitUserDrag, CSSValueNone);
     } else if (name == dirAttr) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to