Title: [293127] trunk/Source/WebKit
- Revision
- 293127
- Author
- [email protected]
- Date
- 2022-04-20 15:32:06 -0700 (Wed, 20 Apr 2022)
Log Message
Add release assert logging in RemoteRenderingBackendProxy::prepareBuffersForDisplay()
https://bugs.webkit.org/show_bug.cgi?id=239563
Reviewed by Wenson Hsieh.
Use RELEASE_ASSERT_WITH_MESSAGE() to make it more clear which of the two release
assertions is being hit.
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (293126 => 293127)
--- trunk/Source/WebKit/ChangeLog 2022-04-20 22:29:50 UTC (rev 293126)
+++ trunk/Source/WebKit/ChangeLog 2022-04-20 22:32:06 UTC (rev 293127)
@@ -1,3 +1,16 @@
+2022-04-20 Simon Fraser <[email protected]>
+
+ Add release assert logging in RemoteRenderingBackendProxy::prepareBuffersForDisplay()
+ https://bugs.webkit.org/show_bug.cgi?id=239563
+
+ Reviewed by Wenson Hsieh.
+
+ Use RELEASE_ASSERT_WITH_MESSAGE() to make it more clear which of the two release
+ assertions is being hit.
+
+ * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+ (WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):
+
2022-04-20 Megan Gardner <[email protected]>
Address recent deprecation warnings on iOS.
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (293126 => 293127)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2022-04-20 22:29:50 UTC (rev 293126)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2022-04-20 22:32:06 UTC (rev 293127)
@@ -310,8 +310,8 @@
Vector<PrepareBackingStoreBuffersOutputData> outputData;
auto sendResult = sendSyncToStream(Messages::RemoteRenderingBackend::PrepareBuffersForDisplay(inputData), Messages::RemoteRenderingBackend::PrepareBuffersForDisplay::Reply(outputData));
- RELEASE_ASSERT(sendResult);
- RELEASE_ASSERT(inputData.size() == outputData.size());
+ RELEASE_ASSERT_WITH_MESSAGE(sendResult, "PrepareBuffersForDisplay: IPC failed, probably because of a GPU Process crash");
+ RELEASE_ASSERT_WITH_MESSAGE(inputData.size() == outputData.size(), "PrepareBuffersForDisplay: mismatched buffer vector sizes");
auto fetchBufferWithIdentifier = [&](std::optional<RenderingResourceIdentifier> identifier, std::optional<ImageBufferBackendHandle>&& handle = std::nullopt, bool isFrontBuffer = false) -> RefPtr<ImageBuffer> {
if (!identifier)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
