Title: [293287] trunk
- Revision
- 293287
- Author
- [email protected]
- Date
- 2022-04-22 23:27:11 -0700 (Fri, 22 Apr 2022)
Log Message
Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
https://bugs.webkit.org/show_bug.cgi?id=191824
Patch by Rob Buis <[email protected]> on 2022-04-22
Reviewed by Eric Carlson.
Source/WebCore:
Provide an empty visibleInViewportStateChanged implementation
for RenderMedia to prevent hitting the ASSERT.
Test: media/audio-viewport-state-change-crash.html
* rendering/RenderMedia.h:
LayoutTests:
* media/audio-viewport-state-change-crash-expected.txt: Added.
* media/audio-viewport-state-change-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (293286 => 293287)
--- trunk/LayoutTests/ChangeLog 2022-04-23 04:40:17 UTC (rev 293286)
+++ trunk/LayoutTests/ChangeLog 2022-04-23 06:27:11 UTC (rev 293287)
@@ -1,3 +1,13 @@
+2022-04-22 Rob Buis <[email protected]>
+
+ Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
+ https://bugs.webkit.org/show_bug.cgi?id=191824
+
+ Reviewed by Eric Carlson.
+
+ * media/audio-viewport-state-change-crash-expected.txt: Added.
+ * media/audio-viewport-state-change-crash.html: Added.
+
2022-04-22 Patrick Angle <[email protected]>
Web Inspector: Regression(r287684) Resources from the memory cache show empty content in Network, Sources, and Search tabs
Added: trunk/LayoutTests/media/audio-viewport-state-change-crash-expected.txt (0 => 293287)
--- trunk/LayoutTests/media/audio-viewport-state-change-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/media/audio-viewport-state-change-crash-expected.txt 2022-04-23 06:27:11 UTC (rev 293287)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/media/audio-viewport-state-change-crash.html (0 => 293287)
--- trunk/LayoutTests/media/audio-viewport-state-change-crash.html (rev 0)
+++ trunk/LayoutTests/media/audio-viewport-state-change-crash.html 2022-04-23 06:27:11 UTC (rev 293287)
@@ -0,0 +1,6 @@
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
+<audio controls style="padding: 119vh 71vh 33vh"></audio>
+PASS
Modified: trunk/Source/WebCore/ChangeLog (293286 => 293287)
--- trunk/Source/WebCore/ChangeLog 2022-04-23 04:40:17 UTC (rev 293286)
+++ trunk/Source/WebCore/ChangeLog 2022-04-23 06:27:11 UTC (rev 293287)
@@ -1,3 +1,17 @@
+2022-04-22 Rob Buis <[email protected]>
+
+ Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
+ https://bugs.webkit.org/show_bug.cgi?id=191824
+
+ Reviewed by Eric Carlson.
+
+ Provide an empty visibleInViewportStateChanged implementation
+ for RenderMedia to prevent hitting the ASSERT.
+
+ Test: media/audio-viewport-state-change-crash.html
+
+ * rendering/RenderMedia.h:
+
2022-04-22 Simon Fraser <[email protected]>
Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
Modified: trunk/Source/WebCore/rendering/RenderMedia.h (293286 => 293287)
--- trunk/Source/WebCore/rendering/RenderMedia.h 2022-04-23 04:40:17 UTC (rev 293286)
+++ trunk/Source/WebCore/rendering/RenderMedia.h 2022-04-23 06:27:11 UTC (rev 293287)
@@ -46,6 +46,8 @@
protected:
void layout() override;
+ void visibleInViewportStateChanged() override { }
+
private:
void element() const = delete;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
