Title: [293289] trunk
- Revision
- 293289
- Author
- [email protected]
- Date
- 2022-04-23 01:10:09 -0700 (Sat, 23 Apr 2022)
Log Message
[ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
https://bugs.webkit.org/show_bug.cgi?id=239598
Patch by Carlos Garcia Campos <[email protected]> on 2022-04-23
Reviewed by Andres Gonzalez.
Tools:
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::domIdentifier const): Deleted.
* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::domIdentifier const):
* WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
(WTR::AccessibilityUIElement::domIdentifier const):
LayoutTests:
* platform/glib/accessibility/table-add-remove-row-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (293288 => 293289)
--- trunk/LayoutTests/ChangeLog 2022-04-23 06:44:03 UTC (rev 293288)
+++ trunk/LayoutTests/ChangeLog 2022-04-23 08:10:09 UTC (rev 293289)
@@ -1,3 +1,12 @@
+2022-04-23 Carlos Garcia Campos <[email protected]>
+
+ [ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
+ https://bugs.webkit.org/show_bug.cgi?id=239598
+
+ Reviewed by Andres Gonzalez.
+
+ * platform/glib/accessibility/table-add-remove-row-expected.txt: Removed.
+
2022-04-22 Rob Buis <[email protected]>
Should never be reached failure in WebCore::RenderElement::visibleInViewportStateChanged
Deleted: trunk/LayoutTests/platform/glib/accessibility/table-add-remove-row-expected.txt (293288 => 293289)
--- trunk/LayoutTests/platform/glib/accessibility/table-add-remove-row-expected.txt 2022-04-23 06:44:03 UTC (rev 293288)
+++ trunk/LayoutTests/platform/glib/accessibility/table-add-remove-row-expected.txt 2022-04-23 08:10:09 UTC (rev 293289)
@@ -1,12 +0,0 @@
-Original number of rows: 1
-null
-Number of rows after appending 1 row: 2
-null
-null
-Number of rows after removing first row: 1
-null
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-d e f
Modified: trunk/Tools/ChangeLog (293288 => 293289)
--- trunk/Tools/ChangeLog 2022-04-23 06:44:03 UTC (rev 293288)
+++ trunk/Tools/ChangeLog 2022-04-23 08:10:09 UTC (rev 293289)
@@ -1,3 +1,17 @@
+2022-04-23 Carlos Garcia Campos <[email protected]>
+
+ [ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
+ https://bugs.webkit.org/show_bug.cgi?id=239598
+
+ Reviewed by Andres Gonzalez.
+
+ * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
+ (WTR::AccessibilityUIElement::domIdentifier const): Deleted.
+ * WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
+ (WTR::AccessibilityUIElement::domIdentifier const):
+ * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
+ (WTR::AccessibilityUIElement::domIdentifier const):
+
2022-04-22 Chris Dumez <[email protected]>
Move global AtomStrings to a common header to promote reuse
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp (293288 => 293289)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2022-04-23 06:44:03 UTC (rev 293288)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2022-04-23 08:10:09 UTC (rev 293289)
@@ -120,7 +120,6 @@
bool AccessibilityUIElement::isInDescriptionListTerm() const { return false; }
bool AccessibilityUIElement::isInCell() const { return false; }
-JSRetainPtr<JSStringRef> AccessibilityUIElement::domIdentifier() const { return nullptr; }
JSRetainPtr<JSStringRef> AccessibilityUIElement::sortDirection() const { return nullptr; }
JSRetainPtr<JSStringRef> AccessibilityUIElement::lineRectsAndText() const { return { }; }
RefPtr<AccessibilityTextMarkerRange> AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker(AccessibilityTextMarker*) { return nullptr; }
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp (293288 => 293289)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp 2022-04-23 06:44:03 UTC (rev 293288)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp 2022-04-23 08:10:09 UTC (rev 293289)
@@ -446,6 +446,12 @@
return OpaqueJSString::tryCreate(!value.isNull() ? value : "false"_s).leakRef();
}
+JSRetainPtr<JSStringRef> AccessibilityUIElement::domIdentifier() const
+{
+ m_element->updateBackingStore();
+ return OpaqueJSString::tryCreate(m_element->attributes().get("id"_s)).leakRef();
+}
+
JSValueRef AccessibilityUIElement::uiElementArrayAttributeValue(JSStringRef attribute) const
{
return nullptr;
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp (293288 => 293289)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp 2022-04-23 06:44:03 UTC (rev 293288)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp 2022-04-23 08:10:09 UTC (rev 293289)
@@ -1015,6 +1015,12 @@
return false;
}
+JSRetainPtr<JSStringRef> AccessibilityUIElement::domIdentifier() const
+{
+ notImplemented();
+ return nullptr;
+}
+
} // namespace WTF
#endif // ENABLE(ACCESSIBILITY)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
