Title: [293294] trunk/Tools
Revision
293294
Author
[email protected]
Date
2022-04-23 14:13:57 -0700 (Sat, 23 Apr 2022)

Log Message

[buildbot] Increase the EWS compile timeout to account for delayed output from clang/XCBuild
https://bugs.webkit.org/show_bug.cgi?id=239455

Reviewed by Ryan Haddad.

Same as https://commits.webkit.org/249737@main, needed to work around
delayed output bugs in Xcode/XCBuild.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.__init__):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/249919@main

Modified Paths

Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (293293 => 293294)


--- trunk/Tools/CISupport/ews-build/steps.py	2022-04-23 20:25:12 UTC (rev 293293)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-04-23 21:13:57 UTC (rev 293294)
@@ -2295,6 +2295,9 @@
 
     def __init__(self, skipUpload=False, **kwargs):
         self.skipUpload = skipUpload
+        # https://bugs.webkit.org/show_bug.cgi?id=239455: The timeout needs to be >20 min to work
+        # around log output delays on slower machines.
+        kwargs.setdefault('timeout', 60 * 30)
         super(CompileWebKit, self).__init__(logEnviron=False, **kwargs)
 
     def doStepIf(self, step):

Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (293293 => 293294)


--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-04-23 20:25:12 UTC (rev 293293)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-04-23 21:13:57 UTC (rev 293294)
@@ -1166,6 +1166,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release'],
                         )
@@ -1181,6 +1182,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release', '--prefix=/app/webkit/WebKitBuild/release/install', '--gtk'],
                         )
@@ -1196,6 +1198,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release', '--wpe'],
                         )
@@ -1210,6 +1213,7 @@
         self.setProperty('configuration', 'debug')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
                         )
@@ -1242,6 +1246,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--release'],
                         )
@@ -1256,6 +1261,7 @@
         self.setProperty('configuration', 'debug')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
                         )
@@ -1366,6 +1372,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--release'],
                         )
@@ -1380,6 +1387,7 @@
         self.setProperty('configuration', 'debug')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
                         )
@@ -1404,6 +1412,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--release'],
                         )
@@ -1418,6 +1427,7 @@
         self.setProperty('configuration', 'debug')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=1800,
                         logEnviron=False,
                         command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
                         )

Modified: trunk/Tools/ChangeLog (293293 => 293294)


--- trunk/Tools/ChangeLog	2022-04-23 20:25:12 UTC (rev 293293)
+++ trunk/Tools/ChangeLog	2022-04-23 21:13:57 UTC (rev 293294)
@@ -1,3 +1,17 @@
+2022-04-23  Elliott Williams  <[email protected]>
+
+        [buildbot] Increase the EWS compile timeout to account for delayed output from clang/XCBuild
+        https://bugs.webkit.org/show_bug.cgi?id=239455
+
+        Reviewed by Ryan Haddad.
+
+        Same as https://commits.webkit.org/249737@main, needed to work around
+        delayed output bugs in Xcode/XCBuild.
+
+        * CISupport/ews-build/steps.py:
+        (CompileWebKit.__init__):
+        * CISupport/ews-build/steps_unittest.py:
+
 2022-04-23  Carlos Garcia Campos  <[email protected]>
 
         [ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to