Title: [293310] trunk/Source/WebKit
- Revision
- 293310
- Author
- you...@apple.com
- Date
- 2022-04-24 22:56:51 -0700 (Sun, 24 Apr 2022)
Log Message
Make NetworkResourceLoader.m_parameters non const
https://bugs.webkit.org/show_bug.cgi?id=239603
Reviewed by Anders Carlsson.
Now that NetworkResourceLoader can be transitioned through WebProcesses,
several NetworkResourceLoaderParameters might need to be changed over time.
For that reason, it no longer makes sense to have m_parameters const.
Covered by existing tests.
* NetworkProcess/NetworkLoadParameters.h:
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/NetworkResourceLoader.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (293309 => 293310)
--- trunk/Source/WebKit/ChangeLog 2022-04-25 04:45:02 UTC (rev 293309)
+++ trunk/Source/WebKit/ChangeLog 2022-04-25 05:56:51 UTC (rev 293310)
@@ -1,3 +1,20 @@
+2022-04-24 Youenn Fablet <you...@apple.com>
+
+ Make NetworkResourceLoader.m_parameters non const
+ https://bugs.webkit.org/show_bug.cgi?id=239603
+
+ Reviewed by Anders Carlsson.
+
+ Now that NetworkResourceLoader can be transitioned through WebProcesses,
+ several NetworkResourceLoaderParameters might need to be changed over time.
+ For that reason, it no longer makes sense to have m_parameters const.
+
+ Covered by existing tests.
+
+ * NetworkProcess/NetworkLoadParameters.h:
+ * NetworkProcess/NetworkResourceLoadParameters.h:
+ * NetworkProcess/NetworkResourceLoader.h:
+
2022-04-24 Daniel Kolesa <dkol...@igalia.com>
Use utf-8 for text mode files in generate-automation-atom.py
Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoadParameters.h (293309 => 293310)
--- trunk/Source/WebKit/NetworkProcess/NetworkLoadParameters.h 2022-04-25 04:45:02 UTC (rev 293309)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoadParameters.h 2022-04-25 05:56:51 UTC (rev 293310)
@@ -44,9 +44,9 @@
class NetworkLoadParameters {
public:
- mutable WebPageProxyIdentifier webPageProxyID;
- mutable WebCore::PageIdentifier webPageID;
- mutable WebCore::FrameIdentifier webFrameID;
+ WebPageProxyIdentifier webPageProxyID;
+ WebCore::PageIdentifier webPageID;
+ WebCore::FrameIdentifier webFrameID;
RefPtr<WebCore::SecurityOrigin> topOrigin;
RefPtr<WebCore::SecurityOrigin> sourceOrigin;
WTF::ProcessID parentPID { 0 };
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h (293309 => 293310)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h 2022-04-25 04:45:02 UTC (rev 293309)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h 2022-04-25 05:56:51 UTC (rev 293310)
@@ -52,11 +52,11 @@
RefPtr<WebCore::SecurityOrigin> parentOrigin() const;
- mutable WebCore::ResourceLoaderIdentifier identifier;
+ WebCore::ResourceLoaderIdentifier identifier;
Vector<RefPtr<SandboxExtension>> requestBodySandboxExtensions; // Created automatically for the sender.
RefPtr<SandboxExtension> resourceSandboxExtension; // Created automatically for the sender.
- mutable Seconds maximumBufferingTime;
- mutable WebCore::FetchOptions options;
+ Seconds maximumBufferingTime;
+ WebCore::FetchOptions options;
std::optional<WebCore::ContentSecurityPolicyResponseHeaders> cspResponseHeaders;
WebCore::CrossOriginEmbedderPolicy parentCrossOriginEmbedderPolicy;
WebCore::CrossOriginEmbedderPolicy crossOriginEmbedderPolicy;
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h (293309 => 293310)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h 2022-04-25 04:45:02 UTC (rev 293309)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h 2022-04-25 05:56:51 UTC (rev 293310)
@@ -251,7 +251,7 @@
void willSendRedirectedRequestInternal(WebCore::ResourceRequest&&, WebCore::ResourceRequest&& redirectRequest, WebCore::ResourceResponse&&, IsFromServiceWorker);
std::optional<WebCore::NetworkLoadMetrics> computeResponseMetrics(const WebCore::ResourceResponse&) const;
- const NetworkResourceLoadParameters m_parameters;
+ NetworkResourceLoadParameters m_parameters;
Ref<NetworkConnectionToWebProcess> m_connection;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
