Title: [293316] trunk
- Revision
- 293316
- Author
- [email protected]
- Date
- 2022-04-24 23:54:42 -0700 (Sun, 24 Apr 2022)
Log Message
[RISCV64] Enable Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=239708
Reviewed by Yusuke Suzuki.
.:
Turn on the CMake defaults for ENABLE(JIT) and ENABLE(FTL_JIT) options
for RISCV64. These are enabled together to avoid having to worry about
a 64-bit platform that would want to allow compiling with Baseline JIT
enabled and FTL JIT disabled at the same time. But because FTL JIT
support for RISCV64 isn't complete yet, it's still disabled at runtime.
* Source/cmake/WebKitFeatures.cmake:
Source/_javascript_Core:
* runtime/Options.cpp:
(JSC::Options::recomputeDependentOptions):
Disable FTL JIT at runtime under CPU(RISCV64) since the support is still
incomplete. This is necessary due to Baseline JIT and FTL JIT still
being enabled at build-time on this platform for pure convenience.
Modified Paths
Diff
Modified: trunk/ChangeLog (293315 => 293316)
--- trunk/ChangeLog 2022-04-25 06:41:42 UTC (rev 293315)
+++ trunk/ChangeLog 2022-04-25 06:54:42 UTC (rev 293316)
@@ -1,3 +1,18 @@
+2022-04-24 Zan Dobersek <[email protected]>
+
+ [RISCV64] Enable Baseline JIT
+ https://bugs.webkit.org/show_bug.cgi?id=239708
+
+ Reviewed by Yusuke Suzuki.
+
+ Turn on the CMake defaults for ENABLE(JIT) and ENABLE(FTL_JIT) options
+ for RISCV64. These are enabled together to avoid having to worry about
+ a 64-bit platform that would want to allow compiling with Baseline JIT
+ enabled and FTL JIT disabled at the same time. But because FTL JIT
+ support for RISCV64 isn't complete yet, it's still disabled at runtime.
+
+ * Source/cmake/WebKitFeatures.cmake:
+
2022-04-22 Alex Christensen <[email protected]>
Add my github account name
Modified: trunk/Source/_javascript_Core/ChangeLog (293315 => 293316)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-25 06:41:42 UTC (rev 293315)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-25 06:54:42 UTC (rev 293316)
@@ -1,3 +1,16 @@
+2022-04-24 Zan Dobersek <[email protected]>
+
+ [RISCV64] Enable Baseline JIT
+ https://bugs.webkit.org/show_bug.cgi?id=239708
+
+ Reviewed by Yusuke Suzuki.
+
+ * runtime/Options.cpp:
+ (JSC::Options::recomputeDependentOptions):
+ Disable FTL JIT at runtime under CPU(RISCV64) since the support is still
+ incomplete. This is necessary due to Baseline JIT and FTL JIT still
+ being enabled at build-time on this platform for pure convenience.
+
2022-04-24 Diego Pino Garcia <[email protected]>
[GCC] Unreviewed, build fix for Ubuntu LTS/Debian after r293265
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (293315 => 293316)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2022-04-25 06:41:42 UTC (rev 293315)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2022-04-25 06:54:42 UTC (rev 293316)
@@ -428,6 +428,14 @@
#if !ENABLE(FTL_JIT)
Options::useFTLJIT() = false;
#endif
+
+#if CPU(RISCV64)
+ // On RISCV64, JIT levels are enabled at build-time to simplify building JSC, avoiding
+ // otherwise rare combinations of build-time configuration. FTL on RISCV64 is disabled
+ // at runtime for now, until it gets int a proper working state.
+ // https://webkit.org/b/239707
+ Options::useFTLJIT() = false;
+#endif
#if !CPU(X86_64) && !CPU(ARM64)
Options::useConcurrentGC() = false;
Modified: trunk/Source/cmake/WebKitFeatures.cmake (293315 => 293316)
--- trunk/Source/cmake/WebKitFeatures.cmake 2022-04-25 06:41:42 UTC (rev 293315)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2022-04-25 06:54:42 UTC (rev 293316)
@@ -81,8 +81,8 @@
set(ENABLE_C_LOOP_DEFAULT OFF)
set(ENABLE_SAMPLING_PROFILER_DEFAULT OFF)
elseif (WTF_CPU_RISCV64)
- set(ENABLE_JIT_DEFAULT OFF)
- set(ENABLE_FTL_DEFAULT OFF)
+ set(ENABLE_JIT_DEFAULT ON)
+ set(ENABLE_FTL_DEFAULT ON)
set(USE_SYSTEM_MALLOC_DEFAULT OFF)
set(ENABLE_C_LOOP_DEFAULT OFF)
set(ENABLE_SAMPLING_PROFILER_DEFAULT OFF)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
