Title: [293338] trunk/Source/WebInspectorUI
- Revision
- 293338
- Author
- [email protected]
- Date
- 2022-04-25 12:54:13 -0700 (Mon, 25 Apr 2022)
Log Message
Web Inspector: response overrides with an error status code should indicate that somewhere
https://bugs.webkit.org/show_bug.cgi?id=239676
Reviewed by Patrick Angle.
* UserInterface/Views/LocalResourceOverrideTreeElement.js:
(WI.LocalResourceOverrideTreeElement.prototype.updateStatus):
Also have the `WI.LocalResourceOverrideTreeElement` add/remove the `"error"` CSS class
depening on the state of the related `WI.LocalResource` (which is what's done for "regular"
`WI.ResourceTreeElement` and `WI.Resource`).
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (293337 => 293338)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-04-25 19:09:01 UTC (rev 293337)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-04-25 19:54:13 UTC (rev 293338)
@@ -1,3 +1,16 @@
+2022-04-25 Devin Rousso <[email protected]>
+
+ Web Inspector: response overrides with an error status code should indicate that somewhere
+ https://bugs.webkit.org/show_bug.cgi?id=239676
+
+ Reviewed by Patrick Angle.
+
+ * UserInterface/Views/LocalResourceOverrideTreeElement.js:
+ (WI.LocalResourceOverrideTreeElement.prototype.updateStatus):
+ Also have the `WI.LocalResourceOverrideTreeElement` add/remove the `"error"` CSS class
+ depening on the state of the related `WI.LocalResource` (which is what's done for "regular"
+ `WI.ResourceTreeElement` and `WI.Resource`).
+
2022-04-25 Tim Nguyen <[email protected]>
Web Inspector: Unprefix CSS properties in source code
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js (293337 => 293338)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js 2022-04-25 19:09:01 UTC (rev 293337)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js 2022-04-25 19:54:13 UTC (rev 293338)
@@ -108,7 +108,12 @@
updateStatus()
{
- // Do nothing. Do not allow ResourceTreeElement / SourceCodeTreeElement to modify our status element.
+ // Don't call `super` as we don't want `WI.ResourceTreeElement` / `WI.SourceCodeTreeElement` / etc. to modify our status element.
+
+ if (this.resource.hadLoadingError())
+ this.addClassName(WI.ResourceTreeElement.FailedStyleClassName);
+ else
+ this.removeClassName(WI.ResourceTreeElement.FailedStyleClassName);
}
// Popover delegate
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
