Title: [293360] branches/safari-613.2.7.3-branch/Source/WebCore
Revision
293360
Author
alanc...@apple.com
Date
2022-04-25 14:35:40 -0700 (Mon, 25 Apr 2022)

Log Message

Cherry-pick r290860. rdar://problem/89291570

    AX: Protect incoming object with Ref in AXObjectCache::textChanged
    https://bugs.webkit.org/show_bug.cgi?id=237475

    Reviewed by Chris Fleizach.

    This is better practice as ascending the hierarchy could cause
    the object to get deleted.

    * accessibility/AXObjectCache.cpp:
    (WebCore::AXObjectCache::textChanged):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-613.2.7.3-branch/Source/WebCore/ChangeLog (293359 => 293360)


--- branches/safari-613.2.7.3-branch/Source/WebCore/ChangeLog	2022-04-25 21:35:12 UTC (rev 293359)
+++ branches/safari-613.2.7.3-branch/Source/WebCore/ChangeLog	2022-04-25 21:35:40 UTC (rev 293360)
@@ -1,3 +1,34 @@
+2022-04-25  Alan Coon  <alanc...@apple.com>
+
+        Cherry-pick r290860. rdar://problem/89291570
+
+    AX: Protect incoming object with Ref in AXObjectCache::textChanged
+    https://bugs.webkit.org/show_bug.cgi?id=237475
+    
+    Reviewed by Chris Fleizach.
+    
+    This is better practice as ascending the hierarchy could cause
+    the object to get deleted.
+    
+    * accessibility/AXObjectCache.cpp:
+    (WebCore::AXObjectCache::textChanged):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-03-04  Tyler Wilcock  <tyle...@apple.com>
+
+            AX: Protect incoming object with Ref in AXObjectCache::textChanged
+            https://bugs.webkit.org/show_bug.cgi?id=237475
+
+            Reviewed by Chris Fleizach.
+
+            This is better practice as ascending the hierarchy could cause
+            the object to get deleted.
+
+            * accessibility/AXObjectCache.cpp:
+            (WebCore::AXObjectCache::textChanged):
+
 2022-04-21  Alan Coon  <alanc...@apple.com>
 
         Cherry-pick r292095. rdar://problem/90240658

Modified: branches/safari-613.2.7.3-branch/Source/WebCore/accessibility/AXObjectCache.cpp (293359 => 293360)


--- branches/safari-613.2.7.3-branch/Source/WebCore/accessibility/AXObjectCache.cpp	2022-04-25 21:35:12 UTC (rev 293359)
+++ branches/safari-613.2.7.3-branch/Source/WebCore/accessibility/AXObjectCache.cpp	2022-04-25 21:35:40 UTC (rev 293360)
@@ -944,6 +944,7 @@
 
     if (!object)
         return;
+    Ref<AccessibilityObject> protectedObject(*object);
 
     // If this element supports ARIA live regions, or is part of a region with an ARIA editable role,
     // then notify the AT of changes.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to