Title: [293423] trunk/Tools
- Revision
- 293423
- Author
- [email protected]
- Date
- 2022-04-26 07:28:49 -0700 (Tue, 26 Apr 2022)
Log Message
[ews-build.webkit.org] Specify repository when sending emails
https://bugs.webkit.org/show_bug.cgi?id=239739
<rdar://problem/92291225>
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.should_send_email_for_pr): Pass repository URL.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.
Canonical link: https://commits.webkit.org/249983@main
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (293422 => 293423)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-26 11:01:12 UTC (rev 293422)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-26 14:28:49 UTC (rev 293423)
@@ -238,8 +238,8 @@
return 1
return 0
- def should_send_email_for_pr(self, pr_number):
- pr_json = self.get_pr_json(pr_number)
+ def should_send_email_for_pr(self, pr_number, repository_url=None):
+ pr_json = self.get_pr_json(pr_number, repository_url=repository_url)
if not pr_json:
return True
@@ -2512,7 +2512,7 @@
if patch_id and not self.should_send_email_for_patch(patch_id):
return
- if pr_number and not self.should_send_email_for_pr(pr_number):
+ if pr_number and not self.should_send_email_for_pr(pr_number, self.getProperty('repository')):
return
if not patch_id and not (pr_number and sha):
self._addToLog('stderr', 'Unrecognized change type')
@@ -3355,7 +3355,7 @@
if patch_id and not self.should_send_email_for_patch(patch_id):
return
- if pr_number and not self.should_send_email_for_pr(pr_number):
+ if pr_number and not self.should_send_email_for_pr(pr_number, self.getProperty('repository')):
return
if not patch_id and not (pr_number and sha):
self._addToLog('stderr', 'Unrecognized change type')
Modified: trunk/Tools/ChangeLog (293422 => 293423)
--- trunk/Tools/ChangeLog 2022-04-26 11:01:12 UTC (rev 293422)
+++ trunk/Tools/ChangeLog 2022-04-26 14:28:49 UTC (rev 293423)
@@ -1,3 +1,16 @@
+2022-04-25 Jonathan Bedard <[email protected]>
+
+ [ews-build.webkit.org] Specify repository when sending emails
+ https://bugs.webkit.org/show_bug.cgi?id=239739
+ <rdar://problem/92291225>
+
+ Reviewed by Aakash Jain.
+
+ * CISupport/ews-build/steps.py:
+ (GitHubMixin.should_send_email_for_pr): Pass repository URL.
+ (AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
+ (AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.
+
2022-04-25 Aditya Keerthi <[email protected]>
[iOS] Add NSCoding support for findInteractionEnabled
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
