Title: [293511] trunk
Revision
293511
Author
[email protected]
Date
2022-04-27 09:30:31 -0700 (Wed, 27 Apr 2022)

Log Message

[css-ui] Remove some unimplemented -webkit-appearance keywords
https://bugs.webkit.org/show_bug.cgi?id=238930

Reviewed by Aditya Keerthi.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Source/WebCore:

Remove the following unimplmented --webkit-appearance keyworkds:
button-bevel
media-controls-background
media-controls-fullscreen-background
media-current-time-display
media-enter-fullscreen-button
media-exit-fullscreen-button
media-mute-button
media-overlay-play-button
media-return-to-realtime-button
media-rewind-button
media-seek-back-button
media-seek-forward-button
media-time-remaining-display
media-toggle-closed-captions-button
media-volume-slider-container
menulist-textfield
menulist-text

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSProperties.json:
* css/CSSValueKeywords.in:
* platform/ThemeTypes.cpp:
(WebCore::operator<<):
* platform/ThemeTypes.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaPlayButton):
(WebCore::RenderTheme::paintMediaMuteButton):
(WebCore::RenderTheme::paintMediaSliderThumb):
(WebCore::RenderTheme::paintMediaVolumeSliderThumb):
(WebCore::RenderTheme::paintMediaFullscreenButton): Deleted.
(WebCore::RenderTheme::paintMediaOverlayPlayButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekBackButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekForwardButton): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderContainer): Deleted.
(WebCore::RenderTheme::paintMediaRewindButton): Deleted.
(WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Deleted.
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): Deleted.
(WebCore::RenderTheme::paintMediaControlsBackground): Deleted.
(WebCore::RenderTheme::paintMediaCurrentTime): Deleted.
(WebCore::RenderTheme::paintMediaTimeRemaining): Deleted.

Source/WebInspectorUI:

We might need to update the changes on UserInterface/External/CodeMirror/css.js since
PR https://github.com/codemirror/CodeMirror/pull/6912 has been merged in CodeMirror.

* UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
* UserInterface/External/CSSDocumentation/CSSDocumentation.js:

LayoutTests:

* imported/blink/editing/execCommand/outdent-collapse-table-crash.html:
* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (293510 => 293511)


--- trunk/LayoutTests/ChangeLog	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/LayoutTests/ChangeLog	2022-04-27 16:30:31 UTC (rev 293511)
@@ -1,3 +1,14 @@
+2022-04-27  Ziran Sun  <[email protected]>
+
+        [css-ui] Remove some unimplemented -webkit-appearance keywords
+        https://bugs.webkit.org/show_bug.cgi?id=238930
+
+        Reviewed by Aditya Keerthi.
+
+        * imported/blink/editing/execCommand/outdent-collapse-table-crash.html:
+        * platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+        * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+
 2022-04-27  Youenn Fablet  <[email protected]>
 
         Add testRunner API to clear memory cache

Modified: trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html (293510 => 293511)


--- trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html	2022-04-27 16:30:31 UTC (rev 293511)
@@ -3,7 +3,6 @@
 <head>
 <style>
 * {
-    -webkit-appearance: media-controls-background;
     display: table-footer-group;
     visibility: visible;
 }

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293510 => 293511)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-04-27 16:30:31 UTC (rev 293511)
@@ -1,3 +1,12 @@
+2022-04-27  Ziran Sun  <[email protected]>
+
+        [css-ui] Remove some unimplemented -webkit-appearance keywords
+        https://bugs.webkit.org/show_bug.cgi?id=238930
+
+        Reviewed by Aditya Keerthi.
+
+        * web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+
 2022-04-27  Youenn Fablet  <[email protected]>
 
         service worker update should refresh imported scripts in addition to the main script

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (293510 => 293511)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt	2022-04-27 16:30:31 UTC (rev 293511)
@@ -18,7 +18,7 @@
 PASS -webkit-appearance: textfield
 PASS -webkit-appearance: bogus-button (invalid)
 FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment"
-FAIL -webkit-appearance: button-bevel (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "button-bevel"
+PASS -webkit-appearance: button-bevel (invalid)
 FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment"
 PASS -webkit-appearance: button-arrow-down (invalid)
 PASS -webkit-appearance: button-arrow-next (invalid)
@@ -40,28 +40,28 @@
 FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
 FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
 FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
-FAIL -webkit-appearance: media-controls-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-background"
+PASS -webkit-appearance: media-controls-background (invalid)
 FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
-FAIL -webkit-appearance: media-controls-fullscreen-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-fullscreen-background"
+PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
 FAIL -webkit-appearance: media-controls-light-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-light-bar-background"
-FAIL -webkit-appearance: media-current-time-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-current-time-display"
-FAIL -webkit-appearance: media-enter-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-enter-fullscreen-button"
-FAIL -webkit-appearance: media-exit-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-exit-fullscreen-button"
+PASS -webkit-appearance: media-current-time-display (invalid)
+PASS -webkit-appearance: media-enter-fullscreen-button (invalid)
+PASS -webkit-appearance: media-exit-fullscreen-button (invalid)
 FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider"
 FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb"
-FAIL -webkit-appearance: media-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-mute-button"
-FAIL -webkit-appearance: media-overlay-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-overlay-play-button"
+PASS -webkit-appearance: media-mute-button (invalid)
+PASS -webkit-appearance: media-overlay-play-button (invalid)
 FAIL -webkit-appearance: media-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-play-button"
-FAIL -webkit-appearance: media-return-to-realtime-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-return-to-realtime-button"
-FAIL -webkit-appearance: media-rewind-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-rewind-button"
-FAIL -webkit-appearance: media-seek-back-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-back-button"
-FAIL -webkit-appearance: media-seek-forward-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-forward-button"
+PASS -webkit-appearance: media-return-to-realtime-button (invalid)
+PASS -webkit-appearance: media-rewind-button (invalid)
+PASS -webkit-appearance: media-seek-back-button (invalid)
+PASS -webkit-appearance: media-seek-forward-button (invalid)
 FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider"
 FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb"
-FAIL -webkit-appearance: media-time-remaining-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-time-remaining-display"
-FAIL -webkit-appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-toggle-closed-captions-button"
+PASS -webkit-appearance: media-time-remaining-display (invalid)
+PASS -webkit-appearance: media-toggle-closed-captions-button (invalid)
 FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider"
-FAIL -webkit-appearance: media-volume-slider-container (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-container"
+PASS -webkit-appearance: media-volume-slider-container (invalid)
 FAIL -webkit-appearance: media-volume-slider-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-mute-button"
 FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb"
 PASS -webkit-appearance: menuarrow (invalid)
@@ -70,8 +70,8 @@
 PASS -webkit-appearance: menuimage (invalid)
 PASS -webkit-appearance: menuitem (invalid)
 PASS -webkit-appearance: menuitemtext (invalid)
-FAIL -webkit-appearance: menulist-text (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-text"
-FAIL -webkit-appearance: menulist-textfield (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-textfield"
+PASS -webkit-appearance: menulist-text (invalid)
+PASS -webkit-appearance: menulist-textfield (invalid)
 PASS -webkit-appearance: menupopup (invalid)
 PASS -webkit-appearance: menuradio (invalid)
 PASS -webkit-appearance: menuseparator (invalid)
@@ -181,7 +181,7 @@
 PASS appearance: textfield
 PASS appearance: bogus-button (invalid)
 FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment"
-FAIL appearance: button-bevel (invalid) assert_equals: style.appearance expected "" but got "button-bevel"
+PASS appearance: button-bevel (invalid)
 FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment"
 PASS appearance: button-arrow-down (invalid)
 PASS appearance: button-arrow-next (invalid)
@@ -203,28 +203,28 @@
 FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
 FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
 FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
-FAIL appearance: media-controls-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-background"
+PASS appearance: media-controls-background (invalid)
 FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
-FAIL appearance: media-controls-fullscreen-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-fullscreen-background"
+PASS appearance: media-controls-fullscreen-background (invalid)
 FAIL appearance: media-controls-light-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-light-bar-background"
-FAIL appearance: media-current-time-display (invalid) assert_equals: style.appearance expected "" but got "media-current-time-display"
-FAIL appearance: media-enter-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-enter-fullscreen-button"
-FAIL appearance: media-exit-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-exit-fullscreen-button"
+PASS appearance: media-current-time-display (invalid)
+PASS appearance: media-enter-fullscreen-button (invalid)
+PASS appearance: media-exit-fullscreen-button (invalid)
 FAIL appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider"
 FAIL appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider-thumb"
-FAIL appearance: media-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-mute-button"
-FAIL appearance: media-overlay-play-button (invalid) assert_equals: style.appearance expected "" but got "media-overlay-play-button"
+PASS appearance: media-mute-button (invalid)
+PASS appearance: media-overlay-play-button (invalid)
 FAIL appearance: media-play-button (invalid) assert_equals: style.appearance expected "" but got "media-play-button"
-FAIL appearance: media-return-to-realtime-button (invalid) assert_equals: style.appearance expected "" but got "media-return-to-realtime-button"
-FAIL appearance: media-rewind-button (invalid) assert_equals: style.appearance expected "" but got "media-rewind-button"
-FAIL appearance: media-seek-back-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-back-button"
-FAIL appearance: media-seek-forward-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-forward-button"
+PASS appearance: media-return-to-realtime-button (invalid)
+PASS appearance: media-rewind-button (invalid)
+PASS appearance: media-seek-back-button (invalid)
+PASS appearance: media-seek-forward-button (invalid)
 FAIL appearance: media-slider (invalid) assert_equals: style.appearance expected "" but got "media-slider"
 FAIL appearance: media-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-sliderthumb"
-FAIL appearance: media-time-remaining-display (invalid) assert_equals: style.appearance expected "" but got "media-time-remaining-display"
-FAIL appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.appearance expected "" but got "media-toggle-closed-captions-button"
+PASS appearance: media-time-remaining-display (invalid)
+PASS appearance: media-toggle-closed-captions-button (invalid)
 FAIL appearance: media-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider"
-FAIL appearance: media-volume-slider-container (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-container"
+PASS appearance: media-volume-slider-container (invalid)
 FAIL appearance: media-volume-slider-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-mute-button"
 FAIL appearance: media-volume-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-volume-sliderthumb"
 PASS appearance: menuarrow (invalid)
@@ -233,8 +233,8 @@
 PASS appearance: menuimage (invalid)
 PASS appearance: menuitem (invalid)
 PASS appearance: menuitemtext (invalid)
-FAIL appearance: menulist-text (invalid) assert_equals: style.appearance expected "" but got "menulist-text"
-FAIL appearance: menulist-textfield (invalid) assert_equals: style.appearance expected "" but got "menulist-textfield"
+PASS appearance: menulist-text (invalid)
+PASS appearance: menulist-textfield (invalid)
 PASS appearance: menupopup (invalid)
 PASS appearance: menuradio (invalid)
 PASS appearance: menuseparator (invalid)

Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (293510 => 293511)


--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt	2022-04-27 16:30:31 UTC (rev 293511)
@@ -18,7 +18,7 @@
 PASS -webkit-appearance: textfield
 PASS -webkit-appearance: bogus-button (invalid)
 PASS -webkit-appearance: attachment (invalid)
-FAIL -webkit-appearance: button-bevel (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "button-bevel"
+PASS -webkit-appearance: button-bevel (invalid)
 PASS -webkit-appearance: borderless-attachment (invalid)
 PASS -webkit-appearance: button-arrow-down (invalid)
 PASS -webkit-appearance: button-arrow-next (invalid)
@@ -40,28 +40,28 @@
 FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
 FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
 FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
-FAIL -webkit-appearance: media-controls-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-background"
+PASS -webkit-appearance: media-controls-background (invalid)
 FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
-FAIL -webkit-appearance: media-controls-fullscreen-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-fullscreen-background"
+PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
 FAIL -webkit-appearance: media-controls-light-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-light-bar-background"
-FAIL -webkit-appearance: media-current-time-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-current-time-display"
-FAIL -webkit-appearance: media-enter-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-enter-fullscreen-button"
-FAIL -webkit-appearance: media-exit-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-exit-fullscreen-button"
+PASS -webkit-appearance: media-current-time-display (invalid)
+PASS -webkit-appearance: media-enter-fullscreen-button (invalid)
+PASS -webkit-appearance: media-exit-fullscreen-button (invalid)
 FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider"
 FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb"
-FAIL -webkit-appearance: media-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-mute-button"
-FAIL -webkit-appearance: media-overlay-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-overlay-play-button"
+PASS -webkit-appearance: media-mute-button (invalid)
+PASS -webkit-appearance: media-overlay-play-button (invalid)
 FAIL -webkit-appearance: media-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-play-button"
-FAIL -webkit-appearance: media-return-to-realtime-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-return-to-realtime-button"
-FAIL -webkit-appearance: media-rewind-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-rewind-button"
-FAIL -webkit-appearance: media-seek-back-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-back-button"
-FAIL -webkit-appearance: media-seek-forward-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-forward-button"
+PASS -webkit-appearance: media-return-to-realtime-button (invalid)
+PASS -webkit-appearance: media-rewind-button (invalid)
+PASS -webkit-appearance: media-seek-back-button (invalid)
+PASS -webkit-appearance: media-seek-forward-button (invalid)
 FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider"
 FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb"
-FAIL -webkit-appearance: media-time-remaining-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-time-remaining-display"
-FAIL -webkit-appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-toggle-closed-captions-button"
+PASS -webkit-appearance: media-time-remaining-display (invalid)
+PASS -webkit-appearance: media-toggle-closed-captions-button (invalid)
 FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider"
-FAIL -webkit-appearance: media-volume-slider-container (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-container"
+PASS -webkit-appearance: media-volume-slider-container (invalid)
 FAIL -webkit-appearance: media-volume-slider-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-mute-button"
 FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb"
 PASS -webkit-appearance: menuarrow (invalid)
@@ -70,8 +70,8 @@
 PASS -webkit-appearance: menuimage (invalid)
 PASS -webkit-appearance: menuitem (invalid)
 PASS -webkit-appearance: menuitemtext (invalid)
-FAIL -webkit-appearance: menulist-text (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-text"
-FAIL -webkit-appearance: menulist-textfield (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-textfield"
+PASS -webkit-appearance: menulist-text (invalid)
+PASS -webkit-appearance: menulist-textfield (invalid)
 PASS -webkit-appearance: menupopup (invalid)
 PASS -webkit-appearance: menuradio (invalid)
 PASS -webkit-appearance: menuseparator (invalid)
@@ -181,7 +181,7 @@
 PASS appearance: textfield
 PASS appearance: bogus-button (invalid)
 PASS appearance: attachment (invalid)
-FAIL appearance: button-bevel (invalid) assert_equals: style.appearance expected "" but got "button-bevel"
+PASS appearance: button-bevel (invalid)
 PASS appearance: borderless-attachment (invalid)
 PASS appearance: button-arrow-down (invalid)
 PASS appearance: button-arrow-next (invalid)
@@ -203,28 +203,28 @@
 FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
 FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
 FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
-FAIL appearance: media-controls-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-background"
+PASS appearance: media-controls-background (invalid)
 FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
-FAIL appearance: media-controls-fullscreen-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-fullscreen-background"
+PASS appearance: media-controls-fullscreen-background (invalid)
 FAIL appearance: media-controls-light-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-light-bar-background"
-FAIL appearance: media-current-time-display (invalid) assert_equals: style.appearance expected "" but got "media-current-time-display"
-FAIL appearance: media-enter-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-enter-fullscreen-button"
-FAIL appearance: media-exit-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-exit-fullscreen-button"
+PASS appearance: media-current-time-display (invalid)
+PASS appearance: media-enter-fullscreen-button (invalid)
+PASS appearance: media-exit-fullscreen-button (invalid)
 FAIL appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider"
 FAIL appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider-thumb"
-FAIL appearance: media-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-mute-button"
-FAIL appearance: media-overlay-play-button (invalid) assert_equals: style.appearance expected "" but got "media-overlay-play-button"
+PASS appearance: media-mute-button (invalid)
+PASS appearance: media-overlay-play-button (invalid)
 FAIL appearance: media-play-button (invalid) assert_equals: style.appearance expected "" but got "media-play-button"
-FAIL appearance: media-return-to-realtime-button (invalid) assert_equals: style.appearance expected "" but got "media-return-to-realtime-button"
-FAIL appearance: media-rewind-button (invalid) assert_equals: style.appearance expected "" but got "media-rewind-button"
-FAIL appearance: media-seek-back-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-back-button"
-FAIL appearance: media-seek-forward-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-forward-button"
+PASS appearance: media-return-to-realtime-button (invalid)
+PASS appearance: media-rewind-button (invalid)
+PASS appearance: media-seek-back-button (invalid)
+PASS appearance: media-seek-forward-button (invalid)
 FAIL appearance: media-slider (invalid) assert_equals: style.appearance expected "" but got "media-slider"
 FAIL appearance: media-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-sliderthumb"
-FAIL appearance: media-time-remaining-display (invalid) assert_equals: style.appearance expected "" but got "media-time-remaining-display"
-FAIL appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.appearance expected "" but got "media-toggle-closed-captions-button"
+PASS appearance: media-time-remaining-display (invalid)
+PASS appearance: media-toggle-closed-captions-button (invalid)
 FAIL appearance: media-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider"
-FAIL appearance: media-volume-slider-container (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-container"
+PASS appearance: media-volume-slider-container (invalid)
 FAIL appearance: media-volume-slider-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-mute-button"
 FAIL appearance: media-volume-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-volume-sliderthumb"
 PASS appearance: menuarrow (invalid)
@@ -233,8 +233,8 @@
 PASS appearance: menuimage (invalid)
 PASS appearance: menuitem (invalid)
 PASS appearance: menuitemtext (invalid)
-FAIL appearance: menulist-text (invalid) assert_equals: style.appearance expected "" but got "menulist-text"
-FAIL appearance: menulist-textfield (invalid) assert_equals: style.appearance expected "" but got "menulist-textfield"
+PASS appearance: menulist-text (invalid)
+PASS appearance: menulist-textfield (invalid)
 PASS appearance: menupopup (invalid)
 PASS appearance: menuradio (invalid)
 PASS appearance: menuseparator (invalid)

Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (293510 => 293511)


--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt	2022-04-27 16:30:31 UTC (rev 293511)
@@ -18,7 +18,7 @@
 PASS -webkit-appearance: textfield
 PASS -webkit-appearance: bogus-button (invalid)
 FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment"
-FAIL -webkit-appearance: button-bevel (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "button-bevel"
+PASS -webkit-appearance: button-bevel (invalid)
 FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment"
 PASS -webkit-appearance: button-arrow-down (invalid)
 PASS -webkit-appearance: button-arrow-next (invalid)
@@ -40,28 +40,28 @@
 FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
 FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
 FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
-FAIL -webkit-appearance: media-controls-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-background"
+PASS -webkit-appearance: media-controls-background (invalid)
 FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
-FAIL -webkit-appearance: media-controls-fullscreen-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-fullscreen-background"
+PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
 FAIL -webkit-appearance: media-controls-light-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-light-bar-background"
-FAIL -webkit-appearance: media-current-time-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-current-time-display"
-FAIL -webkit-appearance: media-enter-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-enter-fullscreen-button"
-FAIL -webkit-appearance: media-exit-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-exit-fullscreen-button"
+PASS -webkit-appearance: media-current-time-display (invalid)
+PASS -webkit-appearance: media-enter-fullscreen-button (invalid)
+PASS -webkit-appearance: media-exit-fullscreen-button (invalid)
 FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider"
 FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb"
-FAIL -webkit-appearance: media-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-mute-button"
-FAIL -webkit-appearance: media-overlay-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-overlay-play-button"
+PASS -webkit-appearance: media-mute-button (invalid)
+PASS -webkit-appearance: media-overlay-play-button (invalid)
 FAIL -webkit-appearance: media-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-play-button"
-FAIL -webkit-appearance: media-return-to-realtime-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-return-to-realtime-button"
-FAIL -webkit-appearance: media-rewind-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-rewind-button"
-FAIL -webkit-appearance: media-seek-back-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-back-button"
-FAIL -webkit-appearance: media-seek-forward-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-forward-button"
+PASS -webkit-appearance: media-return-to-realtime-button (invalid)
+PASS -webkit-appearance: media-rewind-button (invalid)
+PASS -webkit-appearance: media-seek-back-button (invalid)
+PASS -webkit-appearance: media-seek-forward-button (invalid)
 FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider"
 FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb"
-FAIL -webkit-appearance: media-time-remaining-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-time-remaining-display"
-FAIL -webkit-appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-toggle-closed-captions-button"
+PASS -webkit-appearance: media-time-remaining-display (invalid)
+PASS -webkit-appearance: media-toggle-closed-captions-button (invalid)
 FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider"
-FAIL -webkit-appearance: media-volume-slider-container (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-container"
+PASS -webkit-appearance: media-volume-slider-container (invalid)
 FAIL -webkit-appearance: media-volume-slider-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-mute-button"
 FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb"
 PASS -webkit-appearance: menuarrow (invalid)
@@ -70,8 +70,8 @@
 PASS -webkit-appearance: menuimage (invalid)
 PASS -webkit-appearance: menuitem (invalid)
 PASS -webkit-appearance: menuitemtext (invalid)
-FAIL -webkit-appearance: menulist-text (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-text"
-FAIL -webkit-appearance: menulist-textfield (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-textfield"
+PASS -webkit-appearance: menulist-text (invalid)
+PASS -webkit-appearance: menulist-textfield (invalid)
 PASS -webkit-appearance: menupopup (invalid)
 PASS -webkit-appearance: menuradio (invalid)
 PASS -webkit-appearance: menuseparator (invalid)
@@ -181,7 +181,7 @@
 PASS appearance: textfield
 PASS appearance: bogus-button (invalid)
 FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment"
-FAIL appearance: button-bevel (invalid) assert_equals: style.appearance expected "" but got "button-bevel"
+PASS appearance: button-bevel (invalid)
 FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment"
 PASS appearance: button-arrow-down (invalid)
 PASS appearance: button-arrow-next (invalid)
@@ -203,28 +203,28 @@
 FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
 FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
 FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
-FAIL appearance: media-controls-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-background"
+PASS appearance: media-controls-background (invalid)
 FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
-FAIL appearance: media-controls-fullscreen-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-fullscreen-background"
+PASS appearance: media-controls-fullscreen-background (invalid)
 FAIL appearance: media-controls-light-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-light-bar-background"
-FAIL appearance: media-current-time-display (invalid) assert_equals: style.appearance expected "" but got "media-current-time-display"
-FAIL appearance: media-enter-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-enter-fullscreen-button"
-FAIL appearance: media-exit-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-exit-fullscreen-button"
+PASS appearance: media-current-time-display (invalid)
+PASS appearance: media-enter-fullscreen-button (invalid)
+PASS appearance: media-exit-fullscreen-button (invalid)
 FAIL appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider"
 FAIL appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider-thumb"
-FAIL appearance: media-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-mute-button"
-FAIL appearance: media-overlay-play-button (invalid) assert_equals: style.appearance expected "" but got "media-overlay-play-button"
+PASS appearance: media-mute-button (invalid)
+PASS appearance: media-overlay-play-button (invalid)
 FAIL appearance: media-play-button (invalid) assert_equals: style.appearance expected "" but got "media-play-button"
-FAIL appearance: media-return-to-realtime-button (invalid) assert_equals: style.appearance expected "" but got "media-return-to-realtime-button"
-FAIL appearance: media-rewind-button (invalid) assert_equals: style.appearance expected "" but got "media-rewind-button"
-FAIL appearance: media-seek-back-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-back-button"
-FAIL appearance: media-seek-forward-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-forward-button"
+PASS appearance: media-return-to-realtime-button (invalid)
+PASS appearance: media-rewind-button (invalid)
+PASS appearance: media-seek-back-button (invalid)
+PASS appearance: media-seek-forward-button (invalid)
 FAIL appearance: media-slider (invalid) assert_equals: style.appearance expected "" but got "media-slider"
 FAIL appearance: media-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-sliderthumb"
-FAIL appearance: media-time-remaining-display (invalid) assert_equals: style.appearance expected "" but got "media-time-remaining-display"
-FAIL appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.appearance expected "" but got "media-toggle-closed-captions-button"
+PASS appearance: media-time-remaining-display (invalid)
+PASS appearance: media-toggle-closed-captions-button (invalid)
 FAIL appearance: media-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider"
-FAIL appearance: media-volume-slider-container (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-container"
+PASS appearance: media-volume-slider-container (invalid)
 FAIL appearance: media-volume-slider-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-mute-button"
 FAIL appearance: media-volume-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-volume-sliderthumb"
 PASS appearance: menuarrow (invalid)
@@ -233,8 +233,8 @@
 PASS appearance: menuimage (invalid)
 PASS appearance: menuitem (invalid)
 PASS appearance: menuitemtext (invalid)
-FAIL appearance: menulist-text (invalid) assert_equals: style.appearance expected "" but got "menulist-text"
-FAIL appearance: menulist-textfield (invalid) assert_equals: style.appearance expected "" but got "menulist-textfield"
+PASS appearance: menulist-text (invalid)
+PASS appearance: menulist-textfield (invalid)
 PASS appearance: menupopup (invalid)
 PASS appearance: menuradio (invalid)
 PASS appearance: menuseparator (invalid)

Modified: trunk/Source/WebCore/ChangeLog (293510 => 293511)


--- trunk/Source/WebCore/ChangeLog	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/ChangeLog	2022-04-27 16:30:31 UTC (rev 293511)
@@ -1,3 +1,56 @@
+2022-04-27  Ziran Sun  <[email protected]>
+
+        [css-ui] Remove some unimplemented -webkit-appearance keywords
+        https://bugs.webkit.org/show_bug.cgi?id=238930
+
+        Reviewed by Aditya Keerthi.
+
+        Remove the following unimplmented --webkit-appearance keyworkds:
+        button-bevel
+        media-controls-background
+        media-controls-fullscreen-background
+        media-current-time-display
+        media-enter-fullscreen-button
+        media-exit-fullscreen-button
+        media-mute-button
+        media-overlay-play-button
+        media-return-to-realtime-button
+        media-rewind-button
+        media-seek-back-button
+        media-seek-forward-button
+        media-time-remaining-display
+        media-toggle-closed-captions-button
+        media-volume-slider-container
+        menulist-textfield
+        menulist-text
+
+        * css/CSSPrimitiveValueMappings.h:
+        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+        * css/CSSProperties.json:
+        * css/CSSValueKeywords.in:
+        * platform/ThemeTypes.cpp:
+        (WebCore::operator<<):
+        * platform/ThemeTypes.h:
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::adjustStyle):
+        (WebCore::RenderTheme::paint):
+        * rendering/RenderTheme.h:
+        (WebCore::RenderTheme::paintMediaPlayButton):
+        (WebCore::RenderTheme::paintMediaMuteButton):
+        (WebCore::RenderTheme::paintMediaSliderThumb):
+        (WebCore::RenderTheme::paintMediaVolumeSliderThumb):
+        (WebCore::RenderTheme::paintMediaFullscreenButton): Deleted.
+        (WebCore::RenderTheme::paintMediaOverlayPlayButton): Deleted.
+        (WebCore::RenderTheme::paintMediaSeekBackButton): Deleted.
+        (WebCore::RenderTheme::paintMediaSeekForwardButton): Deleted.
+        (WebCore::RenderTheme::paintMediaVolumeSliderContainer): Deleted.
+        (WebCore::RenderTheme::paintMediaRewindButton): Deleted.
+        (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Deleted.
+        (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): Deleted.
+        (WebCore::RenderTheme::paintMediaControlsBackground): Deleted.
+        (WebCore::RenderTheme::paintMediaCurrentTime): Deleted.
+        (WebCore::RenderTheme::paintMediaTimeRemaining): Deleted.
+
 2022-04-27  Youenn Fablet  <[email protected]>
 
         service worker update should refresh imported scripts in addition to the main script

Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (293510 => 293511)


--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2022-04-27 16:30:31 UTC (rev 293511)
@@ -466,9 +466,6 @@
     case ButtonPart:
         m_value.valueID = CSSValueButton;
         break;
-    case ButtonBevelPart:
-        m_value.valueID = CSSValueButtonBevel;
-        break;
     case DefaultButtonPart:
         m_value.valueID = CSSValueDefaultButton;
         break;
@@ -481,36 +478,9 @@
     case ListItemPart:
         m_value.valueID = CSSValueListitem;
         break;
-    case MediaEnterFullscreenButtonPart:
-        m_value.valueID = CSSValueMediaEnterFullscreenButton;
-        break;
-    case MediaExitFullscreenButtonPart:
-        m_value.valueID = CSSValueMediaExitFullscreenButton;
-        break;
     case MediaPlayButtonPart:
         m_value.valueID = CSSValueMediaPlayButton;
         break;
-    case MediaOverlayPlayButtonPart:
-        m_value.valueID = CSSValueMediaOverlayPlayButton;
-        break;
-    case MediaMuteButtonPart:
-        m_value.valueID = CSSValueMediaMuteButton;
-        break;
-    case MediaSeekBackButtonPart:
-        m_value.valueID = CSSValueMediaSeekBackButton;
-        break;
-    case MediaSeekForwardButtonPart:
-        m_value.valueID = CSSValueMediaSeekForwardButton;
-        break;
-    case MediaRewindButtonPart:
-        m_value.valueID = CSSValueMediaRewindButton;
-        break;
-    case MediaReturnToRealtimeButtonPart:
-        m_value.valueID = CSSValueMediaReturnToRealtimeButton;
-        break;
-    case MediaToggleClosedCaptionsButtonPart:
-        m_value.valueID = CSSValueMediaToggleClosedCaptionsButton;
-        break;
     case MediaSliderPart:
         m_value.valueID = CSSValueMediaSlider;
         break;
@@ -517,9 +487,6 @@
     case MediaSliderThumbPart:
         m_value.valueID = CSSValueMediaSliderthumb;
         break;
-    case MediaVolumeSliderContainerPart:
-        m_value.valueID = CSSValueMediaVolumeSliderContainer;
-        break;
     case MediaVolumeSliderPart:
         m_value.valueID = CSSValueMediaVolumeSlider;
         break;
@@ -528,13 +495,7 @@
         break;
     case MediaVolumeSliderThumbPart:
         m_value.valueID = CSSValueMediaVolumeSliderthumb;
-        break;
-    case MediaControlsBackgroundPart:
-        m_value.valueID = CSSValueMediaControlsBackground;
-        break;
-    case MediaControlsFullscreenBackgroundPart:
-        m_value.valueID = CSSValueMediaControlsFullscreenBackground;
-        break;
+        break;    
     case MediaFullScreenVolumeSliderPart:
         m_value.valueID = CSSValueMediaFullscreenVolumeSlider;
         break;
@@ -541,12 +502,6 @@
     case MediaFullScreenVolumeSliderThumbPart:
         m_value.valueID = CSSValueMediaFullscreenVolumeSliderThumb;
         break;
-    case MediaCurrentTimePart:
-        m_value.valueID = CSSValueMediaCurrentTimeDisplay;
-        break;
-    case MediaTimeRemainingPart:
-        m_value.valueID = CSSValueMediaTimeRemainingDisplay;
-        break;
     case MediaControlsLightBarBackgroundPart:
         m_value.valueID = CSSValueMediaControlsLightBarBackground;
         break;
@@ -559,12 +514,6 @@
     case MenulistButtonPart:
         m_value.valueID = CSSValueMenulistButton;
         break;
-    case MenulistTextPart:
-        m_value.valueID = CSSValueMenulistText;
-        break;
-    case MenulistTextFieldPart:
-        m_value.valueID = CSSValueMenulistTextfield;
-        break;
     case MeterPart:
         m_value.valueID = CSSValueMeter;
         break;

Modified: trunk/Source/WebCore/css/CSSProperties.json (293510 => 293511)


--- trunk/Source/WebCore/css/CSSProperties.json	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/css/CSSProperties.json	2022-04-27 16:30:31 UTC (rev 293511)
@@ -5156,39 +5156,22 @@
                 "push-button",
                 "square-button",
                 "button",
-                "button-bevel",
                 "default-button",
                 "inner-spin-button",
                 "listbox",
                 "listitem",
-                "media-controls-background",
                 "media-controls-dark-bar-background",
-                "media-controls-fullscreen-background",
                 "media-controls-light-bar-background",
-                "media-current-time-display",
-                "media-enter-fullscreen-button",
-                "media-exit-fullscreen-button",
                 "media-fullscreen-volume-slider",
                 "media-fullscreen-volume-slider-thumb",
-                "media-mute-button",
-                "media-overlay-play-button",
                 "media-play-button",
-                "media-return-to-realtime-button",
-                "media-rewind-button",
-                "media-seek-back-button",
-                "media-seek-forward-button",
                 "media-slider",
                 "media-sliderthumb",
-                "media-time-remaining-display",
-                "media-toggle-closed-captions-button",
                 "media-volume-slider",
-                "media-volume-slider-container",
                 "media-volume-slider-mute-button",
                 "media-volume-sliderthumb",
                 "menulist",
                 "menulist-button",
-                "menulist-text",
-                "menulist-textfield",
                 "meter",
                 "progress-bar",
                 "progress-bar-value",

Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (293510 => 293511)


--- trunk/Source/WebCore/css/CSSValueKeywords.in	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in	2022-04-27 16:30:31 UTC (rev 293511)
@@ -839,39 +839,22 @@
 push-button
 square-button
 button
-button-bevel
 default-button
 inner-spin-button
 listbox
 listitem
-media-controls-background
 media-controls-dark-bar-background
-media-controls-fullscreen-background
 media-controls-light-bar-background
-media-current-time-display
-media-enter-fullscreen-button
-media-exit-fullscreen-button
 media-fullscreen-volume-slider
 media-fullscreen-volume-slider-thumb
-media-mute-button
-media-overlay-play-button
 media-play-button
-media-return-to-realtime-button
-media-rewind-button
-media-seek-back-button
-media-seek-forward-button
 media-slider
 media-sliderthumb
-media-time-remaining-display
-media-toggle-closed-captions-button
 media-volume-slider
-media-volume-slider-container
 media-volume-slider-mute-button
 media-volume-sliderthumb
 menulist
 menulist-button
-menulist-text
-menulist-textfield
 meter
 progress-bar
 progress-bar-value

Modified: trunk/Source/WebCore/platform/ThemeTypes.cpp (293510 => 293511)


--- trunk/Source/WebCore/platform/ThemeTypes.cpp	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/platform/ThemeTypes.cpp	2022-04-27 16:30:31 UTC (rev 293511)
@@ -40,39 +40,22 @@
     case PushButtonPart: ts << "push-button-part"; break;
     case SquareButtonPart: ts << "square-button-part"; break;
     case ButtonPart: ts << "button-part"; break;
-    case ButtonBevelPart: ts << "button-bevel-part"; break;
     case DefaultButtonPart: ts << "default-button-part"; break;
     case InnerSpinButtonPart: ts << "inner-spin-button-part"; break;
     case ListboxPart: ts << "listbox-part"; break;
     case ListItemPart: ts << "list-item-part"; break;
-    case MediaControlsBackgroundPart: ts << "media-controls-background-part"; break;
     case MediaControlsDarkBarBackgroundPart: ts << "media-controls-dark-bar-background-part"; break;
-    case MediaControlsFullscreenBackgroundPart: ts << "media-controls-fullscreen-background-part"; break;
     case MediaControlsLightBarBackgroundPart: ts << "media-controls-light-bar-background-part"; break;
-    case MediaCurrentTimePart: ts << "media-current-time-part"; break;
-    case MediaEnterFullscreenButtonPart: ts << "media-enter-fullscreen-button-part"; break;
-    case MediaExitFullscreenButtonPart: ts << "media-exit-fullscreen-button-part"; break;
     case MediaFullScreenVolumeSliderPart: ts << "media-full-screen-volume-slider-part"; break;
     case MediaFullScreenVolumeSliderThumbPart: ts << "media-full-screen-volume-slider-thumb-part"; break;
-    case MediaMuteButtonPart: ts << "media-mute-button-part"; break;
-    case MediaOverlayPlayButtonPart: ts << "media-overlay-play-button-part"; break;
     case MediaPlayButtonPart: ts << "media-play-button-part"; break;
-    case MediaReturnToRealtimeButtonPart: ts << "media-return-to-realtime-button-part"; break;
-    case MediaRewindButtonPart: ts << "media-rewind-button-part"; break;
-    case MediaSeekBackButtonPart: ts << "media-seek-back-button-part"; break;
-    case MediaSeekForwardButtonPart: ts << "media-seek-forward-button-part"; break;
     case MediaSliderPart: ts << "media-slider-part"; break;
     case MediaSliderThumbPart: ts << "media-slider-thumb-part"; break;
-    case MediaTimeRemainingPart: ts << "media-time-remaining-part"; break;
-    case MediaToggleClosedCaptionsButtonPart: ts << "media-toggle-closed-captions-button-part"; break;
     case MediaVolumeSliderPart: ts << "media-volume-slider-part"; break;
-    case MediaVolumeSliderContainerPart: ts << "media-volume-slider-container-part"; break;
     case MediaVolumeSliderMuteButtonPart: ts << "media-volume-slider-mute-button-part"; break;
     case MediaVolumeSliderThumbPart: ts << "media-volume-slider-thumb-part"; break;
     case MenulistPart: ts << "menulist-part"; break;
     case MenulistButtonPart: ts << "menulist-button-part"; break;
-    case MenulistTextPart: ts << "menulist-text-part"; break;
-    case MenulistTextFieldPart: ts << "menulist-text-field-part"; break;
     case MeterPart: ts << "meter-part"; break;
     case ProgressBarPart: ts << "progress-bar-part"; break;
     case ProgressBarValuePart: ts << "progress-bar-value-part"; break;

Modified: trunk/Source/WebCore/platform/ThemeTypes.h (293510 => 293511)


--- trunk/Source/WebCore/platform/ThemeTypes.h	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/platform/ThemeTypes.h	2022-04-27 16:30:31 UTC (rev 293511)
@@ -40,39 +40,22 @@
     PushButtonPart,
     SquareButtonPart,
     ButtonPart,
-    ButtonBevelPart,
     DefaultButtonPart,
     InnerSpinButtonPart,
     ListboxPart,
     ListItemPart,
-    MediaControlsBackgroundPart,
     MediaControlsDarkBarBackgroundPart,
-    MediaControlsFullscreenBackgroundPart,
     MediaControlsLightBarBackgroundPart,
-    MediaCurrentTimePart,
-    MediaEnterFullscreenButtonPart,
-    MediaExitFullscreenButtonPart,
     MediaFullScreenVolumeSliderPart,
     MediaFullScreenVolumeSliderThumbPart,
-    MediaMuteButtonPart,
-    MediaOverlayPlayButtonPart,
     MediaPlayButtonPart,
-    MediaReturnToRealtimeButtonPart,
-    MediaRewindButtonPart,
-    MediaSeekBackButtonPart,
-    MediaSeekForwardButtonPart,
     MediaSliderPart,
     MediaSliderThumbPart,
-    MediaTimeRemainingPart,
-    MediaToggleClosedCaptionsButtonPart,
     MediaVolumeSliderPart,
-    MediaVolumeSliderContainerPart,
     MediaVolumeSliderMuteButtonPart,
     MediaVolumeSliderThumbPart,
     MenulistPart,
     MenulistButtonPart,
-    MenulistTextPart,
-    MenulistTextFieldPart,
     MeterPart,
     ProgressBarPart,
     ProgressBarValuePart,

Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (293510 => 293511)


--- trunk/Source/WebCore/rendering/RenderTheme.cpp	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp	2022-04-27 16:30:31 UTC (rev 293511)
@@ -274,12 +274,6 @@
     case MenulistButtonPart:
         return adjustMenuListButtonStyle(style, element);
     case MediaPlayButtonPart:
-    case MediaCurrentTimePart:
-    case MediaTimeRemainingPart:
-    case MediaEnterFullscreenButtonPart:
-    case MediaExitFullscreenButtonPart:
-    case MediaMuteButtonPart:
-    case MediaVolumeSliderContainerPart:
         return adjustMediaControlStyle(style, element);
     case MediaSliderPart:
     case MediaVolumeSliderPart:
@@ -533,33 +527,14 @@
     case SliderThumbHorizontalPart:
     case SliderThumbVerticalPart:
         return paintSliderThumb(box, paintInfo, integralSnappedRect);
-    case MediaEnterFullscreenButtonPart:
-    case MediaExitFullscreenButtonPart:
-        return paintMediaFullscreenButton(box, paintInfo, integralSnappedRect);
     case MediaPlayButtonPart:
         return paintMediaPlayButton(box, paintInfo, integralSnappedRect);
-    case MediaOverlayPlayButtonPart:
-        return paintMediaOverlayPlayButton(box, paintInfo, integralSnappedRect);
-    case MediaMuteButtonPart:
-        return paintMediaMuteButton(box, paintInfo, integralSnappedRect);
-    case MediaSeekBackButtonPart:
-        return paintMediaSeekBackButton(box, paintInfo, integralSnappedRect);
-    case MediaSeekForwardButtonPart:
-        return paintMediaSeekForwardButton(box, paintInfo, integralSnappedRect);
-    case MediaRewindButtonPart:
-        return paintMediaRewindButton(box, paintInfo, integralSnappedRect);
-    case MediaReturnToRealtimeButtonPart:
-        return paintMediaReturnToRealtimeButton(box, paintInfo, integralSnappedRect);
-    case MediaToggleClosedCaptionsButtonPart:
-        return paintMediaToggleClosedCaptionsButton(box, paintInfo, integralSnappedRect);
     case MediaSliderPart:
         return paintMediaSliderTrack(box, paintInfo, integralSnappedRect);
     case MediaSliderThumbPart:
         return paintMediaSliderThumb(box, paintInfo, integralSnappedRect);
     case MediaVolumeSliderMuteButtonPart:
-        return paintMediaMuteButton(box, paintInfo, integralSnappedRect);
-    case MediaVolumeSliderContainerPart:
-        return paintMediaVolumeSliderContainer(box, paintInfo, integralSnappedRect);
+        return paintMediaMuteButton(box, paintInfo, integralSnappedRect);    
     case MediaVolumeSliderPart:
         return paintMediaVolumeSliderTrack(box, paintInfo, integralSnappedRect);
     case MediaVolumeSliderThumbPart:
@@ -568,12 +543,6 @@
         return paintMediaFullScreenVolumeSliderTrack(box, paintInfo, integralSnappedRect);
     case MediaFullScreenVolumeSliderThumbPart:
         return paintMediaFullScreenVolumeSliderThumb(box, paintInfo, integralSnappedRect);
-    case MediaTimeRemainingPart:
-        return paintMediaTimeRemaining(box, paintInfo, integralSnappedRect);
-    case MediaCurrentTimePart:
-        return paintMediaCurrentTime(box, paintInfo, integralSnappedRect);
-    case MediaControlsBackgroundPart:
-        return paintMediaControlsBackground(box, paintInfo, integralSnappedRect);
     case MenulistButtonPart:
     case TextFieldPart:
     case TextAreaPart:

Modified: trunk/Source/WebCore/rendering/RenderTheme.h (293510 => 293511)


--- trunk/Source/WebCore/rendering/RenderTheme.h	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebCore/rendering/RenderTheme.h	2022-04-27 16:30:31 UTC (rev 293511)
@@ -395,23 +395,12 @@
     virtual bool paintSearchFieldResultsButton(const RenderBox&, const PaintInfo&, const IntRect&) { return true; }
 
     virtual void adjustMediaControlStyle(RenderStyle&, const Element*) const;
-    virtual bool paintMediaFullscreenButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaPlayButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaOverlayPlayButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaMuteButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaSeekBackButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaSeekForwardButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaSliderTrack(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaSliderThumb(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaVolumeSliderContainer(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaVolumeSliderTrack(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaVolumeSliderThumb(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaRewindButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaReturnToRealtimeButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaToggleClosedCaptionsButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaControlsBackground(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaCurrentTime(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
-    virtual bool paintMediaTimeRemaining(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaFullScreenVolumeSliderTrack(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
     virtual bool paintMediaFullScreenVolumeSliderThumb(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
 

Modified: trunk/Source/WebInspectorUI/ChangeLog (293510 => 293511)


--- trunk/Source/WebInspectorUI/ChangeLog	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebInspectorUI/ChangeLog	2022-04-27 16:30:31 UTC (rev 293511)
@@ -1,3 +1,16 @@
+2022-04-27  Ziran Sun  <[email protected]>
+
+        [css-ui] Remove some unimplemented -webkit-appearance keywords
+        https://bugs.webkit.org/show_bug.cgi?id=238930
+
+        Reviewed by Aditya Keerthi.
+
+        We might need to update the changes on UserInterface/External/CodeMirror/css.js since
+        PR https://github.com/codemirror/CodeMirror/pull/6912 has been merged in CodeMirror.
+
+        * UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
+        * UserInterface/External/CSSDocumentation/CSSDocumentation.js:
+
 2022-04-25  Devin Rousso  <[email protected]>
 
         Web Inspector: add UI for blocking requests

Modified: trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json (293510 => 293511)


--- trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json	2022-04-27 16:30:31 UTC (rev 293511)
@@ -1,5 +1,9 @@
 {
     "shape-outside": {
         "description": "Defines a shape around which adjacent inline content should wrap."
+    },
+    "-webkit-appearance": {
+        "description": "Changes the appearance of buttons and other controls to resemble native controls.",
+        "syntax": "none | button | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-play-button | media-slider | media-sliderthumb | media-volume-slider | media-volume-sliderthumb | menulist | menulist-button | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical | sliderthumb-horizontal | sliderthumb-vertical | square-button | textarea | textfield | -apple-pay-button"
     }
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js (293510 => 293511)


--- trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js	2022-04-27 15:49:39 UTC (rev 293510)
+++ trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js	2022-04-27 16:30:31 UTC (rev 293511)
@@ -29,7 +29,7 @@
     },
     "-webkit-appearance": {
         "description": "Changes the appearance of buttons and other controls to resemble native controls.",
-        "syntax": "none | button | button-bevel | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-controls-background | media-controls-fullscreen-background | media-current-time-display | media-enter-fullscreen-button | media-exit-fullscreen-button | media-fullscreen-button | media-mute-button | media-overlay-play-button | media-play-button | media-seek-back-button | media-seek-forward-button | media-slider | media-sliderthumb | media-time-remaining-display | media-toggle-closed-captions-button | media-volume-slider | media-volume-slider-container | media-volume-sliderthumb | menulist | menulist-button | menulist-text | menulist-textfield | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical | sliderthumb-horizontal | sliderthumb-vertical | squar
 e-button | textarea | textfield | -apple-pay-button"
+        "syntax": "none | button | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-play-button | media-slider | media-sliderthumb | media-volume-slider | media-volume-sliderthumb | menulist | menulist-button | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical | sliderthumb-horizontal | sliderthumb-vertical | square-button | textarea | textfield | -apple-pay-button"
     },
     "-webkit-backdrop-filter": {
         "description": "Applies a filter effect where the first filter in the list takes the element's background image as the input image."
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to