Title: [293614] trunk/Tools
Revision
293614
Author
jbed...@apple.com
Date
2022-04-29 08:24:12 -0700 (Fri, 29 Apr 2022)

Log Message

[ews-build.webkit.org] Link to PRs with undefined title
https://bugs.webkit.org/show_bug.cgi?id=239820
<rdar://problem/92416554>

Reviewed by Aakash Jain.

* CISupport/ews-build/steps.py:
(ConfigureBuild.add_pr_details):

Canonical link: https://commits.webkit.org/250120@main

Modified Paths

Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (293613 => 293614)


--- trunk/Tools/CISupport/ews-build/steps.py	2022-04-29 15:11:40 UTC (rev 293613)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-04-29 15:24:12 UTC (rev 293614)
@@ -533,8 +533,8 @@
 
         self.setProperty('change_id', revision[:HASH_LENGTH_TO_DISPLAY], 'ConfigureBuild')
 
-        if title:
-            self.addURL('PR {}: {}'.format(pr_number, title), GitHub.pr_url(pr_number, repository_url))
+        title = f': {title}' if title else ''
+        self.addURL(f'PR {pr_number}{title}', GitHub.pr_url(pr_number, repository_url))
         if owners:
             email, errors = GitHub.email_for_owners(owners)
             for error in errors:

Modified: trunk/Tools/ChangeLog (293613 => 293614)


--- trunk/Tools/ChangeLog	2022-04-29 15:11:40 UTC (rev 293613)
+++ trunk/Tools/ChangeLog	2022-04-29 15:24:12 UTC (rev 293614)
@@ -1,3 +1,14 @@
+2022-04-27  Jonathan Bedard  <jbed...@apple.com>
+
+        [ews-build.webkit.org] Link to PRs with undefined title
+        https://bugs.webkit.org/show_bug.cgi?id=239820
+        <rdar://problem/92416554>
+
+        Reviewed by Aakash Jain.
+
+        * CISupport/ews-build/steps.py:
+        (ConfigureBuild.add_pr_details):
+
 2022-04-28  Yusuke Suzuki  <ysuz...@apple.com>
 
         Support C files in Unified Builds
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to