Title: [293626] trunk/Tools
Revision
293626
Author
[email protected]
Date
2022-04-29 12:25:30 -0700 (Fri, 29 Apr 2022)

Log Message

REGRESSION (249864@main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI is failing
https://bugs.webkit.org/show_bug.cgi?id=239867

Reviewed by Sam Weinig.

Use values that are representative of iPhone 8, which is the model used for running
API tests.

* TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (293625 => 293626)


--- trunk/Tools/ChangeLog	2022-04-29 18:55:21 UTC (rev 293625)
+++ trunk/Tools/ChangeLog	2022-04-29 19:25:30 UTC (rev 293626)
@@ -1,3 +1,16 @@
+2022-04-29  Simon Fraser  <[email protected]>
+
+        REGRESSION (249864@main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI is failing
+        https://bugs.webkit.org/show_bug.cgi?id=239867
+
+        Reviewed by Sam Weinig.
+
+        Use values that are representative of iPhone 8, which is the model used for running
+        API tests.
+
+        * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
+        (TestWebKitAPI::TEST):
+
 2022-04-29  Jonathan Bedard  <[email protected]>
 
         [git-webkit] Redact bug title in branch name on alternate remotes

Modified: trunk/Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm (293625 => 293626)


--- trunk/Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm	2022-04-29 18:55:21 UTC (rev 293625)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm	2022-04-29 19:25:30 UTC (rev 293626)
@@ -124,9 +124,9 @@
 
 TEST(ScrollViewScrollabilityTests, ScrollableWithOverflowHiddenAndShrunkUI)
 {
-    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, viewHeight, 414)]);
+    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, viewHeight, 375)]);
 
-    // Simulate landscape phone with hidden bars.
+    // Simulate MobileSafari on landscape iPhone 8 with hidden bars.
     UIEdgeInsets obscuredInsets;
     obscuredInsets.top = 0;
     obscuredInsets.left = 0;
@@ -134,7 +134,7 @@
     obscuredInsets.right = 0;
 
     [webView _setObscuredInsets:obscuredInsets];
-    [webView _overrideLayoutParametersWithMinimumLayoutSize:CGSizeMake(viewHeight, 414) maximumUnobscuredSizeOverride:CGSizeMake(viewHeight, 414)];
+    [webView _overrideLayoutParametersWithMinimumLayoutSize:CGSizeMake(viewHeight, 325) maximumUnobscuredSizeOverride:CGSizeMake(viewHeight, 375)];
 
     [webView synchronouslyLoadHTMLString:nonScrollableDocumentMarkup];
     [webView waitForNextPresentationUpdate];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to